I would view it simply as continual improvement. This is definitely not something for which we would need to go back through already approved Themes; but rather, simply something that gets added *going forward*.<div><br></div>
<div>It would make a good candidate for the 3.2-specific changes to the Guidelines.</div><div><br></div><div>Chip<br><br><div class="gmail_quote">On Thu, Jun 23, 2011 at 4:51 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">OK, thanks for the info @Mike and @Otto ... I can accept it as a "doing it wrong" item, but the question for the Team now becomes how do we wade through all of the themes the search criteria finds aside from installing and "Theme Check"-ing them after the new test is implemented?<br>
<br>I'm not seeing this as a security issue (requiring immediate action), just simply "doing-it-wrong" scenarios where something might break. The use of $post-guid appears to be spread out amongst many different authors, too. Although this is being considered a "doing it wrong" item, can we grand-father the existing live themes in the repository and clamp down on new themes and submissions? I noticed some rather "popular" themes in the search results that I would rather not suspend as our first choice of action.<br>
<br>The Theme authors may not be using 'guid' *correctly*, but their themes appear to be functioning correctly all the same.<br><br><br>Cais.<div><div></div><div class="h5"><br><br><div class="gmail_quote">On Thu, Jun 23, 2011 at 5:23 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com" target="_blank">otto@ottodestruct.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Thu, Jun 23, 2011 at 4:14 PM, Chip Bennett <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>> wrote:<br>
> Is there a logical way to flag inappropriate use, while ignoring appropriate<br>
> use?<br>
<br>
</div>I thought something like this might work:<br>
<br>
If the theme uses the_guid() or get_the_guid() or $post->guid<br>
anywhere, and it also doesn't include the use of the add_feed()<br>
function anywhere else in the theme, then it's doing-it-wrong.<br>
<br>
add_feed would be the correct way to add feeds, and the only place<br>
using the guid makes sense is in a feed.<br>
<div><div></div><div><br>
-Otto<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>