The current "default" recommendation for the comment-reply.js script is to dump wp_enqueue_script() in the header.php template file. It works, but is less-than-ideal.<div><br></div><div>To clarify:</div><div><br>
</div><div>Front-end styles: use the 'wp_print_styles' hook</div><div>Front-end scripts: use the 'wp_enqueue_scripts' hook</div><div><br></div><div>And: ah yes, GoogleFonts. That's certainly valid. :) But, you'll want to advise the developer to hook the wp_enqueue_style() *function* into the 'wp_print_styles' *hook*. (You *can* hook into 'wp_head', but 'wp_print_styles' is more accurate.)</div>
<div><br></div><div>Chip<br><br><div class="gmail_quote">On Fri, Jun 3, 2011 at 5:48 AM, Vicky Arulsingam <span dir="ltr"><<a href="mailto:vicky.arulsingam@gmail.com">vicky.arulsingam@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="gmail_quote"><div class="im">On Fri, Jun 3, 2011 at 6:44 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I see a few issues:<div><br></div><div>1) Styles should be enqueued and *hooked* in; front-end styles should be hooked into 'wp_print_styles'.</div><div><br></div></blockquote><div><br></div></div><div>I've seen a number of themes that use wp_enqueue_style() / wp_enqueue_script within the header.php. I'll be sure to distinguish between wp_print_style and wp_enqueue_style in future reviews.</div>
<div class="im">
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div></div><div>2) 'MyStyle' is too generic of a name. This is another instance where something should be theme-slug prefixed.</div>
<div><br></div><div>3) Is the URL an external resource? I can't readily imagine a viable reason that a CSS file can't/shouldn't be bundled with the Theme.</div><div><br></div></blockquote><div><br></div></div>
<div>
The URL is indeed an external resource for Google Fonts. The theme author had hard-coded the link so I recommended using wp_enqueue_style hooked into wp_head().</div><div><br></div><div> -----</div></div><div>Vicky Arulsingam</div>
<font color="#888888">
<br>
</font><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>