Hello,<br><br>I'm just wondering, do you if program such as Adobe dreamweaver or Microsoft expression web will take care of this?<br><br>Also will this affect themes that have already been uploaded to the tracker and waiting to be approved?<br>
<br clear="all"><div style="font-family: georgia,serif;">Regards,<br>Daniel Fenn<br></div>
<div><br><br><img src="http://img256.imageshack.us/img256/2627/mtargb135413551353.png"> <img src="http://img508.imageshack.us/img508/1971/mtargb13191316.png"><br><br></div><br>
<br><br><div class="gmail_quote">On Fri, Jun 3, 2011 at 6:10 AM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Okay, so, a while back we had a problem where some themes were not<br>
being uploaded correctly to the Theme system. The symptom of this was<br>
that a ticket was created, but the theme itself didn't appear to get<br>
loaded into the SVN repository. I corrected this problem temporarily,<br>
via a revert of a code change. That was only temporary, today I'll be<br>
undoing that change and theme uploads will once again break. However,<br>
this time, they'll break with a warning and explanation.<br>
<br>
The underlying problem is one of DOS and UNIX style line endings. The<br>
change made to the WordPress SVN systems was made across the board,<br>
and it was to automatically set the svn:eol-style flag to "native".<br>
What this means is that text files will get their line ending styles<br>
converted between DOS and UNIX styles correctly, when they're<br>
retrieved from the SVN systems.<br>
<br>
The problem with this occurs when you have a single file that has BOTH<br>
types of line ending styles in it. SVN can't handle that, because it<br>
doesn't know which way to convert it. This frequently happens when<br>
you're using editors that aren't smart enough to do this sort of<br>
conversion for you when you are copy and pasting code between files.<br>
For example, if you have a file open with UNIX style endings and copy<br>
part of it into a file with DOS style endings, then some editors don't<br>
convert the line endings even though they display the paste normally.<br>
Result: weirdness.<br>
<br>
Now, PHP is like the honey-badger, and it just doesn't care which line<br>
ending style you use. Either way it's all whitespace to PHP. But SVN<br>
does care, so we have to care.<br>
<br>
To this end, I've added a new module to the Theme Check plugin, and<br>
will be releasing a new Theme Check version shortly. It will notify<br>
you which of your files, if any, have both types of line endings in<br>
them.<br>
<br>
To correct the problem in these files, various text editing programs<br>
have options to pick a line ending style in their Save functionality.<br>
In TextPad, for example, you just go to Save As, then choose the "File<br>
format" as either PC or UNIX. It honestly doesn't matter which you<br>
choose, as long as the file itself is consistent. I've tested this,<br>
and it does solve the problem. Notepad++ has a similar feature. On<br>
Linux or other unix-based systems, you can install the dos2unix<br>
command line program and it will correct these types of files as well.<br>
<br>
The reason I'm putting this on the theme author instead of just<br>
automatically having the dos2unix program run on themes automatically<br>
is because I can't be certain that themes won't get broken in some<br>
manner by automatically running programs over them and changing their<br>
contents as they upload. I want theme authors to be able to correct<br>
the problem and then to test their themes to make sure nothing is<br>
affected, before trying to upload them.<br>
<br>
Also note that this line ending problem only applies to text files.<br>
PHP, CSS, JS, TXT, that sort of thing. Images and such shouldn't be<br>
affected, as they are binary files.<br>
<br>
Anyway, this change will go into effect in a few hours, after I finish<br>
making the modifications. I'll release the updated theme check plugin<br>
shortly. I've tested it on the problem themes sent to me, and it seems<br>
to reliably detect the problem (and fail the theme check accordingly).<br>
<font color="#888888"><br>
-Otto<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</font></blockquote></div><br>