<div class="gmail_quote">On Fri, Jun 3, 2011 at 6:44 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I see a few issues:<div><br></div><div>1) Styles should be enqueued and *hooked* in; front-end styles should be hooked into 'wp_print_styles'.</div><div><br></div></blockquote><div><br></div><div>I've seen a number of themes that use wp_enqueue_style() / wp_enqueue_script within the header.php. I'll be sure to distinguish between wp_print_style and wp_enqueue_style in future reviews.</div>
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div></div><div>2) 'MyStyle' is too generic of a name. This is another instance where something should be theme-slug prefixed.</div>
<div><br></div><div>3) Is the URL an external resource? I can't readily imagine a viable reason that a CSS file can't/shouldn't be bundled with the Theme.</div><div><br></div></blockquote><div><br></div><div>
The URL is indeed an external resource for Google Fonts. The theme author had hard-coded the link so I recommended using wp_enqueue_style hooked into wp_head().</div><div><br></div><div> -----</div></div><div>Vicky Arulsingam</div>
<br>