Thanks for the feedback Chip. I had been debating whether to include the INFO notices and included them to err on the side of caution.<div><br></div><div>Vicky<br><br><div class="gmail_quote">On Tue, May 3, 2011 at 7:50 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Good evening, all!<div><br></div><div>Just a quick bit of feedback on reviews, primarily for the trainees, regarding Theme Check results.</div>
<div><br></div><div>For anything other than "Warning" or "Required" (which we shouldn't see, anyway, as the uploader should filter out Themes that return Warning/Required-level errors), the results are primarily for *your* information and reference. These results should help point you in the right direction regarding things to look for.</div>
<div><br></div><div>These results do NOT necessarily need to be output in the ticket.</div><div><br></div><div>The reason that I say that is because simply copy/pasting Theme Check results into the review comments can distract from the REQUIRED issues in the review, and can be misleading for the Theme developer. I've seen several instances where RECOMMENDED/INFO results were added to the ticket, but were not actually applicable to the Theme - and then the Theme developer got dinged in the subsequent ticket, for wrongly implementing changes based on those results. </div>
<div><br></div><div>For example: </div><div><ul><li>The get_template_part() include function only applies to *template-part* files (or code output in template-part files), and NOT (generally) to functions.php, or including library files (such as theme-options.php, etc.) within functions.php.</li>
<li>Hard-coded links are not inherently prohibited. This INFO output is only intended to help you review the Theme, by collecting all such links in one place, so that you can review them for appropriateness. If all such links are appropriate, then this INFO result should NOT be included in the review comments.</li>
</ul></div><div><br></div><div>The RECOMMENDED results, especially the ones regarding Theme features/functionality, may be useful to include. But if you include them, be sure to delineate them such that it is very clear that they are NOT required. I would suggest placing them *after* listing all of the required issues. (I generally leave them out altogether. The Theme developer sees them in the uploader output, and also when testing locally using Theme Check.)</div>
<div><br></div><div>In the end, remember that our ultimate goal is to communicate to the Theme developer the specific deficiencies in the Theme - the specific things that the Theme developer needs to address, in order for the Theme to pass the review.</div>
<div><br></div><div>Thanks, again, for all of your help and contributions with reviewing Themes!</div><div><br></div><font color="#888888"><div>Chip</div>
</font><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br><br>
</div>