I would suggest that bundled Plugins should keep their original function names, in order to perform proper function_exists/conflict-checking. Plugin *code* that is *incorporated* should adopt the Theme's function-naming convention.<div>
<br></div><div>(The same should hold true for textdomain. A bundled, translation-ready Plugin should already be declaring its own namespace, and should have appropriate language files included. Incorporated code, on the other hand, wouldn't - and so should have its translation also incorporated into the Theme.)<br>
<div><br></div><div>Also, in both cases, the bundling/incorporation must be noted, with proper copyright notice retained for the original code.</div><div><br></div><div>Beyond those points: establishing some "best practices" would be a good idea.</div>
<div><br></div><div>Chip<br><br><div class="gmail_quote">On Mon, May 2, 2011 at 8:40 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I would suggest putting forward a "best practice" method for bundling plugins to insure their inclusion is relatively future proof. As noted, generally speaking the code is GPL so that is the not the issues; but, keep in mind, do the bundled plugins hold to the "namespace" and "textdomain" requirements?<br>
<br>Once the Theme author makes all of those adjustments the bundled plugins may become no more than a very extensive functions.php file.<br><br>Just some thoughts ...<br><br><br>Cais.<div><div></div><div class="h5"><br>
<br><div class="gmail_quote">On Mon, May 2, 2011 at 8:29 AM, James Laws <span dir="ltr"><<a href="mailto:jamielaws@gmail.com" target="_blank">jamielaws@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yeah, my comment sounded like a license issue but I really meant it from a repository/end user and support perspective.<div>
<br></div><div><font color="#888888">James</font><div><div></div><div><br><br><div class="gmail_quote">On Mon, May 2, 2011 at 8:28 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From a GPL perspective, there's absolutely nothing wrong with it. The question is: what is appropriate/best for the repository/end user?<div>
<br></div><div><font color="#888888">Chip</font><div><div></div><div><br><br><div class="gmail_quote">On Mon, May 2, 2011 at 7:05 AM, James Laws <span dir="ltr"><<a href="mailto:jamielaws@gmail.com" target="_blank">jamielaws@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yeah, I think this is a sticky subject. I'm not sure I'm comfortable with it honestly. It's one thing to offer your own custom theme options but it's another thing altogether to bundle, in most cases, someone else's plugin. Not sure how I feel about that.<div>
<br></div><div><font color="#888888">James</font><div><div></div><div><br><br><div class="gmail_quote">On Mon, May 2, 2011 at 8:01 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This is probably a good topic for a wider discussion.<div><br></div><div>My initial thought is that *simple* Plugin functionality (e.g. breadcrumbs) being *properly incorporated* (i.e. not simply being bundled, and with proper function_exists checking for the original) is acceptable. But at some point, the complexity of the Plugin (e.g. Yoast SEO) should preclude it from being incorporated into the Theme.</div>
<div><br></div><div><font color="#888888">Chip</font><div><div></div><div><br><br><div class="gmail_quote">On Mon, May 2, 2011 at 12:16 AM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<font color="#333333"><font size="2"><font face="arial,helvetica,sans-serif">If the plugin is properly implemented there should be no problems. For example Coraline Theme implemented Theme options based on a plugin, so it's OK. Yoast Breadcrumbs are still current <a href="http://yoast.com/wordpress/breadcrumbs/" target="_blank">http://yoast.com/wordpress/breadcrumbs/</a> and I am not sure about <a href="http://themes.svn.wordpress.org/billions/1.1.2/core/plugins/seo-features.php" target="_blank">http://themes.svn.wordpress.org/billions/1.1.2/core/plugins/seo-features.php</a>. Now there is one thing to pay attention to and that is if they can be disabled (turned off) from i.e. Theme Options, just in case that user wants to use something else. I am sure that breadcrumb will not cause issues, however meta plugin could if the user installs any other SEO plugin. If one is "hardcoded" and other one installed as "real" plugin from plugins they could affect each other and or create double meta tags,</font></font></font><div>
<font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333"><font size="2"><font face="arial,helvetica,sans-serif"></font></font></font><font color="#333333" face="arial, helvetica, sans-serif">Cheers,</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif">Emil<br></font><div><font color="#333333"><font size="2"><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div>
<font color="#333333"><font size="2"><font face="arial,helvetica,sans-serif"><br clear="all"></font></font></font><div><b><font face="arial, helvetica, sans-serif">----</font></b></div><div><font face="arial, helvetica, sans-serif"><b>Emil Uzelac</b> | ThemeID | T: <a href="tel:224-444-0006" value="+12244440006" target="_blank">224-444-0006</a> | Twitter: @EmilUzelac | E: <a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a> | <a href="http://themeid.com/" target="_blank">http://themeid.com</a></font></div>
<div><font color="#999999" face="arial, helvetica, sans-serif">Make everything as simple as possible, but not simpler. - Albert Einstein</font></div><br>
<br><br><div class="gmail_quote"><div>On Sun, May 1, 2011 at 11:00 PM, Vicky Arulsingam <span dir="ltr"><<a href="mailto:vicky.arulsingam@gmail.com" target="_blank">vicky.arulsingam@gmail.com</a>></span> wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>
What's the official word on themes bundling plugins? The theme I'm currently reviewing (<a href="http://themes.trac.wordpress.org/ticket/3398" target="_blank">http://themes.trac.wordpress.org/ticket/3398</a>) is including Yoast Breadcrumbs and Add Meta Tags as part of the download package.<br clear="all">
<br><br>-----<div>Vicky Arulsingam</div><font color="#888888"><br>
</font><br></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div>