<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
This is probably not feasible anytime in the near future, but it
seems to me that plugin-dependency (and the appropriate dependency
checking) should be a WordPress feature and not left open to the
theme authors. Put another way, WordPress should have a way to
inform the user that a particular theme cannot be activated if a
particular plugin isn't already activated and installed.<br>
<br>
I'd bet we'd all agree that the best way to have plugin X's
functionality within theme Y is for the user to actually download
plugin X and theme Y. The only reason it's currently bundled with
the theme is to not add any extra inconvenience/confusion and to
minimize any additional roadblocks between downloading the theme and
actually using it.<br>
<br>
I'm not suggesting this be implemented now, and we could certainly
come up with best-practices in the meantime, but (if everyone
agrees) perhaps we could push to have this implemented in core.<br>
<br>
Thoughts?<br>
<br>
<br>
<br>
On 5/2/11 6:56 AM, Chip Bennett wrote:
<blockquote
cite="mid:BANLkTinN9vPzcBJ=D_Gg5TJ-Di32hFghTQ@mail.gmail.com"
type="cite">I would suggest that bundled Plugins should keep their
original function names, in order to perform proper
function_exists/conflict-checking. Plugin *code* that is
*incorporated* should adopt the Theme's function-naming
convention.
<div>
<br>
</div>
<div>(The same should hold true for textdomain. A bundled,
translation-ready Plugin should already be declaring its own
namespace, and should have appropriate language files included.
Incorporated code, on the other hand, wouldn't - and so should
have its translation also incorporated into the Theme.)<br>
<div><br>
</div>
<div>Also, in both cases, the bundling/incorporation must be
noted, with proper copyright notice retained for the original
code.</div>
<div><br>
</div>
<div>Beyond those points: establishing some "best practices"
would be a good idea.</div>
<div><br>
</div>
<div>Chip<br>
<br>
<div class="gmail_quote">On Mon, May 2, 2011 at 8:40 AM,
Edward Caissie <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
I would suggest putting forward a "best practice" method
for bundling plugins to insure their inclusion is
relatively future proof. As noted, generally speaking the
code is GPL so that is the not the issues; but, keep in
mind, do the bundled plugins hold to the "namespace" and
"textdomain" requirements?<br>
<br>
Once the Theme author makes all of those adjustments the
bundled plugins may become no more than a very extensive
functions.php file.<br>
<br>
Just some thoughts ...<br>
<br>
<br>
Cais.
<div>
<div class="h5"><br>
<br>
<div class="gmail_quote">On Mon, May 2, 2011 at 8:29
AM, James Laws <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:jamielaws@gmail.com"
target="_blank">jamielaws@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt
0pt 0pt 0.8ex; border-left: 1px solid rgb(204,
204, 204); padding-left: 1ex;">Yeah, my comment
sounded like a license issue but I really meant it
from a repository/end user and support
perspective.
<div>
<br>
</div>
<div><font color="#888888">James</font>
<div>
<div><br>
<br>
<div class="gmail_quote">On Mon, May 2, 2011
at 8:28 AM, Chip Bennett <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:chip@chipbennett.net"
target="_blank">chip@chipbennett.net</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin: 0pt 0pt 0pt 0.8ex;
border-left: 1px solid rgb(204, 204,
204); padding-left: 1ex;">From a GPL
perspective, there's absolutely nothing
wrong with it. The question is: what is
appropriate/best for the repository/end
user?
<div>
<br>
</div>
<div><font color="#888888">Chip</font>
<div>
<div><br>
<br>
<div class="gmail_quote">On Mon,
May 2, 2011 at 7:05 AM, James
Laws <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:jamielaws@gmail.com"
target="_blank">jamielaws@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid
rgb(204, 204, 204);
padding-left: 1ex;">Yeah, I
think this is a sticky
subject. I'm not sure I'm
comfortable with it honestly.
It's one thing to offer your
own custom theme options but
it's another thing altogether
to bundle, in most cases,
someone else's plugin. Not
sure how I feel about that.
<div>
<br>
</div>
<div><font color="#888888">James</font>
<div>
<div><br>
<br>
<div class="gmail_quote">On
Mon, May 2, 2011 at
8:01 AM, Chip Bennett
<span dir="ltr"><<a
moz-do-not-send="true" href="mailto:chip@chipbennett.net"
target="_blank">chip@chipbennett.net</a>></span>
wrote:<br>
<blockquote
class="gmail_quote"
style="margin: 0pt
0pt 0pt 0.8ex;
border-left: 1px
solid rgb(204, 204,
204); padding-left:
1ex;">
This is probably a
good topic for a
wider discussion.
<div><br>
</div>
<div>My initial
thought is that
*simple* Plugin
functionality
(e.g. breadcrumbs)
being *properly
incorporated*
(i.e. not simply
being bundled, and
with proper
function_exists
checking for the
original) is
acceptable. But at
some point, the
complexity of the
Plugin (e.g. Yoast
SEO) should
preclude it from
being incorporated
into the Theme.</div>
<div><br>
</div>
<div><font
color="#888888">Chip</font>
<div>
<div><br>
<br>
<div
class="gmail_quote">On
Mon, May 2,
2011 at 12:16
AM, Emil
Uzelac <span
dir="ltr"><<a
moz-do-not-send="true" href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span>
wrote:<br>
<blockquote
class="gmail_quote"
style="margin:
0pt 0pt 0pt
0.8ex;
border-left:
1px solid
rgb(204, 204,
204);
padding-left:
1ex;">
<font
color="#333333"><font
size="2"><font
face="arial,helvetica,sans-serif">If the plugin is properly implemented
there should
be no
problems. For
example
Coraline Theme
implemented
Theme options
based on a
plugin, so
it's OK. Yoast
Breadcrumbs
are still
current <a
moz-do-not-send="true"
href="http://yoast.com/wordpress/breadcrumbs/" target="_blank">http://yoast.com/wordpress/breadcrumbs/</a>
and I am not
sure about <a
moz-do-not-send="true"
href="http://themes.svn.wordpress.org/billions/1.1.2/core/plugins/seo-features.php"
target="_blank">http://themes.svn.wordpress.org/billions/1.1.2/core/plugins/seo-features.php</a>.
Now there is
one thing to
pay attention
to and that is
if they can be
disabled
(turned off)
from i.e.
Theme Options,
just in case
that user
wants to use
something
else. I am
sure that
breadcrumb
will not cause
issues,
however meta
plugin could
if the user
installs any
other SEO
plugin. If one
is "hardcoded"
and other one
installed as
"real" plugin
from plugins
they could
affect each
other and or
create double
meta tags,</font></font></font>
<div>
<font
color="#333333"
face="arial,
helvetica,
sans-serif"><br>
</font></div>
<div><font
color="#333333"
face="arial,
helvetica,
sans-serif">Cheers,</font></div>
<div><font
color="#333333"
face="arial,
helvetica,
sans-serif">Emil<br>
</font>
<div><font
color="#333333"><font
size="2"><font
face="arial,helvetica,sans-serif"><br>
</font></font></font></div>
<div>
<font
color="#333333"><font
size="2"><font
face="arial,helvetica,sans-serif"><br clear="all">
</font></font></font>
<div><b><font
face="arial,
helvetica,
sans-serif">----</font></b></div>
<div><font
face="arial,
helvetica,
sans-serif"><b>Emil
Uzelac</b> |
ThemeID | T: <a
moz-do-not-send="true" href="tel:224-444-0006" value="+12244440006"
target="_blank">224-444-0006</a>
| Twitter:
@EmilUzelac |
E: <a
moz-do-not-send="true"
href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a> | <a
moz-do-not-send="true" href="http://themeid.com/" target="_blank">http://themeid.com</a></font></div>
<div><font
color="#999999"
face="arial,
helvetica,
sans-serif">Make
everything as
simple as
possible, but
not simpler. -
Albert
Einstein</font></div>
<br>
<br>
<br>
<div
class="gmail_quote">
<div>On Sun,
May 1, 2011 at
11:00 PM,
Vicky
Arulsingam <span
dir="ltr"><<a
moz-do-not-send="true" href="mailto:vicky.arulsingam@gmail.com"
target="_blank">vicky.arulsingam@gmail.com</a>></span>
wrote:<br>
</div>
<blockquote
class="gmail_quote"
style="margin:
0pt 0pt 0pt
0.8ex;
border-left:
1px solid
rgb(204, 204,
204);
padding-left:
1ex;">
<div>
What's the
official word
on themes
bundling
plugins? The
theme I'm
currently
reviewing (<a
moz-do-not-send="true"
href="http://themes.trac.wordpress.org/ticket/3398"
target="_blank">http://themes.trac.wordpress.org/ticket/3398</a>) is
including
Yoast
Breadcrumbs
and Add Meta
Tags as part
of the
download
package.<br
clear="all">
<br>
<br>
-----
<div>Vicky
Arulsingam</div>
<font
color="#888888"><br>
</font><br>
</div>
_______________________________________________<br>
theme-reviewers
mailing list<br>
<a
moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a
moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers
mailing list<br>
<a
moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a
moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers
mailing list<br>
<a
moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a
moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org"
target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org"
target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org"
target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
theme-reviewers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a>
<a class="moz-txt-link-freetext" href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
</body>
</html>