<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
I probably didn't explain myself well enough in the first email.<br>
<br>
We're not looking at the "type" parameter of wp_list_comments().
We're looking at the "callback" parameter here. This is where a
theme is overriding core functionality. If the theme didn't
override this functionality with a custom function, WordPress would
display other comment types by default. <br>
<br>
A plugin cannot be responsible for incorporating custom comment
types if a theme is purposely not allowing comments of a custom type
to show. There's no hook to allow a plugin to override what a theme
is doing there. Even if there was a hook there, this would be a
major problem if a plugin was changing how a theme handled the
display of comments.<br>
<br>
What's happening here is themes are overriding core functionality
without handling every scenario that core handles by default.<br>
<br>
On 4/26/2011 3:18 PM, Chip Bennett wrote:
<blockquote
cite="mid:BANLkTimYRVu+3FVnT0LB7NoWS0sriJNOnw@mail.gmail.com"
type="cite">Quite possibly. But it is not the responsibility of
Themes to account for content added by Plugins.
<div><br>
</div>
<div>I see no reason to require Themes to support a non-core
'tweetback' comment-type. If a Plugin adds this comment-type,
then the Plugin should be responsible for incorporating it.</div>
<div><br>
</div>
<div>Chip<br>
<br>
<div class="gmail_quote">On Tue, Apr 26, 2011 at 3:14 PM,
Sayontan Sinha <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:sayontan@gmail.com">sayontan@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
Chip,<br>
I believe Justin is referring to the fact that plugins can
add the type "tweetback". If that is the case, then a theme
that is explicitly checking only for "comment", "pingback"
and "trackback" is missing out on the ones that don't fall
into these buckets, i.e. it is missing a catch-all for types
introduced by plugins.<br>
<br>
Sayontan.
<div>
<div class="h5"><br>
<br>
<div class="gmail_quote">On Tue, Apr 26, 2011 at 12:49
PM, Chip Bennett <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt
0pt 0.8ex; border-left: 1px solid rgb(204, 204,
204); padding-left: 1ex;">
I can't find that 'tweetback' is a core comment
type.
<div><br>
</div>
<div><a moz-do-not-send="true"
href="http://codex.wordpress.org/Function_Reference/wp_list_comments"
target="_blank">According to the Codex</a>, the
valid types are: <span style="font-family: 'Lucida
Grande',Verdana,'Bitstream Vera
Sans',Arial,sans-serif; font-size: 12px;
line-height: 22px;">'all', 'comment',
'trackback', 'pingback', or 'pings'</span></div>
<div><br>
</div>
<div>So, if a Theme accounts for these types, that
should be sufficient. For instance, if a Theme
accounts for 'comments' and 'pings', all bases are
covered.</div>
<div><br>
</div>
<div><font color="#888888">Chip</font>
<div>
<div><br>
<br>
<div class="gmail_quote">On Tue, Apr 26, 2011
at 2:39 PM, Chip Bennett <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:chip@chipbennett.net"
target="_blank">chip@chipbennett.net</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin: 0pt 0pt 0pt 0.8ex;
border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
Hmm... I don't think I've yet seen a Theme
that explicitly handles tweetbacks.
(Honestly, I didn't even realize such a
comment type existed.)
<div><br>
</div>
<div><font color="#888888">Chip</font>
<div>
<div><br>
<br>
<div class="gmail_quote">On Wed, Apr
27, 2011 at 2:16 PM, Justin
Tadlock <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:justin@justintadlock.com"
target="_blank">justin@justintadlock.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid
rgb(204, 204, 204);
padding-left: 1ex;">Here's a few
things we should be on the
lookout for when reviewing
themes that I thought I'd bring
up.<br>
<br>
The use of the_post_thumbnail()
with the_content() can sometimes
be a problem. If a user places
the image within the post
content (at the beginning of the
post) and sets the same image as
the "feature image," it creates
a duplicate image issue. Some
themes' designs are meant to
handle this while others aren't.<br>
<br>
Some themes have a comments
callback function where they
don't recognize comment types
other than 'comment',
'pingback', and 'trackback'.
This is also the case in the
TwentyTen theme. If you look at
its switch statement, you'll
notice it doesn't give a
'default' case. It should be
corrected to handle all comment
types (e.g., tweetbacks).<br>
<br>
Loading JS and CSS on all pages
of the admin. Sometimes, themes
hook their theme settings page
JavaScript and Stylesheet to the
'admin_init' hook or something
similar. This should only be
loaded on the the theme settings
page. If using the
add_theme_page() function, a
hook is created just for that
page. A better hook would
probably be
'load-appearance_page_$pagename'.<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org"
target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org"
target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<br>
</div>
</div>
-- <br>
Sayontan Sinha<br>
<a moz-do-not-send="true" href="http://mynethome.net"
target="_blank">http://mynethome.net</a> | <a
moz-do-not-send="true" href="http://mynethome.net/blog"
target="_blank">http://mynethome.net/blog</a><br>
<font color="#888888">
--<br>
Beating Australia in Cricket is like killing a celebrity.
The death gets more coverage than the crime.<br>
<br>
</font><br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a moz-do-not-send="true"
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a moz-do-not-send="true"
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
theme-reviewers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a>
<a class="moz-txt-link-freetext" href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a>
</pre>
</blockquote>
</body>
</html>