Chip,<br>I believe Justin is referring to the fact that plugins can add the type "tweetback". If that is the case, then a theme that is explicitly checking only for "comment", "pingback" and "trackback" is missing out on the ones that don't fall into these buckets, i.e. it is missing a catch-all for types introduced by plugins.<br>
<br>Sayontan.<br><br><div class="gmail_quote">On Tue, Apr 26, 2011 at 12:49 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I can't find that 'tweetback' is a core comment type.<div><br></div><div><a href="http://codex.wordpress.org/Function_Reference/wp_list_comments" target="_blank">According to the Codex</a>, the valid types are:Â <span style="font-family:'Lucida Grande', Verdana, 'Bitstream Vera Sans', Arial, sans-serif;font-size:12px;line-height:22px">'all', 'comment', 'trackback', 'pingback', or 'pings'</span></div>
<div><br></div><div>So, if a Theme accounts for these types, that should be sufficient. For instance, if a Theme accounts for 'comments' and 'pings', all bases are covered.</div><div><br></div><div><font color="#888888">Chip</font><div>
<div></div><div class="h5"><br>
<br><div class="gmail_quote">On Tue, Apr 26, 2011 at 2:39 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hmm... I don't think I've yet seen a Theme that explicitly handles tweetbacks. (Honestly, I didn't even realize such a comment type existed.)<div><br></div><div><font color="#888888">Chip</font><div><div></div>
<div><br><br><div class="gmail_quote">On Wed, Apr 27, 2011 at 2:16 PM, Justin Tadlock <span dir="ltr"><<a href="mailto:justin@justintadlock.com" target="_blank">justin@justintadlock.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Here's a few things we should be on the lookout for when reviewing themes that I thought I'd bring up.<br>
<br>
The use of the_post_thumbnail() with the_content() can sometimes be a problem. Â If a user places the image within the post content (at the beginning of the post) and sets the same image as the "feature image," it creates a duplicate image issue. Â Some themes' designs are meant to handle this while others aren't.<br>
<br>
Some themes have a comments callback function where they don't recognize comment types other than 'comment', 'pingback', and 'trackback'. Â This is also the case in the TwentyTen theme. Â If you look at its switch statement, you'll notice it doesn't give a 'default' case. Â It should be corrected to handle all comment types (e.g., tweetbacks).<br>
<br>
Loading JS and CSS on all pages of the admin. Â Sometimes, themes hook their theme settings page JavaScript and Stylesheet to the 'admin_init' hook or something similar. Â This should only be loaded on the the theme settings page. Â If using the add_theme_page() function, a hook is created just for that page. Â A better hook would probably be 'load-appearance_page_$pagename'.<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote></div><br></div></div></div>
</blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br>Beating Australia in Cricket is like killing a celebrity. The death gets more coverage than the crime.<br><br>