There may be more than you realize. :)<div><br></div><div>Google results for "home.php" in SVN: <meta http-equiv="content-type" content="text/html; charset=utf-8"><a href="http://www.google.com/#q=%22home.php%22+site:themes.svn.wordpress.org&fp=2e0367e39f3acd1c&hl=en&safe=off">http://www.google.com/#q=%22home.php%22+site:themes.svn.wordpress.org&fp=2e0367e39f3acd1c&hl=en&safe=off</a></div>
<div><br></div><div>Google results for "front-page.php" in SVN:</div><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><a href="http://www.google.com/#q=%22front-page.php%22+site:themes.svn.wordpress.org&fp=2e0367e39f3acd1c&hl=en&safe=off">http://www.google.com/#q=%22front-page.php%22+site:themes.svn.wordpress.org&fp=2e0367e39f3acd1c&hl=en&safe=off</a></div>
<div><br></div><div>But here's my thinking:</div><div>1) It doesn't negatively impact Themes that include neither template file</div><div>2) It eliminates the need to make setup changes from Theme to Theme</div><div>
3) It removes an opportunity to overlook something that will be *very* important to the end user</div><div><br></div><div>I definitely don't see a need for *two* sets of Theme Unit Test data. After all, this change would merely add two additional static Pages.</div>
<div><br></div><div>In any case, I'll do some experimenting, and report back regarding what positive/negative difference this setup makes.</div><div><br></div><div>Chip<br><br></div><div>p.s. note: some of my ideas (good, bad, or otherwise) come not from reviewing Themes, but from spending time in the WPORG support forums, where I run into end-user problems that might not otherwise be as apparent. The mis-use of "home.php" is one such issue.</div>
<div><br><div class="gmail_quote">On Fri, Apr 22, 2011 at 8:56 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I think I understand what you are trying to accomplish, but how many themes actually include a home.php or front-page.php template ... I do not recall any recent ones that I have looked at.<br><br>Besides a simple review of the included template files will tell you if you are, or should be, testing the functionality of the home.php and/or front-page.php templates.<br>
<br>By all means, switch over your test environment to more suitably test those templates, I would even suggest some of the other reviewers volunteer to do it as a trial ...<br><br>... maybe have two Theme Unit Test data sets: one for "standard" blogging; and, another for a "standard" CMS setup, which is where I would expect the home.php and front-page.php templates to more typically be used.<br>
<br><br>Cais.<br><br><div class="gmail_quote"><div><div></div><div class="h5">On Fri, Apr 22, 2011 at 9:40 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div></div><div class="h5">
All,<div><br></div><div>I'm thinking of switching up my review setup (and perhaps adjusting the Theme Unit Test data accordingly), such that by default, it is setup to use a Static Page as the Front Page, and a separate Static Page for the Blog Posts Index.</div>
<div><br></div><div>I've seen a few instances where:</div><div><br></div><div>1) I might forget to test the front-page.php template file, or</div><div>2) The Theme Developer mistakenly uses "home.php" instead of "front-page.php" as the Front Page template, which causes the Blog Posts Index to behave incorrectly when in a Static Front Page setup.</div>
<div><br></div><div>I'm trying to think of any drawbacks, but can't come up with anything. If the Theme doesn't include "front-page.php" and/or "home.php", then the template hierarchy will fall back properly to "page.php" for the Static Front Page and "index.php" for the Blog Posts Index.</div>
<div><br></div><div>Can anyone think of any drawbacks with using this approach?</div><div><br></div><font color="#888888"><div>Chip</div>
</font><br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>