Yep ... what Chip said (*grin*).<br><br><br>Cais.<br><br><div class="gmail_quote">On Fri, Apr 22, 2011 at 3:55 PM, SFNdesign <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca">curtis@curtismchale.ca</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div bgcolor="#FFFFFF"><div>I put it on my list. The only reason I mentioned it earlier was because others had a better grasp on it. I'm happy to do it. <br>
<font color="#888888"><br>Curtis McHale<div><a href="tel:604.751.3482" value="+16047513482" target="_blank">604.751.3482</a></div></font></div><div><div></div><div class="h5"><div><br>On 2011-04-22, at 12:53 PM, Chip Bennett <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>> wrote:<br>
<br></div><div></div><blockquote type="cite"><div>And if I'm reading Cais correctly, I would say that this instance (use of get_template_part() vs locate_template()) would be a good example of an instance where the Codex could be edited to clarify, without any needed discussion beforehand, if you are comfortable with providing a more detailed explanation. (As a courtesy, you could email the list to say, "hey, I made this change" - but several people "watch" that Codex page, so changes don't go unnoticed, anyway. ;) )<div>
<br></div><div>Chip<br><br><div class="gmail_quote">On Fri, Apr 22, 2011 at 2:49 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank"></a><a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Actually, as I see it, those especially involved with doing Theme reviews should be addressing items on the related codex pages regarding the guidelines that are being used.<br><br>IF there is some sort of ambiguity or confusion then it should be addressed. If there is a concern on how the item is to be addressed, it can be easily discussed here then addressed in the codex.<br>
<br><br>Cais.<div><div></div><div><br><br><div class="gmail_quote">On Fri, Apr 22, 2011 at 2:48 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank"></a><a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
It's just like any other WordPress Codex page - especially for something like clarifying a requirement, feel free to edit!<div><br></div><div><font color="#888888">Chip</font><div><div></div><div><br><br><div class="gmail_quote">
On Fri, Apr 22, 2011 at 1:46 PM, Curtis McHale <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca" target="_blank"></a><a href="mailto:curtis@curtismchale.ca" target="_blank">curtis@curtismchale.ca</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yes I do and I've updated lots of other pages, just not sure I had the 'clout' to update this with all of the information of some of the others on the list.<div>
<br clear="all"><br>Curtis McHale<br>PH: <a href="tel:604.751.3482" value="+16047513482" target="_blank">604.751.3482</a><br>
<a href="http://www.curtismchale.ca" target="_blank"></a><a href="http://www.curtismchale.ca" target="_blank">http://www.curtismchale.ca</a><br>Linkedin: <a href="http://www.linkedin.com/in/curtismchale" target="_blank"></a><a href="http://www.linkedin.com/in/curtismchale" target="_blank">http://www.linkedin.com/in/curtismchale</a><br>
Twitter: <a href="http://twitter.com/curtismchale" target="_blank"></a><a href="http://twitter.com/curtismchale" target="_blank">twitter.com/curtismchale</a><br>
<br>
<br><br></div><div><div></div><div><div class="gmail_quote">On Fri, Apr 22, 2011 at 11:43 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank"></a><a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
You know it's a <i>wiki</i>, right? ;)<div><br></div><div><font color="#888888">Chip</font><div><div></div><div><br><br><div class="gmail_quote">On Fri, Apr 22, 2011 at 1:10 PM, Curtis McHale <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca" target="_blank"></a><a href="mailto:curtis@curtismchale.ca" target="_blank">curtis@curtismchale.ca</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I just looked at the theme review guidelines and it's probably worth clarifying them in regard to locate_template and get_template_part. Currently they say to use get_template_part to include custom template files. It's actually listed as <b>required</b> which obviously could cause confusion.<div>
<br clear="all">
<br>Curtis McHale<br>PH: <a href="tel:604.751.3482" value="+16047513482" target="_blank">604.751.3482</a><br><a href="http://www.curtismchale.ca" target="_blank"></a><a href="http://www.curtismchale.ca" target="_blank">http://www.curtismchale.ca</a><br>
Linkedin: <a href="http://www.linkedin.com/in/curtismchale" target="_blank"></a><a href="http://www.linkedin.com/in/curtismchale" target="_blank">http://www.linkedin.com/in/curtismchale</a><br>
Twitter: <a href="http://twitter.com/curtismchale" target="_blank"></a><a href="http://twitter.com/curtismchale" target="_blank">twitter.com/curtismchale</a><br>
<br>
<br><br></div><div><div></div><div><div class="gmail_quote">On Fri, Apr 22, 2011 at 10:58 AM, Curtis McHale <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca" target="_blank"></a><a href="mailto:curtis@curtismchale.ca" target="_blank">curtis@curtismchale.ca</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks for all the information. I'll include the proper usage in my theme notes.<div><br clear="all"><br>Curtis McHale<br>PH: <a href="tel:604.751.3482" value="+16047513482" target="_blank">604.751.3482</a><br><a href="http://www.curtismchale.ca" target="_blank"></a><a href="http://www.curtismchale.ca" target="_blank">http://www.curtismchale.ca</a><br>
Linkedin: <a href="http://www.linkedin.com/in/curtismchale" target="_blank"></a><a href="http://www.linkedin.com/in/curtismchale" target="_blank">http://www.linkedin.com/in/curtismchale</a><br>
Twitter: <a href="http://twitter.com/curtismchale" target="_blank"></a><a href="http://twitter.com/curtismchale" target="_blank">twitter.com/curtismchale</a><br><br>
<br><br></div><div><div></div><div><div class="gmail_quote">On Fri, Apr 22, 2011 at 10:15 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank"></a><a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
So, I found <a href="http://themes.svn.wordpress.org/wiredrive-classic/1.0.1/css/custom-css.php" target="_blank">the code you're talking about</a>.<div><br></div><div>The correct way to do this:</div><div><br></div><div>
1) Wrap that output in a function, e.g.:</div>
<div><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div>function wiredrive-classic_custom_css() {</div><div> include( get_template_directory() . '/css/custom-css.php' );</div>
<div>}</div></blockquote><div><br></div><div>2) Enqueue the function (increase priority as needed):</div><div><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px">
<div>add_action( 'wp_print_styles', 'wiredrive-classic_custom_css', 11 );</div></blockquote><div><br></div><div>And that's it.</div><div><br></div><div>Chip</div><div><br><div class="gmail_quote"><div>
On Fri, Apr 22, 2011 at 11:34 AM, Curtis McHale <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca" target="_blank"></a><a href="mailto:curtis@curtismchale.ca" target="_blank">curtis@curtismchale.ca</a>></span> wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div></div><div>I'm reviewing a theme and I've found uses of get_template_part where I believe that locate_template is the proper item. Specifically the code below loads the custom stylesheet.<div>
<br></div><div><div><?php get_template_part('css/custom-css')?></div>
<div><br></div><div>It was my understanding that in this case we should use:</div><div><br></div><div><?php locate_template( array( '/css/custom-css.css' ), 1); ?></div><div><br></div><div>and that get_template part was to call a file in the same directory like loop-main.php. Is there established best practice and if so what is it? Is the use above an okay way to call a custom stylesheet in to the theme? If not what way is currently advised?</div>
<br>Curtis McHale<br>PH: <a href="tel:604.751.3482" value="+16047513482" target="_blank">604.751.3482</a><br><a href="http://www.curtismchale.ca" target="_blank"></a><a href="http://www.curtismchale.ca" target="_blank">http://www.curtismchale.ca</a><br>
Linkedin: <a href="http://www.linkedin.com/in/curtismchale" target="_blank"></a><a href="http://www.linkedin.com/in/curtismchale" target="_blank">http://www.linkedin.com/in/curtismchale</a><br>
Twitter: <a href="http://twitter.com/curtismchale" target="_blank"></a><a href="http://twitter.com/curtismchale" target="_blank">twitter.com/curtismchale</a><br>
<br>
</div>
<br></div></div><div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></div></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>theme-reviewers mailing list</span><br><span><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a></span><br>
<span><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></span><br></div></blockquote></div></div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>