Done. Theme should not be approved.<div><br></div><div><a href="http://themes.trac.wordpress.org/ticket/3419#comment:3">http://themes.trac.wordpress.org/ticket/3419#comment:3</a></div><div><br></div><div><a href="http://themes.trac.wordpress.org/ticket/3419#comment:3"></a>Send me another one and let me know if I'm not doing stuff I should be in Trac, never really updated stuff in Trac so I could easily miss stuff.</div>
<div><br>Curtis McHale<br>PH: 604.751.3482<br><a href="http://www.curtismchale.ca">http://www.curtismchale.ca</a><br>Linkedin: <a href="http://www.linkedin.com/in/curtismchale">http://www.linkedin.com/in/curtismchale</a><br>
Twitter: <a href="http://twitter.com/curtismchale">twitter.com/curtismchale</a><br><br>
<br><br><div class="gmail_quote">On Mon, Apr 18, 2011 at 5:55 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
@Curtis - Here ya go: <a href="http://themes.trac.wordpress.org/ticket/3419" target="_blank">http://themes.trac.wordpress.org/ticket/3419</a><div><div></div><div class="h5"><br><br><div class="gmail_quote">On Sun, Apr 17, 2011 at 10:04 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><font size="2"><font face="tahoma,sans-serif">menu is OK, widgetized menu is OK too ;)<br clear="all"></font></font><div>
<div><b>----</b></div><div><b>Emil Uzelac</b> | ThemeID | T: <a href="tel:224-444-0006" value="+12244440006" target="_blank">224-444-0006</a> | Twitter: @EmilUzelac | E: <a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a> | <a href="http://themeid.com/" target="_blank">http://themeid.com</a></div>
<div><font color="#999999">Make everything as simple as possible, but not simpler. - Albert Einstein</font></div><br>
<br><br></div><div class="gmail_quote"><div>On Sun, Apr 17, 2011 at 7:54 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
</div><div><div></div><div><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
I actually disagree regarding the "Menu" Widget - maybe. :)<div><br></div><div>If the Theme simply provides a Widgetized sidebar, and no "Navigation Menu" markup, then this approach is fine. However, if the Theme has what would reasonably considered to be the design intent of a Navigation Menu, then that implementation must support the core Nav Menu feature.</div>
<div><br></div><div>Basically: Themes are not *required* to provide Navigation Menus, but if they *do* provide a Navigation Menu, then it must support the core functionality.</div><div><br></div><div><font color="#888888">Chip</font><div>
<div></div><div><br><br><div class="gmail_quote">
On Sun, Apr 17, 2011 at 7:13 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
<div><div><font size="2"><font face="tahoma,sans-serif">1. The theme uses the text domain of Twenty Ten in a few spots. If I remember correctly from lurking on the list this is a reason for failure of the theme.</font></font></div>
</div><div><font face="Tahoma"><b>Yes, Twenty Ten should be changed to i.e. silverville</b></font></div><div><div><b><font face="Tahoma"></font></b> </div><div><font size="2"><font face="tahoma,sans-serif">2. They use a widget for the menu and instruct the user to add the Pages widget. It seems to me that it's a much better option to use a WordPress menu which defaults to list pages. I don't believe this is an issue for a fail but probably a good suggestion as an update to the user.</font></font></div>
</div><div><font face="Tahoma"><b>This part is just fine. As long as there are options for menu and being fully functional.</b></font></div><div><div><b><font face="Tahoma"></font></b> </div>
<div><font size="2"><font face="tahoma,sans-serif">3. The CSS fails on the background-color since it's value is set to 'none' when it should be set to 'transparent'. Would this typically be a reason for failure if all other CSS is okay?</font></font></div>
</div><div><font face="Tahoma"><b>background-color: none; is invalid and it should be transparent. Recommendation would be background: none; or background-image: none; and not many people use the last one anymore. It's shortcoded via background.</b></font></div>
<div>
<div><b><font face="Tahoma"></font></b> </div><div><font size="2"><font face="tahoma,sans-serif">4. There are a number of other 'recommended' items in Theme Check but these are not a reason to fail a theme correct?</font></font></div>
</div><div><font size="2"><font face="tahoma,sans-serif"><b>Recommended isn't required, if recommendations don't cause problems, no need to fail.<br clear="all"></b></font></font></div><font size="2"><font face="tahoma,sans-serif"></font></font><div>
Emil</div><div><b></b> </div><div><b>----</b></div><div><b>Emil Uzelac</b> | ThemeID | T: <a href="tel:224-444-0006" value="+12244440006" target="_blank">224-444-0006</a> | Twitter: @EmilUzelac | E: <a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a> | <a href="http://themeid.com/" target="_blank">http://themeid.com</a></div>
<font color="#888888">
<div><font color="#999999">Make everything as simple as possible, but not simpler. - Albert Einstein</font></div></font><div><div></div><div><br>
<br><br><div class="gmail_quote">On Sun, Apr 17, 2011 at 7:01 PM, Curtis McHale <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca" target="_blank">curtis@curtismchale.ca</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
I have a few questions about my first theme review.<div><br></div><div>1. The theme uses the text domain of Twenty Ten in a few spots. If I remember correctly from lurking on the list this is a reason for failure of the theme.</div>
<div>2. They use a widget for the menu and instruct the user to add the Pages widget. It seems to me that it's a much better option to use a WordPress menu which defaults to list pages. I don't believe this is an issue for a fail but probably a good suggestion as an update to the user.</div>
<div>3. The CSS fails on the background-color since it's value is set to 'none' when it should be set to 'transparent'. Would this typically be a reason for failure if all other CSS is okay?</div><div>
4. There are a number of other 'recommended' items in Theme Check but these are not a reason to fail a theme correct?</div><div><br></div><div>I could probably go further in to the theme but I wanted to double check on the text domain item before I did.</div>
<div><div><br>Curtis McHale<br>PH: <a href="tel:604.751.3482" value="+16047513482" target="_blank">604.751.3482</a><br><a href="http://www.curtismchale.ca" target="_blank">http://www.curtismchale.ca</a><br>Linkedin: <a href="http://www.linkedin.com/in/curtismchale" target="_blank">http://www.linkedin.com/in/curtismchale</a><br>
Twitter: <a href="http://twitter.com/curtismchale" target="_blank">twitter.com/curtismchale</a><br><br>
<br><br></div><div><div></div><div><div class="gmail_quote">On Sat, Apr 16, 2011 at 4:39 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
Here ya go: <a href="http://themes.trac.wordpress.org/ticket/3320" target="_blank">http://themes.trac.wordpress.org/ticket/3320</a><br>This will get you started ...<br><br><br>Cais.<br><br><div class="gmail_quote">On Sat, Apr 16, 2011 at 7:15 PM, Curtis McHale <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca" target="_blank">curtis@curtismchale.ca</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">Figured I'd finally get off my butt and join the team after looking at the list for a few months. My trac name is curtismchale<div>
<br>Curtis McHale<br>PH: <a href="tel:604.751.3482" value="+16047513482" target="_blank">604.751.3482</a><br><a href="http://www.curtismchale.ca" target="_blank">http://www.curtismchale.ca</a><br>
Linkedin: <a href="http://www.linkedin.com/in/curtismchale" target="_blank">http://www.linkedin.com/in/curtismchale</a><br>Twitter: <a href="http://twitter.com/curtismchale" target="_blank">twitter.com/curtismchale</a><br>
<br>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div></div></div><br>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>