That's what I said. As I read the license it's okay but I just wanted to make sure as I don't get in to the license debate often and don't know for sure.<br clear="all"><br>Curtis McHale<br>PH: 604.751.3482<br>
<a href="http://www.curtismchale.ca">http://www.curtismchale.ca</a><br>Linkedin: <a href="http://www.linkedin.com/in/curtismchale">http://www.linkedin.com/in/curtismchale</a><br>Twitter: <a href="http://twitter.com/curtismchale">twitter.com/curtismchale</a><br>
<br>
<br><br><div class="gmail_quote">On Sun, Apr 17, 2011 at 5:49 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com">emil@themeid.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<p><font size="2"><font face="tahoma,sans-serif">Tillium looks OFL, see <a href="http://www.campivisivi.net/titillium/download.html" target="_blank">http://www.campivisivi.net/titillium/download.html</a></font></font></p>
<div class="im"><div> </div><div>
<strong>----</strong></div>
<div><strong>Emil Uzelac</strong> | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E: <a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a> | <a href="http://themeid.com/" target="_blank">http://themeid.com</a></div>
<div><font color="#999999">Make everything as simple as possible, but not simpler. - Albert Einstein</font></div><br>
<br><br></div><div><div></div><div class="h5"><div class="gmail_quote">On Sun, Apr 17, 2011 at 7:37 PM, Curtis McHale <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca" target="_blank">curtis@curtismchale.ca</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
I have another question as I try to catch a few other things for my notes. The theme uses cufon and a special font called Titillium. The license says it's pending in the file and when I follow it back to the source it seems to be licensed under the Open Font License. As I read it this is a compatible license with the GPL but I'm certainly not as well versed in it as others.<div>
<br></div><div>Is this license compatible and therefore acceptable on the repository?</div><div><br></div><div><a href="http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=OFL" target="_blank">http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=OFL</a><div>
<br clear="all">
<br>Curtis McHale<br>PH: 604.751.3482<br><a href="http://www.curtismchale.ca" target="_blank">http://www.curtismchale.ca</a><br>Linkedin: <a href="http://www.linkedin.com/in/curtismchale" target="_blank">http://www.linkedin.com/in/curtismchale</a><br>
Twitter: <a href="http://twitter.com/curtismchale" target="_blank">twitter.com/curtismchale</a><br>
<br>
<br><br></div><div><div></div><div><div class="gmail_quote">On Sun, Apr 17, 2011 at 5:24 PM, SFNdesign <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca" target="_blank">curtis@curtismchale.ca</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
<div bgcolor="#FFFFFF"><div>Thanks for confirming. I'll finish off my notes in a bit and update the ticket. <br><font color="#888888"><br>Curtis McHale<div>604.751.3482</div></font></div><div><div></div><div>
<div><br>On 2011-04-17, at 5:14 PM, Emil Uzelac <<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div><font size="2"><font face="tahoma,sans-serif">sorry @Cais, I sent at the same time :(<br clear="all">
</font></font><div><strong>----</strong></div><div><strong>Emil Uzelac</strong> | ThemeID | T: 224-444-0006 | Twitter: @EmilUzelac | E: <a href="mailto:emil@themeid.com" target="_blank"></a><a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a> | <a href="http://themeid.com/" target="_blank"></a><a href="http://themeid.com" target="_blank">http://themeid.com</a></div>
<div><font color="#999999">Make everything as simple as possible, but not simpler. - Albert Einstein</font></div><br>
<br><br><div class="gmail_quote">On Sun, Apr 17, 2011 at 7:12 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank"></a><a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
@Curtis -<br><br>Yes, the wrong textdomain is generally considered a "not-approved" resolution if for no other reason than it is really just a "find&replace" function ...<br><br>Also note the Author URI; it does not really portend to be one of the a Theme designer as the minimal content on the site is pointing more towards and eCommerce blog so it really is getting into the darker shades of gray related to SEO spamming.<br>
<br>The other items you noted are not too significant, but given the above you can make a point of noting them in your review comments as the first one is enough to resolve as "not-approved".<br><br><br>Cais.<div>
<div></div><div><br>
<br><div class="gmail_quote">On Sun, Apr 17, 2011 at 8:01 PM, Curtis McHale <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca" target="_blank"></a><a href="mailto:curtis@curtismchale.ca" target="_blank">curtis@curtismchale.ca</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
I have a few questions about my first theme review.<div><br></div><div>1. The theme uses the text domain of Twenty Ten in a few spots. If I remember correctly from lurking on the list this is a reason for failure of the theme.</div>
<div>2. They use a widget for the menu and instruct the user to add the Pages widget. It seems to me that it's a much better option to use a WordPress menu which defaults to list pages. I don't believe this is an issue for a fail but probably a good suggestion as an update to the user.</div>
<div>3. The CSS fails on the background-color since it's value is set to 'none' when it should be set to 'transparent'. Would this typically be a reason for failure if all other CSS is okay?</div><div>
4. There are a number of other 'recommended' items in Theme Check but these are not a reason to fail a theme correct?</div><div><br></div><div>I could probably go further in to the theme but I wanted to double check on the text domain item before I did.</div>
<div><div><br>Curtis McHale<br>PH: <a href="tel:604.751.3482" value="+16047513482" target="_blank">604.751.3482</a><br><a href="http://www.curtismchale.ca" target="_blank"></a><a href="http://www.curtismchale.ca" target="_blank">http://www.curtismchale.ca</a><br>
Linkedin: <a href="http://www.linkedin.com/in/curtismchale" target="_blank"></a><a href="http://www.linkedin.com/in/curtismchale" target="_blank">http://www.linkedin.com/in/curtismchale</a><br>
Twitter: <a href="http://twitter.com/curtismchale" target="_blank"></a><a href="http://twitter.com/curtismchale" target="_blank">twitter.com/curtismchale</a><br><br>
<br><br></div><div><div></div><div><div class="gmail_quote">On Sat, Apr 16, 2011 at 4:39 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank"></a><a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
Here ya go: <a href="http://themes.trac.wordpress.org/ticket/3320" target="_blank"></a><a href="http://themes.trac.wordpress.org/ticket/3320" target="_blank">http://themes.trac.wordpress.org/ticket/3320</a><br>This will get you started ...<br>
<br><br>Cais.<br><br><div class="gmail_quote">On Sat, Apr 16, 2011 at 7:15 PM, Curtis McHale <span dir="ltr"><<a href="mailto:curtis@curtismchale.ca" target="_blank"></a><a href="mailto:curtis@curtismchale.ca" target="_blank">curtis@curtismchale.ca</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204, 204, 204);border-left-width:1px;border-left-style:solid" class="gmail_quote">Figured I'd finally get off my butt and join the team after looking at the list for a few months. My trac name is curtismchale<div>
<br>Curtis McHale<br>PH: <a href="tel:604.751.3482" value="+16047513482" target="_blank">604.751.3482</a><br><a href="http://www.curtismchale.ca" target="_blank"></a><a href="http://www.curtismchale.ca" target="_blank">http://www.curtismchale.ca</a><br>
Linkedin: <a href="http://www.linkedin.com/in/curtismchale" target="_blank"></a><a href="http://www.linkedin.com/in/curtismchale" target="_blank">http://www.linkedin.com/in/curtismchale</a><br>Twitter: <a href="http://twitter.com/curtismchale" target="_blank"></a><a href="http://twitter.com/curtismchale" target="_blank">twitter.com/curtismchale</a><br>
<br>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank"></a><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank"></a><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>theme-reviewers mailing list</span><br><span><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a></span><br>
<span><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></span><br></div></blockquote></div></div></div></blockquote></div>
<br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>