Note that this is merely a *fallback*. The Theme properly uses wp_nav_menu() by default, which enables the user to define the menu to be used in this theme location.<div><br></div><div>I would be more concerned with what happens to this wp_nav_menu() output if a menu with many list items is used: does the layout break? If it does, then the "readme.txt" needs to be updated, to indicate the appropriate limitations for this menu location.</div>
<div><br></div><div>You can also suggest that the developer use wp_list_pages() rather than wp_list_categories() as the fallback (or, omit the fallback entirely, and let the default wp_page_menu() be used). But, since wp_nav_menu() appears to be incorporated correctly, I wouldn't make this "required".</div>
<div><br></div><div>(By the way: how do the Theme options look?)</div><div><br></div><div>Chip<br><br><div class="gmail_quote">On Fri, Apr 15, 2011 at 10:16 AM, Philip Walton <span dir="ltr"><<a href="mailto:philip@philipwalton.com">philip@philipwalton.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">On 4/15/11 7:55 AM, Otto wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Fri, Apr 15, 2011 at 9:37 AM, Philip Walton<<a href="mailto:philip@philipwalton.com" target="_blank">philip@philipwalton.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Also, if I have a lot of categories, only the first 4<br>
show up in the primary navigation menu.<br>
</blockquote>
There's a difference between "broken site" and "design choice". If the<br>
theme is designed to intentionally only allow 4 entries there, then<br>
that's okay. If it displays something visibly broken when you exceed 4<br>
entries (like cut off text, etc), then that's not okay.<br>
</blockquote></div>
The theme developer has a callback to this function, which explicitly limits the number of categories to 4.<br>
<br>
function display_pages() {<br>
echo '<ul>';<br>
wp_list_categories('title_li=&depth=1&number=4');<br>
echo '</ul>';<br>
}<br>
<br>
Ignoring the poor choice of function title, nothing is technically wrong with this function, and no errors are caused when the site contains more than four categories. However, intentionally limiting a menu to four categories with no option to display all seems like a poor decision to me. Furthermore, since the categories are ordered alphabetically, the probability that these four categories are going to be the ones the user wants seems quite low.<br>
<br>
In my opinion, if a theme is limiting the number of items that appear in a menu, then it should show some sort of "more" link or at least give the user a setting where (s)he can choose exactly which items appear in that menu.<div>
<div></div><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Whether a "little" problem is cause for failing the theme or not is<br>
more of a subjective call. For example, if an absurdly long post title<br>
causes a weird result, then that should be noted, but if it's the<br>
*only* problem then it may just be something to tell the theme<br>
developer to fix in the next version. On the other hand, if there are<br>
several different "little" problems like this, then you may decide<br>
that yes, this is too many, so they need to be fixed in order to be<br>
approved. At what point those "little" problems accumulate into a<br>
"fail" is up to you.<br>
<br>
-Otto<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div>