<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Tahoma
}
--></style>
</head>
<body class='hmmessage'>
forgot;<BR>
Firefox/3.6.16<BR>
screenshot:<BR>
<A href="http://img12.imageshack.us/f/depomasthead.png/">http://img12.imageshack.us/f/depomasthead.png/</A><BR>
<BR>
<BR> <BR>
> Date: Tue, 29 Mar 2011 17:34:32 +0300<BR>> From: contact@onedesigns.com<BR>> To: theme-reviewers@lists.wordpress.org<BR>> Subject: Re: [theme-reviewers] Please assign me a theme to review<BR>> <BR>> Hi Carolina,<BR>> <BR>> Yes, you just reviewed an Automattic theme. How cool is that? *grin*<BR>> <BR>> Here's the official blog post to it:<BR>> http://en.blog.wordpress.com/2008/09/12/depo-masthead-theme-launch/<BR>> <BR>> Here's some feedback and suggestions;<BR>> Apparently the theme intends to create a custom pagination, to show <BR>> only the first 3 posts on the front page and a custom archive-based <BR>> navigation. This could be a potential issue since it may require <BR>> additional tweaking, Apparently this theme would run smoother if the <BR>> front page would be set to a static page. Otherwise, I would think the <BR>> use of the template front-page.php in this case would have been a <BR>> better choice instead of home.php. With the proper documentation such <BR>> a structure may be fine, but still subjective and the final decision <BR>> may be set to debate. I personally would not accept this because it <BR>> appears there is no main post navigation if the front page is set to <BR>> latest posts.<BR>> <BR>> The WP admin bar does not break for me. What version of Firefox do you <BR>> use, could you include a screenshot?<BR>> <BR>> In the future please also copy the errors/notices you receive from <BR>> WP_DEBUG and also the Theme Check requirements and recommendations.<BR>> <BR>> This theme also has a theme options page. In the future please also do <BR>> a security review for such themes, checking if attributes are <BR>> correctly escaped, there are no XSS vulnerabilities, nonce fields are <BR>> added. If you are not familiar with the Settings/options API then <BR>> leave a request for someone else to do it.<BR>> <BR>> This theme passes security tests, the only recommendation would be to <BR>> use the Settings API instead of the Options API.<BR>> <BR>> Here are some other things you didn't catch:<BR>> The theme uses inconsistent function prefixes: sometimes functions <BR>> start with depo_ sometimes with depomasthead_<BR>> Also, functions like previous_archive_link and next_archive_link are <BR>> not prefixed at all and have very common names.<BR>> <BR>> If other reviewers have other thoughts please share them, I only had a <BR>> quick look over the theme.<BR>> <BR>> Daniel<BR>> <BR>> <BR>> <BR>> --- On Tue, 3/29/11, carolina n <myazalea@hotmail.com> wrote:<BR>> <BR>> From: carolina n <myazalea@hotmail.com><BR>> Subject: Re: [theme-reviewers] Please assign me a theme to review<BR>> To: theme-reviewers@lists.wordpress.org<BR>> Date: Tuesday, March 29, 2011, 5:06 PM<BR>> <BR>> <BR>> <BR>> <BR>> <BR>> <BR>> Done<BR>> <BR>> -wasn't sure if this was some kind of trick or error, or did i just <BR>> fail an automattic theme ;)<BR>> <BR>> <BR>> <BR>> <BR>> <BR>> <BR>> <BR>> <BR>> > Date: Tue, 29 Mar 2011 15:37:48 +0300<BR>> > From: contact@onedesigns.com<BR>> > To: theme-reviewers@lists.wordpress.org<BR>> > Subject: Re: [theme-reviewers] Please assign me a theme to review<BR>> ><BR>> > I'm sorry, wrong pick. I picked the most recent one instead of the oldest.<BR>> ><BR>> > Please review this one:<BR>> ><BR>> > https://themes.trac.wordpress.org/ticket/3085<BR>> ><BR>> > My apologies.<BR>> ><BR>> > Daniel<BR>> ><BR>> > --- On Tue, 3/29/11, Daniel Tara <contact@onedesigns.com> wrote:<BR>> ><BR>> > [Hide Quoted Text]<BR>> > From: Daniel Tara <contact@onedesigns.com><BR>> > Subject: Re: [theme-reviewers] Please assign me a theme to review<BR>> > To: theme-reviewers@lists.wordpress.org<BR>> > Date: Tuesday, March 29, 2011, 2:49 PM<BR>> > Here you go:<BR>> ><BR>> > https://themes.trac.wordpress.org/ticket/3384<BR>> ><BR>> > Daniel<BR>> ><BR>> > --- On Tue, 3/29/11, carolina n <myazalea@hotmail.com><BR>> > wrote:<BR>> ><BR>> > From: carolina n <myazalea@hotmail.com><BR>> > Subject: [theme-reviewers] Please assign me a theme to<BR>> > review<BR>> > To: theme-reviewers@lists.wordpress.org<BR>> > Date: Tuesday, March 29, 2011, 12:39 PM<BR>> ><BR>> > Please assign me a theme or two to review,<BR>> ><BR>> > my username is poena.<BR>> ><BR>> ><BR>> > -----Inline Attachment Follows-----<BR>> ><BR>> > _______________________________________________<BR>> > theme-reviewers mailing list<BR>> > theme-reviewers@lists.wordpress.org<BR>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR>> ><BR>> ><BR>> > _______________________________________________<BR>> > theme-reviewers mailing list<BR>> > theme-reviewers@lists.wordpress.org<BR>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR>> ><BR>> > _______________________________________________<BR>> > theme-reviewers mailing list<BR>> > theme-reviewers@lists.wordpress.org<BR>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR>> <BR>> <BR>> -----Inline Attachment Follows-----<BR>> <BR>> _______________________________________________<BR>> theme-reviewers mailing list<BR>> theme-reviewers@lists.wordpress.org<BR>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR>> <BR>> <BR>> _______________________________________________<BR>> theme-reviewers mailing list<BR>> theme-reviewers@lists.wordpress.org<BR>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR> </body>
</html>