<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Tahoma
}
--></style>
</head>
<body class='hmmessage'>Is there a complete checklist for theme reviewers, i liked how Michael (mfields) did his.<br><br>> Date: Tue, 29 Mar 2011 17:34:32 +0300<br>> From: contact@onedesigns.com<br>> To: theme-reviewers@lists.wordpress.org<br>> Subject: Re: [theme-reviewers] Please assign me a theme to review<br>> <br>> Hi Carolina,<br>> <br>> Yes, you just reviewed an Automattic theme. How cool is that? *grin*<br>> <br>> Here's the official blog post to it:<br>> http://en.blog.wordpress.com/2008/09/12/depo-masthead-theme-launch/<br>> <br>> Here's some feedback and suggestions;<br>> Apparently the theme intends to create a custom pagination, to show <br>> only the first 3 posts on the front page and a custom archive-based <br>> navigation. This could be a potential issue since it may require <br>> additional tweaking, Apparently this theme would run smoother if the <br>> front page would be set to a static page. Otherwise, I would think the <br>> use of the template front-page.php in this case would have been a <br>> better choice instead of home.php. With the proper documentation such <br>> a structure may be fine, but still subjective and the final decision <br>> may be set to debate. I personally would not accept this because it <br>> appears there is no main post navigation if the front page is set to <br>> latest posts.<br>> <br>> The WP admin bar does not break for me. What version of Firefox do you <br>> use, could you include a screenshot?<br>> <br>> In the future please also copy the errors/notices you receive from <br>> WP_DEBUG and also the Theme Check requirements and recommendations.<br>> <br>> This theme also has a theme options page. In the future please also do <br>> a security review for such themes, checking if attributes are <br>> correctly escaped, there are no XSS vulnerabilities, nonce fields are <br>> added. If you are not familiar with the Settings/options API then <br>> leave a request for someone else to do it.<br>> <br>> This theme passes security tests, the only recommendation would be to <br>> use the Settings API instead of the Options API.<br>> <br>> Here are some other things you didn't catch:<br>> The theme uses inconsistent function prefixes: sometimes functions <br>> start with depo_ sometimes with depomasthead_<br>> Also, functions like previous_archive_link and next_archive_link are <br>> not prefixed at all and have very common names.<br>> <br>> If other reviewers have other thoughts please share them, I only had a <br>> quick look over the theme.<br>> <br>> Daniel<br>> <br>> <br>> <br>> --- On Tue, 3/29/11, carolina n <myazalea@hotmail.com> wrote:<br>> <br>> From: carolina n <myazalea@hotmail.com><br>> Subject: Re: [theme-reviewers] Please assign me a theme to review<br>> To: theme-reviewers@lists.wordpress.org<br>> Date: Tuesday, March 29, 2011, 5:06 PM<br>> <br>> <br>> <br>> <br>> <br>> <br>> Done<br>> <br>> -wasn't sure if this was some kind of trick or error, or did i just <br>> fail an automattic theme ;)<br>> <br>> <br>> <br>> <br>> <br>> <br>> <br>> <br>> > Date: Tue, 29 Mar 2011 15:37:48 +0300<br>> > From: contact@onedesigns.com<br>> > To: theme-reviewers@lists.wordpress.org<br>> > Subject: Re: [theme-reviewers] Please assign me a theme to review<br>> ><br>> > I'm sorry, wrong pick. I picked the most recent one instead of the oldest.<br>> ><br>> > Please review this one:<br>> ><br>> > https://themes.trac.wordpress.org/ticket/3085<br>> ><br>> > My apologies.<br>> ><br>> > Daniel<br>> ><br>> > --- On Tue, 3/29/11, Daniel Tara <contact@onedesigns.com> wrote:<br>> ><br>> > [Hide Quoted Text]<br>> > From: Daniel Tara <contact@onedesigns.com><br>> > Subject: Re: [theme-reviewers] Please assign me a theme to review<br>> > To: theme-reviewers@lists.wordpress.org<br>> > Date: Tuesday, March 29, 2011, 2:49 PM<br>> > Here you go:<br>> ><br>> > https://themes.trac.wordpress.org/ticket/3384<br>> ><br>> > Daniel<br>> ><br>> > --- On Tue, 3/29/11, carolina n <myazalea@hotmail.com><br>> > wrote:<br>> ><br>> > From: carolina n <myazalea@hotmail.com><br>> > Subject: [theme-reviewers] Please assign me a theme to<br>> > review<br>> > To: theme-reviewers@lists.wordpress.org<br>> > Date: Tuesday, March 29, 2011, 12:39 PM<br>> ><br>> > Please assign me a theme or two to review,<br>> ><br>> > my username is poena.<br>> ><br>> ><br>> > -----Inline Attachment Follows-----<br>> ><br>> > _______________________________________________<br>> > theme-reviewers mailing list<br>> > theme-reviewers@lists.wordpress.org<br>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers<br>> ><br>> ><br>> > _______________________________________________<br>> > theme-reviewers mailing list<br>> > theme-reviewers@lists.wordpress.org<br>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers<br>> ><br>> > _______________________________________________<br>> > theme-reviewers mailing list<br>> > theme-reviewers@lists.wordpress.org<br>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers<br>> <br>> <br>> -----Inline Attachment Follows-----<br>> <br>> _______________________________________________<br>> theme-reviewers mailing list<br>> theme-reviewers@lists.wordpress.org<br>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers<br>> <br>> <br>> _______________________________________________<br>> theme-reviewers mailing list<br>> theme-reviewers@lists.wordpress.org<br>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers<br> </body>
</html>