Flip the switch, and the sooner the better!<div><br></div><div>Chip<br><br><div class="gmail_quote">On Mon, Mar 21, 2011 at 1:25 PM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">I recently resynched the theme check on the uploader to the latest<br>
version of the theme check plugin, to add the 3.1 checks to the<br>
uploader too.<br>
<br>
At one time, we discussed making the theme check there require a<br>
mandatory pass for allowing the theme to be uploaded at all. The<br>
timeline suggested for this was one month after the release of 3.1. We<br>
are now at that point in time, and so unless there is a good reason<br>
not to do so, I plan on making that change this week.<br>
<br>
What this means:<br>
<br>
Right now, the uploader does print out the results of the theme check,<br>
along with the computed "pass" or "fail". There are currently only a<br>
few conditions that will cause the uploader to abort and not submit<br>
the theme. The more wide-ranging theme check has been purely advisory<br>
until now, it does not affect the ability to upload the theme.<br>
<br>
This change would make any "fail" condition from the theme uploader<br>
abort in the same manner, and stop the theme from being uploaded.<br>
Getting a "pass" on the theme check would be a requirement.<br>
<br>
The result of this would be to reduce the number of submissions in<br>
trac, and reduce the need of the reviewers to run theme check<br>
themselves, as a pass would be assured for it to even make it that<br>
far.<br>
<br>
Note that not all messages produced by theme check produce a fail. The<br>
"recommended" and "info" items, for example, are merely informational,<br>
they don't affect the pass/fail case. Only the warnings and requireds<br>
and such cause a theme to fail the check.<br>
<br>
If anybody has any objections or suggestions or even just thoughts,<br>
now's the time to talk about them.<br>
<font color="#888888"><br>
-Otto<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</font></blockquote></div><br></div>