<div>@Amy Hendrix,</div><div>Ok, this is my understanding...</div><div>-The Theme Check plugin automates the checks the items on this page: <a href="http://codex.wordpress.org/Theme_Review">http://codex.wordpress.org/Theme_Review</a></div>
<div>-The Unit Test requires eyeballs</div><div>-Options security??? Will I learn this with time?</div><div>-Test add-on functionality</div><div>-Thanks for your input!</div><div><br></div><div>@Frumph,</div><div>-Cursory glance - need to add to my vocabulary list</div>
<div>-"<span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; ">So basically if it passes theme-check just fail it with the report from theme check and move on" - If it passes, fail it??</span></div>
<div><span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; ">-Great link - </span><span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; "><a href="http://make.wordpress.org/themes/about/resources/" target="_blank" style="color: rgb(17, 65, 112); ">http://make.wordpress.org/themes/about/resources/</a></span></div>
<div>-Thanks Frumph!</div><br clear="all">Josh<br>
<br><br><div class="gmail_quote">On Tue, Jan 11, 2011 at 10:42 AM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net">philip@frumph.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
don't look at me, I do cursory glances like everyone else, I only take my time when theme-check and everything else reports pass, then I get thorough.<br>
<br>
So basically if it passes theme-check just fail it with the report from theme check and move on, write something at the bottom that this is a cursory glance and next reviewer might find more, see <a href="http://make.wordpress.org/themes/about/resources/" target="_blank">http://make.wordpress.org/themes/about/resources/</a> for a list of resources available for testing your theme.<br>
<br>
Something like that<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
----- Original Message ----- From: "Amy Hendrix" <<a href="mailto:sabreuse@gmail.com" target="_blank">sabreuse@gmail.com</a>><br>
To: <<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>><br>
Sent: Tuesday, January 11, 2011 8:36 AM<br>
Subject: Re: [theme-reviewers] Theme Review Process<div><div></div><div class="h5"><br>
<br>
<br>
Hi Josh,<br>
<br>
Theme Check inspects the code for required classes, deprecated<br>
functions and so on. The Unit Test needs human eyes for whether things<br>
display as they should - so they both need to be done, and keep in<br>
mind that there are other things in the review process (like options<br>
security, or testing that any add-on functionality actually works)<br>
that can't possibly be covered by either of those.<br>
<br>
On the other hand, if a ton of required stuff fails on the first pass,<br>
you don't need to go through everything. In that case, DO indicate in<br>
your review that yours is a preliminary review and other reviewers<br>
will be checking for other things in future versions. Some devs take a<br>
review as a checklist, and think that once everything that was<br>
explicitly mentioned is fixed they're automatically done.<br>
<br>
(And don't worry about not being a speed demon like Frumph. My first<br>
couple of reviews took forever, and they get a whole lot faster as you<br>
build your own routine.)<br>
<br>
Good luck,<br>
Amy<br>
<br>
On Tue, Jan 11, 2011 at 10:49 AM, Josh Stauffer <<a href="mailto:joshstauffer@gmail.com" target="_blank">joshstauffer@gmail.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello WPTRT,<br>
I have all three plugins installed (Theme Check, Debogger, and Log Deps) and<br>
have been checking themes against the Theme Unit Test and Theme Review. I've<br>
spent about 5 hours total on my first two reviews. Does it usually require<br>
this much time? I must be doing something wrong. ;-(<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Takes about 5-15mins if i'm being lazy and theme-check plugin reports a<br>
ton of stuff to 1/2 hour for a full check on one including security, when I<br>
first started it was about 45 minutes<br>
<br>
-Frumph<br>
</blockquote>
<br>
Is it necessary for me to check the theme against each item on the Theme<br>
Review or is that what the Theme Check plugin is checking?<br>
Also, how much effort do you put into a review before you send it back to<br>
the author. For example, let's say I start reviewing the theme and I find 5<br>
required items that need to be fixed. Should I stop my review and post my<br>
comments about the 5 items and reiterate to the theme author that he should<br>
check the theme guidelines before submitting again?<br>
I am learning and I am enjoying my time spent thus far. Just looking for<br>
input on how to become more efficient. ;-)<br>
Josh Stauffer<br>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
<br>
</blockquote>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br>