<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=iso-8859-1" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18928">
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT size=2 face=Arial>the <A
href="http://make.wordpress.org/themes">http://make.wordpress.org/themes</A>
is our WPTRT website</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="FONT: 10pt arial; BACKGROUND: #e4e4e4; font-color: black"><B>From:</B>
<A title=joshstauffer@gmail.com href="mailto:joshstauffer@gmail.com">Josh
Stauffer</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A
title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
</DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Tuesday, January 11, 2011 8:58
AM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [theme-reviewers] Theme
Review Process</DIV>
<DIV><BR></DIV>
<DIV>@Amy Hendrix,</DIV>
<DIV>Ok, this is my understanding...</DIV>
<DIV>-The Theme Check plugin automates the checks the items on this
page: <A
href="http://codex.wordpress.org/Theme_Review">http://codex.wordpress.org/Theme_Review</A></DIV>
<DIV>-The Unit Test requires eyeballs</DIV>
<DIV>-Options security??? Will I learn this with time?</DIV>
<DIV>-Test add-on functionality</DIV>
<DIV>-Thanks for your input!</DIV>
<DIV><BR></DIV>
<DIV>@Frumph,</DIV>
<DIV>-Cursory glance - need to add to my vocabulary list</DIV>
<DIV>-"<SPAN
style="BORDER-COLLAPSE: collapse; FONT-FAMILY: arial, sans-serif; FONT-SIZE: 13px"
class=Apple-style-span>So basically if it passes theme-check just fail it with
the report from theme check and move on" - If it passes, fail
it??</SPAN></DIV>
<DIV><SPAN
style="BORDER-COLLAPSE: collapse; FONT-FAMILY: arial, sans-serif; FONT-SIZE: 13px"
class=Apple-style-span>-Great link - </SPAN><SPAN
style="BORDER-COLLAPSE: collapse; FONT-FAMILY: arial, sans-serif; FONT-SIZE: 13px"
class=Apple-style-span><A style="COLOR: rgb(17,65,112)"
href="http://make.wordpress.org/themes/about/resources/"
target=_blank>http://make.wordpress.org/themes/about/resources/</A></SPAN></DIV>
<DIV>-Thanks Frumph!</DIV><BR clear=all>Josh<BR><BR><BR>
<DIV class=gmail_quote>On Tue, Jan 11, 2011 at 10:42 AM, Philip M. Hofer
(Frumph) <SPAN dir=ltr><<A
href="mailto:philip@frumph.net">philip@frumph.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>don't look at me, I do cursory glances like everyone else,
I only take my time when theme-check and everything else reports pass, then
I get thorough.<BR><BR>So basically if it passes theme-check just fail it
with the report from theme check and move on, write something at the bottom
that this is a cursory glance and next reviewer might find more, see <A
href="http://make.wordpress.org/themes/about/resources/"
target=_blank>http://make.wordpress.org/themes/about/resources/</A> for a
list of resources available for testing your theme.<BR><BR>Something like
that<BR><BR><BR><BR><BR><BR><BR><BR>----- Original Message ----- From: "Amy
Hendrix" <<A href="mailto:sabreuse@gmail.com"
target=_blank>sabreuse@gmail.com</A>><BR>To: <<A
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A>><BR>Sent: Tuesday,
January 11, 2011 8:36 AM<BR>Subject: Re: [theme-reviewers] Theme Review
Process
<DIV>
<DIV></DIV>
<DIV class=h5><BR><BR><BR>Hi Josh,<BR><BR>Theme Check inspects the code for
required classes, deprecated<BR>functions and so on. The Unit Test needs
human eyes for whether things<BR>display as they should - so they both need
to be done, and keep in<BR>mind that there are other things in the review
process (like options<BR>security, or testing that any add-on functionality
actually works)<BR>that can't possibly be covered by either of
those.<BR><BR>On the other hand, if a ton of required stuff fails on the
first pass,<BR>you don't need to go through everything. In that case, DO
indicate in<BR>your review that yours is a preliminary review and other
reviewers<BR>will be checking for other things in future versions. Some devs
take a<BR>review as a checklist, and think that once everything that
was<BR>explicitly mentioned is fixed they're automatically done.<BR><BR>(And
don't worry about not being a speed demon like Frumph. My first<BR>couple of
reviews took forever, and they get a whole lot faster as you<BR>build your
own routine.)<BR><BR>Good luck,<BR>Amy<BR><BR>On Tue, Jan 11, 2011 at 10:49
AM, Josh Stauffer <<A href="mailto:joshstauffer@gmail.com"
target=_blank>joshstauffer@gmail.com</A>> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>Hello WPTRT,<BR>I have all three plugins installed
(Theme Check, Debogger, and Log Deps) and<BR>have been checking themes
against the Theme Unit Test and Theme Review. I've<BR>spent about 5 hours
total on my first two reviews. Does it usually require<BR>this much time?
I must be doing something wrong. ;-(<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote><BR>Takes about 5-15mins if i'm being lazy and
theme-check plugin reports a<BR>ton of stuff to 1/2 hour for a full
check on one including security, when I<BR>first started it was about 45
minutes<BR><BR>-Frumph<BR></BLOCKQUOTE><BR>Is it necessary for me to check
the theme against each item on the Theme<BR>Review or is that what the
Theme Check plugin is checking?<BR>Also, how much effort do you put into a
review before you send it back to<BR>the author. For example, let's say I
start reviewing the theme and I find 5<BR>required items that need to be
fixed. Should I stop my review and post my<BR>comments about the 5 items
and reiterate to the theme author that he should<BR>check the theme
guidelines before submitting again?<BR>I am learning and I am enjoying my
time spent thus far. Just looking for<BR>input on how to become more
efficient. ;-)<BR>Josh
Stauffer<BR><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR><BR></BLOCKQUOTE>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR></DIV></DIV></BLOCKQUOTE></DIV><BR>
<P>
<HR>
<P></P>_______________________________________________<BR>theme-reviewers
mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></BLOCKQUOTE></BODY></HTML>