<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=iso-8859-1" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18928">
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT size=2 face=Arial>Ah, you have to be logged on. the login
button is on the upper right top of that page, use your wordpress.org login,
once you are logged on you can reply</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>- Phil</FONT></DIV>
<DIV> </DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="FONT: 10pt arial; BACKGROUND: #e4e4e4; font-color: black"><B>From:</B>
<A title=fordmon@gmail.com href="mailto:fordmon@gmail.com">Ford Mon</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A
title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
</DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Monday, January 10, 2011 11:20
AM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [theme-reviewers] [WordPress
Themes] #2478: THEME: Black Queen-1.3</DIV>
<DIV><BR></DIV>I do not know how to reply in the ticket. There is not option
to reply there.
<DIV><A
href="http://themes.trac.wordpress.org/ticket/2478#comment:3">http://themes.trac.wordpress.org/ticket/2478#comment:3</A><BR><BR>
<DIV class=gmail_quote>On Mon, Jan 10, 2011 at 2:15 PM, Philip M. Hofer
(Frumph) <SPAN dir=ltr><<A
href="mailto:philip@frumph.net">philip@frumph.net</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV bgcolor="#ffffff">
<DIV><FONT size=2 face=Arial>Read my comment again, I wrote that using
@import is alright.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>This line:</FONT></DIV>
<DIV><FONT color=#008000 size=2><FONT color=#008000 size=2>
<P><link rel="stylesheet" type="text/css" href="</P></FONT></FONT><FONT
color=#0000ff size=2><FONT color=#0000ff size=2><?php</FONT></FONT><FONT
size=2> </FONT><FONT color=#0000ff size=2><FONT color=#0000ff
size=2>print</FONT></FONT><FONT size=2> get_stylesheet_directory_uri();
</FONT><FONT color=#0000ff size=2><FONT color=#0000ff
size=2>?></FONT></FONT><FONT color=#008000 size=2><FONT color=#008000
size=2>/css/ie.css" media="screen" /></FONT></FONT>
<P><FONT color=#008000 size=2><FONT color=#008000 size=2><FONT color=#000000
face=Arial>If an end user is using a child theme, it will try to find the
/css/ie.css in the child theme, instead of the main one in the parent theme,
whether you have a child theme or not, if an end user has one that is what
will happen.</FONT></FONT></FONT></P>
<P><FONT color=#008000 size=2><FONT color=#008000 size=2><FONT color=#000000
face=Arial>Change that to get_template_directory_uri() and check all of the
other references of get_stylesheet_directory you have to make sure they are
as they should be or need to switch to get_template_directory as
well.</FONT></FONT></FONT></P>
<P><FONT color=#008000 size=2><FONT color=#008000 size=2><FONT color=#000000
face=Arial>Looking over your previous tickets: <A
href="http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-black-queen&order=priority"
target=_blank>http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-black-queen&order=priority</A></FONT></FONT></FONT></P>
<P><FONT color=#008000 size=2><FONT color=#008000 size=2><FONT color=#000000
face=Arial>I am not seeing anyone say that there was no need, not a single
ticket there says it.</FONT></FONT></FONT></P></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV class=im>
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV style="FONT: 10pt arial; BACKGROUND: #e4e4e4"><B>From:</B> <A
title=fordmon@gmail.com href="mailto:fordmon@gmail.com" target=_blank>Ford
Mon</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A
title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A> </DIV></DIV>
<DIV>
<DIV></DIV>
<DIV class=h5>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Monday, January 10, 2011 11:04
AM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [theme-reviewers]
[WordPress Themes] #2478: THEME: Black Queen- 1.3</DIV>
<DIV><BR></DIV><SPAN
style="BORDER-COLLAPSE: collapse; FONT-FAMILY: arial, sans-serif"> <B><FONT
size=4>To Frumph</FONT></B></SPAN><BR><BR>
<DIV>You wrote the requirement: - Stylesheets using @import are
alright, the wp_enqueue_style requirement</DIV> is if it's hardcoded
instead of enqueued, while inside of an -IF LTE IE<BR> statement and
such is alright to hardcode as long as the proper<BR> directory_uri
is used.
<DIV><FONT color=#ff0000><B>Why to use wp_enqueue_style() if we have
1CSS ? Please elaborate</B></FONT></DIV>
<DIV><FONT color=#ff0000><BR></FONT></DIV>
<DIV><FONT color=#ff0000><SPAN style="COLOR: rgb(0,0,0)">Unfortunately
get_stylesheet_directory_uri(); is not it,
it's<BR> get_template_directory_uri() which needs to be fixed before
being<BR> accepted. If using get_stylesheet_directory_uri() and
a user is using a<BR> child-theme it will check the css/ of that
child theme and not where it's<BR> located in the main
template.</SPAN> <B>Please explain what should I fix. I do not have a
child theme.</B> </FONT></DIV>
<DIV><FONT color=#ff0000><BR></FONT></DIV>
<DIV><FONT color=#ff0000><BR></FONT></DIV>
<DIV><FONT color=#ff0000><FONT
color=#000000>get_stylesheet_directory(_uri)</FONT><FONT color=#000000>()
will check the childtheme first, if no</FONT><BR><FONT
color=#000000> childtheme it will use the main parent
theme.</FONT><BR><FONT color=#000000> get_template_directory(_uri)()
will always check the parent theme </FONT><B> The previous reviewer
stated that there is no need in get_stylesheet_directory(_uri) so I
took it out. Guys, could you come to the consensus<FONT
size=+0> w</FONT>hat's wrong in my theme? </B></FONT></DIV>
<DIV><FONT color=#ff0000><BR></FONT>
<DIV><BR>
<DIV class=gmail_quote>On Sun, Jan 9, 2011 at 6:25 PM, WordPress Themes
<SPAN dir=ltr><<A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A>></SPAN>
wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV>#2478: THEME: Black Queen -
1.3<BR>------------------------------+-------------------------------<BR> Reporter:
themesfromrobin | Owner:
joshstauffer<BR></DIV> Type: theme
| Status:
closed<BR>Resolution: not-approved |
Keywords:
theme-black-queen,<BR>------------------------------+-------------------------------<BR>Changes
(by Frumph):<BR><BR> * status: assigned =>
closed<BR> * resolution: =>
not-approved<BR><BR><BR>Comment:<BR><BR> - Stylesheets using
@import are alright, the wp_enqueue_style requirement<BR> is if
it's hardcoded instead of enqueued, while inside of an -IF LTE
IE<BR> statement and such is alright to hardcode as long as the
proper<BR> directory_uri is used.<BR><BR> Unfortunately
get_stylesheet_directory_uri(); is not it,
it's<BR> get_template_directory_uri() which needs to be fixed
before being<BR> accepted. If using
get_stylesheet_directory_uri() and a user is using
a<BR> child-theme it will check the css/ of that child theme and
not where it's<BR> located in the main
template.<BR><BR> get_stylesheet_directory(_uri)() will check the
childtheme first, if no<BR> childtheme it will use the main parent
theme.<BR> get_template_directory(_uri)() will always check the
parent theme<BR><BR> Required's<BR> => adjust all of the
get_stylesheet/template(_uri)() references to match<BR> appropriate
locations to where the files are<BR> => fix the missing px
in the #content .archive-meta<BR><BR> ^ Recommendations above
stand.<BR><FONT color=#888888><BR>--<BR>Ticket URL: <<A
href="http://themes.trac.wordpress.org/ticket/2478#comment:3"
target=_blank>http://themes.trac.wordpress.org/ticket/2478#comment:3</A>><BR></FONT>
<DIV>
<DIV></DIV>
<DIV>WordPress Themes <<A href="http://themes.trac.wordpress.org/"
target=_blank>http://themes.trac.wordpress.org/</A>><BR>WordPress.org
Theme Directory
Reviews<BR></DIV></DIV></BLOCKQUOTE></DIV><BR></DIV></DIV></DIV></DIV>
<P></P>
<HR>
<P></P>_______________________________________________<BR>theme-reviewers
mailing list
<DIV class=im><BR><A href="mailto:theme-reviewers@lists.wordpress.org"
target=_blank>theme-reviewers@lists.wordpress.org</A><BR></DIV>
<DIV class=im><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR></DIV>
<P></P></BLOCKQUOTE></DIV><BR>_______________________________________________<BR>theme-reviewers
mailing list<BR><A
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A><BR><A
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target=_blank>http://lists.wordpress.org/mailman/listinfo/theme-reviewers</A><BR><BR></BLOCKQUOTE></DIV><BR></DIV>
<P>
<HR>
<P></P>_______________________________________________<BR>theme-reviewers
mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></BLOCKQUOTE></BODY></HTML>