<span class="Apple-style-span" style="font-family: arial, sans-serif; border-collapse: collapse; "> <b><font class="Apple-style-span" size="4">To Frumph</font></b></span><br><br><div>You wrote the requirement: - Stylesheets using @import are alright, the wp_enqueue_style requirement</div>
is if it's hardcoded instead of enqueued, while inside of an -IF LTE IE<br> statement and such is alright to hardcode as long as the proper<br> directory_uri is used.<div><font class="Apple-style-span" color="#FF0000"><b>Why to use wp_enqueue_style() if we have 1CSS ? Please elaborate</b></font></div>
<div><font class="Apple-style-span" color="#FF0000"><br></font></div><div><font class="Apple-style-span" color="#FF0000"><span class="Apple-style-span" style="color: rgb(0, 0, 0); ">Unfortunately get_stylesheet_directory_uri(); is not it, it's<br>
get_template_directory_uri() which needs to be fixed before being<br> accepted. If using get_stylesheet_directory_uri() and a user is using a<br> child-theme it will check the css/ of that child theme and not where it's<br>
located in the main template.</span> <b>Please explain what should I fix. I do not have a child theme.</b> </font></div><div><font class="Apple-style-span" color="#FF0000"><br></font></div><div><font class="Apple-style-span" color="#FF0000"><br>
</font></div><div><font class="Apple-style-span" color="#FF0000"><font class="Apple-style-span" color="#000000">get_stylesheet_directory(_uri)</font><font class="Apple-style-span" color="#000000">() will check the childtheme first, if no</font><br>
<font class="Apple-style-span" color="#000000"> childtheme it will use the main parent theme.</font><br><font class="Apple-style-span" color="#000000"> get_template_directory(_uri)() will always check the parent theme </font><b> The previous reviewer stated that there is no need in get_stylesheet_directory(_uri) so I took it out. Guys, could you come to the consensus<font class="Apple-style-span"> w</font>hat's wrong in my theme? </b></font></div>
<div><font class="Apple-style-span" color="#FF0000"><br></font><div><br><div class="gmail_quote">On Sun, Jan 9, 2011 at 6:25 PM, WordPress Themes <span dir="ltr"><<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">#2478: THEME: Black Queen - 1.3<br>
------------------------------+-------------------------------<br>
Reporter: themesfromrobin | Owner: joshstauffer<br>
</div> Type: theme | Status: closed<br>
Resolution: not-approved | Keywords: theme-black-queen,<br>
------------------------------+-------------------------------<br>
Changes (by Frumph):<br>
<br>
* status: assigned => closed<br>
* resolution: => not-approved<br>
<br>
<br>
Comment:<br>
<br>
- Stylesheets using @import are alright, the wp_enqueue_style requirement<br>
is if it's hardcoded instead of enqueued, while inside of an -IF LTE IE<br>
statement and such is alright to hardcode as long as the proper<br>
directory_uri is used.<br>
<br>
Unfortunately get_stylesheet_directory_uri(); is not it, it's<br>
get_template_directory_uri() which needs to be fixed before being<br>
accepted. If using get_stylesheet_directory_uri() and a user is using a<br>
child-theme it will check the css/ of that child theme and not where it's<br>
located in the main template.<br>
<br>
get_stylesheet_directory(_uri)() will check the childtheme first, if no<br>
childtheme it will use the main parent theme.<br>
get_template_directory(_uri)() will always check the parent theme<br>
<br>
Required's<br>
=> adjust all of the get_stylesheet/template(_uri)() references to match<br>
appropriate locations to where the files are<br>
=> fix the missing px in the #content .archive-meta<br>
<br>
^ Recommendations above stand.<br>
<font color="#888888"><br>
--<br>
Ticket URL: <<a href="http://themes.trac.wordpress.org/ticket/2478#comment:3" target="_blank">http://themes.trac.wordpress.org/ticket/2478#comment:3</a>><br>
</font><div><div></div><div class="h5">WordPress Themes <<a href="http://themes.trac.wordpress.org/" target="_blank">http://themes.trac.wordpress.org/</a>><br>
WordPress.org Theme Directory Reviews<br>
</div></div></blockquote></div><br></div></div>