In most cases, if a function has 'before' and 'after' paramters that can be set; and, the 'before' parameter opens a "container" the 'after' parameter should close it explicitly be it the default or not.<br>
<br>Chip, in the case of your theme, I would explicitly close using the 'after' parameter but comment explaining it is not strictly necessary (following in the concept of my understanding of your theme's underlying premises). If someone chooses to modify your theme and change that particular bit of code to some other container such as 'div' or 'span' the explicit 'after' statement would be a good indicator they need to specify the closing tag there.<br>
<br>Just a thought ...<br><br><br>Cais.<br><br><div class="gmail_quote">On Mon, Jan 10, 2011 at 10:26 AM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net">philip@frumph.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div bgcolor="#ffffff">
<div><font face="Arial" size="2">just need a clear:both on #page-link is all on
twentyten etc.</font></div>
<div><font face="Arial" size="2"></font> </div>
<div> </div>
<blockquote style="border-left: 2px solid rgb(0, 0, 0); padding-left: 5px; padding-right: 0px; margin-left: 5px; margin-right: 0px;"><div class="im">
<div style="font: 10pt arial;">----- Original Message ----- </div>
<div style="font: 10pt arial; background: none repeat scroll 0% 0% rgb(228, 228, 228);"><b>From:</b>
<a title="edward.caissie@gmail.com" href="mailto:edward.caissie@gmail.com" target="_blank">Edward Caissie</a> </div>
</div><div class="im"><div style="font: 10pt arial;"><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
</div>
</div><div><div></div><div class="h5"><div style="font: 10pt arial;"><b>Sent:</b> Monday, January 10, 2011 6:37
AM</div>
<div style="font: 10pt arial;"><b>Subject:</b> Re: [theme-reviewers] Theme
Ticket Request</div>
<div><br></div>Fortunately, I'm not seeing an ill effect on my themes, but I
use a clearing <div> after the_content() etc. I believe the method is
still considered a "hack" by some, but it works
(*grin*)<br><br><br>Cais.<br><br>
<div class="gmail_quote">On Mon, Jan 10, 2011 at 8:48 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span>
wrote:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote">Indeed; it's a previously untested test case (floated
content at the end of the last page of a multiple-page post).
<div><br></div>
<div>I'll be adding a minor fix for Oenology as well, based on this test
case. :)</div>
<div><br></div>
<div><font color="#888888">Chip</font>
<div>
<div></div>
<div><br><br>
<div class="gmail_quote">On Sat, Jan 8, 2011 at 8:43 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote">Umm ... does Twenty Ten really not clear floats
correctly?!
<div>
<div></div>
<div><br><br>
<div class="gmail_quote">On Sat, Jan 8, 2011 at 9:39 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote"><a href="http://wpthemetestdata.wordpress.com" target="_blank">wpthemetestdata.wordpress.com</a>
<div><br></div>
<div>It's not yet ready to export a new XML yet, but I can pull one for
you if you'd like?</div>
<div><br></div>
<div><font color="#888888">Chip</font>
<div>
<div></div>
<div><br><br>
<div class="gmail_quote">On Sat, Jan 8, 2011 at 8:28 PM, <span dir="ltr"><<a href="mailto:michael@mfields.org" target="_blank">michael@mfields.org</a>></span> wrote:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote">Chip,<br><br>Where can this new data be downloaded
at? I just downloaded this:<br><br><a href="http://svn.automattic.com/wpcom-themes/demo/test-data.2010-08-02.xml" target="_blank">http://svn.automattic.com/wpcom-themes/demo/test-data.2010-08-02.xml</a><br><br>
and
it hasn't changed. Is there another file?<br><br>Thanks!<br>-Mike<br>
<div><br>> You mean, you didn't like the one I added to
wpthemetestdata? :)<br>><br>> On Sat, Jan 8, 2011 at 8:00 PM,
Edward Caissie<br>> <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>>wrote:<br>><br>>>
I think we found our content sample for post-format: audio ...
thanks,<br>>> Chip!<br>>><br>>><br>>> On Sat,
Jan 8, 2011 at 11:36 AM, Chip Bennett<br>>> <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>>wrote:<br>>><br>>>>
It's on the internet archive:<br>>>> <a href="http://www.archive.org/details/SweetChild2" target="_blank">http://www.archive.org/details/SweetChild2</a>
(stream<br>>>> or download)<br>>>><br>>>>
Enjoy!<br>>>><br>>>><br>>>> On Sat, Jan 8,
2011 at 10:32 AM, Edward Caissie<br>>>> <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a><br>>>> >
wrote:<br>>>><br>>>>> Is it a linkable MP3 ...
I'd like to hear
that<br>>>>><br>>>>><br>>>>> On
Fri, Jan 7, 2011 at 10:53 PM, Chip Bennett<br>>>>> <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>>wrote:<br>>>>><br>>>>>>
At this very moment, I am listening to a bluegrass version of
Sweet<br>>>>>> Child Of Mine... don't act like you're
not jealous!
;)<br>>>>>><br>>>>>><br>>>>>>
On Fri, Jan 7, 2011 at 6:19 PM, Philip M. Hofer (Frumph)
<<br>>>>>> <a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>>
wrote:<br>>>>>><br></div>>>>>>>
Little child theme of miiiiine...... ♫<br>
<div>>>>>>><br>>>>>>> -----
Original Message -----<br>>>>>>> *From:* Edward
Caissie <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>><br>>>>>>>
*To:* <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>>>>
*Sent:* Friday, January 07, 2011 4:15 PM<br>>>>>>>
*Subject:* Re: [theme-reviewers] Theme Ticket
Request<br>>>>>>><br>>>>>>> Ahh
... good, didn't want you to be cursed by GnR again
(*grin*)<br>>>>>>><br>>>>>>> On
Fri, Jan 7, 2011 at 7:01 PM, Philip M. Hofer (Frumph)
<<br>>>>>>> <a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>>
wrote:<br>>>>>>><br>>>>>>>>
Yeah, just got it now, looks like Chip snagged it before I
could<br>>>>>>>>
;)<br>>>>>>>><br>>>>>>>><br>>>>>>>><br>>>>>>>>
----- Original Message -----<br></div>
<div>
<div></div>
<div>>>>>>>> *From:* Edward Caissie <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>><br>>>>>>>>
*To:* <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>>>>>
*Sent:* Friday, January 07, 2011 3:59
PM<br>>>>>>>> *Subject:* Re: [theme-reviewers]
Theme Ticket
Request<br>>>>>>>><br>>>>>>>>
(Hey Phil, are you reading
this?)<br>>>>>>>><br>>>>>>>>
Welcome to the jungle,
Josh!<br>>>>>>>><br>>>>>>>>
Glad to have your
help.<br>>>>>>>><br>>>>>>>><br>>>>>>>>
Cais.<br>>>>>>>><br>>>>>>>>
On Fri, Jan 7, 2011 at 6:46 PM, Chip
Bennett<br>>>>>>>> <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>>wrote:<br>>>>>>>><br>>>>>>>>>
Here you
go!<br>>>>>>>>><br>>>>>>>>>
<a href="http://themes.trac.wordpress.org/ticket/2478" target="_blank">http://themes.trac.wordpress.org/ticket/2478</a><br>>>>>>>>><br>>>>>>>>>
<<a href="http://themes.trac.wordpress.org/ticket/2478#" target="_blank">http://themes.trac.wordpress.org/ticket/2478#</a>>Here's
what I<br>>>>>>>>>
would<br>>>>>>>>>
suggest:<br>>>>>>>>><br>>>>>>>>>
1) Review previous tickets, and ensure that
previous-ticket<br>>>>>>>>>
comments<br>>>>>>>>> have been
addressed<br>>>>>>>>> 2) Check the Theme's
output using the Theme Check
plugin<br>>>>>>>>> 3) Step through the Theme
Review Guidelines, and note any
issues<br>>>>>>>>><br>>>>>>>>>
Let us know if you have any
questions!<br>>>>>>>>><br>>>>>>>>>
Thanks for offering to
help,<br>>>>>>>>><br>>>>>>>>>
Chip<br>>>>>>>>><br>>>>>>>>>
On Fri, Jan 7, 2011 at 5:32 PM, Josh Stauffer
<<br>>>>>>>>> <a href="mailto:joshstauffer@gmail.com" target="_blank">joshstauffer@gmail.com</a>>
wrote:<br>>>>>>>>><br>>>>>>>>>>
Hello,<br>>>>>>>>>><br>>>>>>>>>>
May I please be assigned a Theme from the Theme Review
Trac<br>>>>>>>>>>
Queue?<br>>>>>>>>>> I'm new so please take
it easy on
me.<br>>>>>>>>>><br>>>>>>>>>>
Where can I find the exact process to follow? 5.2
-<br>>>>>>>>>> <a href="http://make.wordpress.org/themes/about/how-to-join-wptrt/" target="_blank">http://make.wordpress.org/themes/about/how-to-join-wptrt/</a><br>>>>>>>>>><br>
>>>>>>>>>
Thanks,<br>>>>>>>>>><br>>>>>>>>>>
Josh<br>>>>>>>>>> WordPress.org username:
joshstauffer<br>>>>>>>>>><br>>>>>>>>>>
_______________________________________________<br>>>>>>>>>>
theme-reviewers mailing list<br>>>>>>>>>>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>>>>>>>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>>>>>>><br>>>>>>>>>><br>
>>>>>>>><br>>>>>>>>>
_______________________________________________<br>>>>>>>>>
theme-reviewers mailing list<br>>>>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>>>>>>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>>>>>><br>>>>>>>>><br>
>>>>>>>
------------------------------<br>>>>>>>><br>>>>>>>>
_______________________________________________<br>>>>>>>>
theme-reviewers mailing list<br>>>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>>>>>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>>>>><br>>>>>>>><br>
>>>>>>>
_______________________________________________<br>>>>>>>>
theme-reviewers mailing list<br>>>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>>>>>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>>>>><br>>>>>>>><br>
>>>>>>
------------------------------<br>>>>>>><br>>>>>>>
_______________________________________________<br>>>>>>>
theme-reviewers mailing list<br>>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>>>>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>>>><br>>>>>>><br>>>>>>>
_______________________________________________<br>>>>>>>
theme-reviewers mailing list<br>>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>>>>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>>>><br>>>>>>><br>>>>>><br>
>>>>>
_______________________________________________<br>>>>>>
theme-reviewers mailing list<br>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>>>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>>><br>>>>>><br>>>>><br>
>>>>
_______________________________________________<br>>>>>
theme-reviewers mailing list<br>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>>><br>>>>><br>>>><br>>>>
_______________________________________________<br>>>>
theme-reviewers mailing list<br>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>>>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>>>><br>>>><br>>><br>>>
_______________________________________________<br>>>
theme-reviewers mailing list<br>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>>><br>>
_______________________________________________<br>>
theme-reviewers mailing list<br>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br><br><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div></div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><p>
</p><hr><div class="im">
<p></p>_______________________________________________<br>theme-reviewers
mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></blockquote></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>