A very nice fix ,,, but, did you leave out the 'after=</p>' intentionally?<br><br><br>Cais.<br><br>PS: I'm not a huge fan of the clearing div, but there are other ideas it can be used with as well ... in this case it's primary function is to protect against images at the end of posts (and commented as such in my themes). EAC<br>
<br><div class="gmail_quote">On Mon, Jan 10, 2011 at 9:48 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
I just fixed with a simple tweak.<div><br></div><div>Here's the relevant part of my loop code, before the tweak (inline doc removed for readability):</div><div><br></div><blockquote style="margin: 0pt 0pt 0pt 40px; border: medium none; padding: 0px;">
<div><div>if ( ( is_home() || is_single() || is_page() ) && ! is_attachment() ) { </div><div><span style="white-space: pre-wrap;"> </span>the_content('Read the rest of this entry &raquo;'); </div>
<div><span style="white-space: pre-wrap;"> </span><b>wp_link_pages(); </b></div><div><span style="white-space: pre-wrap;"> </span>} else if ( is_attachment() ) { </div><div><span style="white-space: pre-wrap;"> </span>if ( wp_attachment_is_image() ) {</div>
<div><span style="white-space: pre-wrap;"> </span>get_template_part( 'post-entry-image' ); </div><div><span style="white-space: pre-wrap;"> </span>} else {</div><div><span style="white-space: pre-wrap;"> </span>the_content('Read the rest of this entry &raquo;');</div>
<div><span style="white-space: pre-wrap;"> </span>}</div><div><span style="white-space: pre-wrap;"> </span>} else { </div><div><span style="white-space: pre-wrap;"> </span>the_excerpt(); </div>
<div><span style="white-space: pre-wrap;"> </span>}</div></div></blockquote><div><br></div><div>Here it is, with the tweak:</div><div><br></div><blockquote style="margin: 0pt 0pt 0pt 40px; border: medium none; padding: 0px;">
<div><div>if ( ( is_home() || is_single() || is_page() ) && ! is_attachment() ) { </div><div><span style="white-space: pre-wrap;"> </span>the_content('Read the rest of this entry &raquo;'); </div>
<div><span style="white-space: pre-wrap;"> </span><b>wp_link_pages(<font color="#ff0000">'before=<p class="link-pages">Page: '</font>);</b> </div><div><span style="white-space: pre-wrap;"> </span>} else if ( is_attachment() ) { </div>
<div><span style="white-space: pre-wrap;"> </span>if ( wp_attachment_is_image() ) {</div><div><span style="white-space: pre-wrap;"> </span>get_template_part( 'post-entry-image' ); </div>
<div><span style="white-space: pre-wrap;"> </span>} else {</div><div><span style="white-space: pre-wrap;"> </span>the_content('Read the rest of this entry &raquo;');</div>
<div><span style="white-space: pre-wrap;"> </span>}</div><div><span style="white-space: pre-wrap;"> </span>} else { </div><div><span style="white-space: pre-wrap;"> </span>the_excerpt(); </div>
<div><span style="white-space: pre-wrap;"> </span>}</div></div></blockquote><div><br></div><div>And here's the relevant CSS addition:</div><div><br></div><blockquote style="margin: 0pt 0pt 0pt 40px; border: medium none; padding: 0px;">
<div><div>.post-entry .link-pages {</div><div><span style="white-space: pre-wrap;"> </span>clear:both;</div><div>}</div></div></blockquote><div><br></div><div>No need for a clearing DIV (I admit to having to use one, in one place. I can't find a viable work-around. But it grates on my sense of semantic markup. :) )</div>
<div><br></div><div>I might put up a quick tutorial on the Make site.</div><div><br></div><div><font color="#888888">Chip</font><div><div></div><div class="h5"><br><div><br><div class="gmail_quote">On Mon, Jan 10, 2011 at 8:37 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Fortunately, I'm not seeing an ill effect on my themes, but I use a clearing <div> after the_content() etc. I believe the method is still considered a "hack" by some, but it works (*grin*)<br>
<br><br>Cais.<div><div></div><div><br>
<br><div class="gmail_quote">On Mon, Jan 10, 2011 at 8:48 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Indeed; it's a previously untested test case (floated content at the end of the last page of a multiple-page post).<div><br></div><div>I'll be adding a minor fix for Oenology as well, based on this test case. :)</div>
<div><br></div><div><font color="#888888">Chip</font><div><div></div><div><br><br><div class="gmail_quote">On Sat, Jan 8, 2011 at 8:43 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Umm ... does Twenty Ten really not clear floats correctly?!<div><div></div><div><br><br><div class="gmail_quote">On Sat, Jan 8, 2011 at 9:39 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><a href="http://wpthemetestdata.wordpress.com" target="_blank">wpthemetestdata.wordpress.com</a><div>
<br></div><div>It's not yet ready to export a new XML yet, but I can pull one for you if you'd like?</div><div><br></div><div><font color="#888888">Chip</font><div><div></div><div><br>
<br><div class="gmail_quote">On Sat, Jan 8, 2011 at 8:28 PM, <span dir="ltr"><<a href="mailto:michael@mfields.org" target="_blank">michael@mfields.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Chip,<br>
<br>
Where can this new data be downloaded at? I just downloaded this:<br>
<br>
<a href="http://svn.automattic.com/wpcom-themes/demo/test-data.2010-08-02.xml" target="_blank">http://svn.automattic.com/wpcom-themes/demo/test-data.2010-08-02.xml</a><br>
<br>
and it hasn't changed. Is there another file?<br>
<br>
Thanks!<br>
-Mike<br>
<div><br>
> You mean, you didn't like the one I added to wpthemetestdata? :)<br>
><br>
> On Sat, Jan 8, 2011 at 8:00 PM, Edward Caissie<br>
> <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>>wrote:<br>
><br>
>> I think we found our content sample for post-format: audio ... thanks,<br>
>> Chip!<br>
>><br>
>><br>
>> On Sat, Jan 8, 2011 at 11:36 AM, Chip Bennett<br>
>> <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>>wrote:<br>
>><br>
>>> It's on the internet archive:<br>
>>> <a href="http://www.archive.org/details/SweetChild2" target="_blank">http://www.archive.org/details/SweetChild2</a> (stream<br>
>>> or download)<br>
>>><br>
>>> Enjoy!<br>
>>><br>
>>><br>
>>> On Sat, Jan 8, 2011 at 10:32 AM, Edward Caissie<br>
>>> <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a><br>
>>> > wrote:<br>
>>><br>
>>>> Is it a linkable MP3 ... I'd like to hear that<br>
>>>><br>
>>>><br>
>>>> On Fri, Jan 7, 2011 at 10:53 PM, Chip Bennett<br>
>>>> <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>>wrote:<br>
>>>><br>
>>>>> At this very moment, I am listening to a bluegrass version of Sweet<br>
>>>>> Child Of Mine... don't act like you're not jealous! ;)<br>
>>>>><br>
>>>>><br>
>>>>> On Fri, Jan 7, 2011 at 6:19 PM, Philip M. Hofer (Frumph) <<br>
>>>>> <a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>> wrote:<br>
>>>>><br>
</div>>>>>>> Little child theme of miiiiine...... ♫<br>
<div>>>>>>><br>
>>>>>> ----- Original Message -----<br>
>>>>>> *From:* Edward Caissie <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>><br>
>>>>>> *To:* <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>>>> *Sent:* Friday, January 07, 2011 4:15 PM<br>
>>>>>> *Subject:* Re: [theme-reviewers] Theme Ticket Request<br>
>>>>>><br>
>>>>>> Ahh ... good, didn't want you to be cursed by GnR again (*grin*)<br>
>>>>>><br>
>>>>>> On Fri, Jan 7, 2011 at 7:01 PM, Philip M. Hofer (Frumph) <<br>
>>>>>> <a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>> wrote:<br>
>>>>>><br>
>>>>>>> Yeah, just got it now, looks like Chip snagged it before I could<br>
>>>>>>> ;)<br>
>>>>>>><br>
>>>>>>><br>
>>>>>>><br>
>>>>>>> ----- Original Message -----<br>
</div><div><div></div><div>>>>>>>> *From:* Edward Caissie <<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>><br>
>>>>>>> *To:* <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>>>>> *Sent:* Friday, January 07, 2011 3:59 PM<br>
>>>>>>> *Subject:* Re: [theme-reviewers] Theme Ticket Request<br>
>>>>>>><br>
>>>>>>> (Hey Phil, are you reading this?)<br>
>>>>>>><br>
>>>>>>> Welcome to the jungle, Josh!<br>
>>>>>>><br>
>>>>>>> Glad to have your help.<br>
>>>>>>><br>
>>>>>>><br>
>>>>>>> Cais.<br>
>>>>>>><br>
>>>>>>> On Fri, Jan 7, 2011 at 6:46 PM, Chip Bennett<br>
>>>>>>> <<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>>wrote:<br>
>>>>>>><br>
>>>>>>>> Here you go!<br>
>>>>>>>><br>
>>>>>>>> <a href="http://themes.trac.wordpress.org/ticket/2478" target="_blank">http://themes.trac.wordpress.org/ticket/2478</a><br>
>>>>>>>><br>
>>>>>>>> <<a href="http://themes.trac.wordpress.org/ticket/2478#" target="_blank">http://themes.trac.wordpress.org/ticket/2478#</a>>Here's what I<br>
>>>>>>>> would<br>
>>>>>>>> suggest:<br>
>>>>>>>><br>
>>>>>>>> 1) Review previous tickets, and ensure that previous-ticket<br>
>>>>>>>> comments<br>
>>>>>>>> have been addressed<br>
>>>>>>>> 2) Check the Theme's output using the Theme Check plugin<br>
>>>>>>>> 3) Step through the Theme Review Guidelines, and note any issues<br>
>>>>>>>><br>
>>>>>>>> Let us know if you have any questions!<br>
>>>>>>>><br>
>>>>>>>> Thanks for offering to help,<br>
>>>>>>>><br>
>>>>>>>> Chip<br>
>>>>>>>><br>
>>>>>>>> On Fri, Jan 7, 2011 at 5:32 PM, Josh Stauffer <<br>
>>>>>>>> <a href="mailto:joshstauffer@gmail.com" target="_blank">joshstauffer@gmail.com</a>> wrote:<br>
>>>>>>>><br>
>>>>>>>>> Hello,<br>
>>>>>>>>><br>
>>>>>>>>> May I please be assigned a Theme from the Theme Review Trac<br>
>>>>>>>>> Queue?<br>
>>>>>>>>> I'm new so please take it easy on me.<br>
>>>>>>>>><br>
>>>>>>>>> Where can I find the exact process to follow? 5.2 -<br>
>>>>>>>>> <a href="http://make.wordpress.org/themes/about/how-to-join-wptrt/" target="_blank">http://make.wordpress.org/themes/about/how-to-join-wptrt/</a><br>
>>>>>>>>><br>
>>>>>>>>> Thanks,<br>
>>>>>>>>><br>
>>>>>>>>> Josh<br>
>>>>>>>>> WordPress.org username: joshstauffer<br>
>>>>>>>>><br>
>>>>>>>>> _______________________________________________<br>
>>>>>>>>> theme-reviewers mailing list<br>
>>>>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>>>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>>>>>><br>
>>>>>>>>><br>
>>>>>>>><br>
>>>>>>>> _______________________________________________<br>
>>>>>>>> theme-reviewers mailing list<br>
>>>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>>>>><br>
>>>>>>>><br>
>>>>>>> ------------------------------<br>
>>>>>>><br>
>>>>>>> _______________________________________________<br>
>>>>>>> theme-reviewers mailing list<br>
>>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>>>><br>
>>>>>>><br>
>>>>>>> _______________________________________________<br>
>>>>>>> theme-reviewers mailing list<br>
>>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>>>><br>
>>>>>>><br>
>>>>>> ------------------------------<br>
>>>>>><br>
>>>>>> _______________________________________________<br>
>>>>>> theme-reviewers mailing list<br>
>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>>><br>
>>>>>><br>
>>>>>> _______________________________________________<br>
>>>>>> theme-reviewers mailing list<br>
>>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>>><br>
>>>>>><br>
>>>>><br>
>>>>> _______________________________________________<br>
>>>>> theme-reviewers mailing list<br>
>>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>>><br>
>>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> theme-reviewers mailing list<br>
>>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>>><br>
>>>><br>
>>><br>
>>> _______________________________________________<br>
>>> theme-reviewers mailing list<br>
>>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>><br>
>>><br>
>><br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
>><br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
<br>
<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>