Best practice (and most importantly, the *accepted* best practice with respect to WordPress Themes) is to put all options in an array:<div><br></div><div>1) It protects your options from potential conflict (which is another point: you didn't prefix your options names with "theme-slug")</div>
<div>2) It makes white-listing much easier</div><div>3) It makes manipulating options much easier</div><div>4) It makes removing options from the DB much easier</div><div>5) It makes reading the DB much easier</div><div><br>
</div><div>(I'm sure there are more.)</div><div><br></div><div>*Any* tutorials put out by the Theme Review Team should be consistent on matters of guidelines and best practices. There are some conventions that I don't personally like, either - but for the sake of standardization (and not creating confusion), I put aside my personal preferences.</div>
<div><br></div><div>Chip<br><br><div class="gmail_quote">On Fri, Jan 7, 2011 at 1:26 AM, Daniel Tara <span dir="ltr"><<a href="mailto:contact@onedesigns.com">contact@onedesigns.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">By the way, I personally don’t like having all the options in a single registered array. It’s ugly to call for a global variable’s array key instead of the option directly and it’s confusing to give the name for a HTML input field arrayname[arraykey]. Just my 2 cents on this.</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">Daniel</span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span></p>
<div><div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b><span style="font-size:10.0pt">From:</span></b><span style="font-size:10.0pt"> <a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a> [mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>] <b>On Behalf Of </b>Daniel Tara<br>
<b>Sent:</b> Friday, January 07, 2011 9:22 AM</span></p><div class="im"><br><b>To:</b> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><b>Subject:</b> Re: [theme-reviewers] Article on how to create a Theme Options Page for WordPress</div>
<p></p></div></div><div class="im"><p class="MsoNormal"> </p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">Thanks for the feedback,</span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">I corrected the grammar errors, changed the capability to ‘edit_theme_options’, rewritten some portions where I omitted things and bundled the entire code into a child theme for Twenty Ten, which I tested and is working.</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">Daniel</span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt">From:</span></b><span style="font-size:10.0pt"> <a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a> [mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>] <b>On Behalf Of </b>Edward Caissie<br>
<b>Sent:</b> Thursday, January 06, 2011 3:42 PM<br><b>To:</b> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><b>Subject:</b> Re: [theme-reviewers] Article on how to create a Theme Options Page for WordPress</span></p>
<p class="MsoNormal"> </p><p class="MsoNormal" style="margin-bottom:12.0pt">There are a few minor typos and a grammar issue or two, otherwise ... I believe the capability should be 'edit_theme_options' versus 'manage_options' based on Justin Tadlock's discussions.<br>
<br>Good Read! Definitely adds more insight into the Settings API.<br><br><br><br>Cais.<br><br>PS: The first time I clicked on the link it took me to the page, every other time I click or use the URL (copy&paste) it wants to open my feed reader ... EAC</p>
<div><p class="MsoNormal">On Wed, Jan 5, 2011 at 11:12 PM, Daniel Tara <<a href="mailto:contact@onedesigns.com" target="_blank">contact@onedesigns.com</a>> wrote:</p><div><div><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">Thought I make this public,</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">Here’s an article on how to create options pages for WordPress themes using the Settings API</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><a href="http://www.onedesigns.com/tutorials/how-to-create-a-wordpress-theme-options-page" target="_blank">http://www.onedesigns.com/tutorials/how-to-create-a-wordpress-theme-options-page</a></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">I would appreciate any feedback as I probably missed some things out.</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span></p><p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">Daniel</span><span style="color:#888888"></span></p></div></div><p class="MsoNormal" style="margin-bottom:12.0pt">
<br>_______________________________________________<br>theme-reviewers mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a></p>
</div><p class="MsoNormal"> </p></div></div></div><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>