Okay, then. Good enough for me!<div><br></div><div>I'll approve the ticket. But, I'd like someone with more PHP/security expertise than I have to take a look at what this Theme is doing in admin/ with overwriting files and changing permissions and whatnot, just to make sure there aren't any issues. I *think* everything is okay, but following all of that is still a bit above my pay grade.</div>
<div><br></div><div>Chip<br><br><div class="gmail_quote">On Tue, Nov 16, 2010 at 10:28 AM, Otto <span dir="ltr"><<a href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Tue, Nov 16, 2010 at 10:24 AM, Chip Bennett <<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>> wrote:<br>
> So, essentially, the image itself is embedded in the CSS file?<br>
> I'm still uneasy about it, but that could be due to lack of understanding.<br>
> And I still question whether it's actually necessary.<br>
<br>
</div>Could he put the image file in a separate file and then make an http<br>
link to it there instead? Sure.<br>
Is including the data inline like this faster? Yes, it's much, much faster.<br>
<br>
For small images (these are 1x1 pixel PNG images), this is WAY faster<br>
than including the image separately URL and incurring the overhead of<br>
an extra HTTP request.<br>
<br>
Necessary? No.<br>
Understandable and faster and better and safe and actually the correct<br>
way to do it? Yes.<br>
<br>
I give this a total thumbs up and an "okay". There's nothing wrong<br>
here of any sort.<br>
<font color="#888888"><br>
-Otto<br>
</font><div><div></div><div class="h5">_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div>