A quick draft item has been added to the Theme Review ...<br><br><a href="http://codex.wordpress.org/Theme_Review#Site_Information">http://codex.wordpress.org/Theme_Review#Site_Information</a><br><br>IF there are additional get_option() URLs that should be addressed similarly please list them here so they can be added to the Theme Review page.<br>
<br><br>Cais.<br><br><div class="gmail_quote">On Tue, Oct 19, 2010 at 2:39 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
This should be added to the <a href="http://codex.wordpress.org/Theme_Review#Template_Tags_and_Hooks" target="_blank">http://codex.wordpress.org/Theme_Review#Template_Tags_and_Hooks</a> section ... still currently in "draft" status.<br>
<br><br>Cais.<div><div></div><div class="h5"><br><br><div class="gmail_quote">On Tue, Oct 19, 2010 at 12:53 PM, Lance Willett <span dir="ltr"><<a href="mailto:nanobar@gmail.com" target="_blank">nanobar@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>> get_option('home') and get_option('siteurl') should *not* be used in themes.<br>
> I believe the guidelines say so.<br>
<br>
</div>I don't see this anywhere in the guidelines (nor in any of the Theme<br>
Standards docs). Thanks for bringing it up though—I had missed<br>
<a href="http://core.trac.wordpress.org/ticket/9008" target="_blank">http://core.trac.wordpress.org/ticket/9008</a> somehow. :)<br>
<br>
I know there are lots of instances of both of get_option('home') in<br>
header.php across many themes, and get_option('siteurl') in<br>
comments.php. Also get_settings('home') which is in older themes<br>
should be moved to home_url(). I'll be doing a big cleanup for all of<br>
these for our WordPress.com themes.<br>
<div><div></div><div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br>
</div></div></blockquote></div><br>