My point is the issues are either minor or they are not ... obviously the flexibility to approve themes with "minor" issues should and is being used ... but, and I write again, if they are *required* to be fixed with the next revision then they should have been *required* to be fixed with the current version as they were IMO not "minor" to begin with if the reviewer is resolving as "not-approved" with the next revision.<br>
<br>If the same "minor" issue was later decided to be not a "minor" issue then that is a different matter.<br><br><br>Cais.<br><br><div class="gmail_quote">On Thu, Oct 14, 2010 at 10:03 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">I disagree. We need *some* flexibility to approve tickets that have only minor issues.<div>
<br>
</div><div>At the same time, if we approve a ticket with such minor issues, <i>with the expectation that those issues are addressed in the next revision</i>, then we should not let those minor issues pass in the review of the next revision.</div>
<div><br></div><div><font color="#888888">Chip</font><div><div></div><div class="h5"><br><br><div class="gmail_quote">On Thu, Oct 14, 2010 at 8:42 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
If a ticket requires a special resolution as a pointer for "approved-with-next-revision-fixes" then perhaps the ticket should be immediately re-reviewed for those concerns.<br><br>IMO, if they are relevant enough to stop future versions of the theme from being approved if not addressed, they are relevant enough to stop the ticket at hand from being approved.<br>
<br><br>Cais.<br><br><div class="gmail_quote"><div><div></div><div>On Thu, Oct 14, 2010 at 8:45 AM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div></div><div>
As we approve more Themes - and especially, Themes that are approved, but that have comments indicating certain issues are "Required, but Can Be Fixed in Next Revision" - I'm thinking that we might want to consider another ticket resolution: "approved-with-comments" or "approved-with-next-revision-fixes" or something along those lines.<div>
<br></div><div>The reason? I'm seeing tickets for "next revisions" of such tickets, that seem to ignore completely the issues indicated as "Required, but Can Be Fixed in Next Revision". </div><div>
Of course, I'm resolving such tickets as "not-approved" - but the reason I bring it up is that we haven't really discussed how we handle such tickets. </div><div><br></div><div>My process for a Priority #1 Queue ticket is:</div>
<div><br></div><div>1) Check previous-tickets report, to ensure ticket is in correct queue (Pross: can we get the *resolution* column to display by default on this report?)</div><div>2) If correct queue, assign ticket to myself</div>
<div>3) Open previous ticket, to check for any issues indicated as "Can Be Fixed in Next Revision"</div><div>4) Diff-Review</div><div>5) Theme-Check</div><div>6) Summarize status of previous-ticket comments</div>
<div>7) (if necessary) Install/check activated Theme</div><div>8) Close/resolve ticket</div><div><br></div><div>The problem I'm foreseeing, of course, is that the previous-ticket comments can very easily fall through the cracks, unless the next-ticket reviewer makes a conscious effort to check the previous ticket. We could alleviate this concern by introducing an appropriate ticket resolution, that would alert the next-ticket reviewer to the presence of any such previous-ticket issues.</div>
<div><br></div><div>Thoughts?</div><div><br></div><font color="#888888"><div>Chip</div>
</font><br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>