That seems like a more efficient approach, yeah: load the string once, then perform many checks.<div><br></div><div>What would be nice would be the ability to control the error message that gets output for each check, to point the developer to 1) the specific Theme Review Guideline, and/or 2) the Codex reference, for each check.</div>
<div><br></div><div>(Thanks to Pross, we have most of those links collated already.)</div><div><br></div><div>Chip<br><br><div class="gmail_quote">On Wed, Oct 13, 2010 at 11:53 AM, Andrew Nacin <span dir="ltr"><<a href="mailto:wp@andrewnacin.com">wp@andrewnacin.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">On Wed, Oct 13, 2010 at 12:35 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
</div><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I like the implementation, but we'll have to be careful about the assumptions.<div><br></div><div>For example: wp_footer() will NOT always be in footer.php. It can (legitimately) be in index.php (or any hierarchical template file (archive.php, page.php, attachment.php, 404.php, etc.).</div>
</blockquote><div><br></div></div><div>I'm sure it was just a quick example. I think what we'd end up doing is loading all of the PHP files into a string, and all the CSS files into a string, etc., and then do string searches on whichever we need to depending on the check.</div>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>