The Theme Review process does indicate required
CSS elements. If its a case where these elements must be within the
style.css file itself and not accepted when include via @import then
this must be noted on the Theme Review page(s).<br>
<br>
I also agree, unless there is good reason, all upload checks should be
done and all that are not passed reported. It is an automated process
after all ...<br>
<br>
<br>
Cais.<br><br><div class="gmail_quote">On Fri, Sep 24, 2010 at 3:43 PM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net">philip@frumph.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div bgcolor="#ffffff">
<div><font size="2" face="Arial">The aligncenter alignleft and alignright classes
have been there from the onset, they're automatically inserted into things from
the core and not including them would drastically remove
functionality.</font></div>
<div><font size="2" face="Arial"></font> </div>
<div><font size="2" face="Arial"></font> </div>
<blockquote style="border-left: 2px solid rgb(0, 0, 0); padding-left: 5px; padding-right: 0px; margin-left: 5px; margin-right: 0px;"><div><div></div><div class="h5">
<div style="font: 10pt arial;">----- Original Message ----- </div>
<div style="font: 10pt arial; background: none repeat scroll 0% 0% rgb(228, 228, 228);"><b>From:</b>
<a title="chip@chipbennett.net" href="mailto:chip@chipbennett.net" target="_blank">Chip
Bennett</a> </div>
<div style="font: 10pt arial;"><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
</div>
<div style="font: 10pt arial;"><b>Sent:</b> Friday, September 24, 2010 12:40
PM</div>
<div style="font: 10pt arial;"><b>Subject:</b> Re: [theme-reviewers] Theme
Uploader and CSS Classes</div>
<div><br></div>Also, I really think the uploader should output ALL failing
criteria, rather than stopping at the first one.
<div><br></div>
<div>How frustrating it must be, to have to fix a Theme five or six times,
re-package it, and re-attempt to upload it. No wonder the Theme developers get
to us already frustrated!</div>
<div><br></div>
<div>Otto, can this be fixed? Can you set the upload script to complete ALL of
its checks, and then output the results, rather than stopping at the first
failed criterion?</div>
<div><br></div>
<div>Chip</div>
<div><br>
<div class="gmail_quote">On Fri, Sep 24, 2010 at 2:37 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span>
wrote:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left: 1ex;" class="gmail_quote">I think this is a bit of a fail: the uploader fails if it
does not find the alignment classes in style.css.
<div><br></div>
<div>I understand the need to ensure that Themes include alignment classes,
but this is part of the Review Guidelines. The uploader fails if it does not
find these classes in style.css - but fails to check any other CSS file
(that might, e.g. be @import included) to see if one of them includes the
alignment classes.</div>
<div><br></div>
<div>The easy fix, of course, is to add the required classes to style.css,
and then override them later. But I think this is perhaps something that
shouldn't fail the upload process.</div>
<div><br></div>
<div>Thoughts?</div>
<div><br></div><font color="#888888">
<div>Chip</div></font></blockquote></div><br></div>
</div></div><p>
</p><hr>
<p></p>_______________________________________________<br>theme-reviewers
mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>