<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=iso-8859-1" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18928">
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT size=2 face=Arial>The aligncenter alignleft and alignright classes
have been there from the onset, they're automatically inserted into things from
the core and not including them would drastically remove
functionality.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="FONT: 10pt arial; BACKGROUND: #e4e4e4; font-color: black"><B>From:</B>
<A title=chip@chipbennett.net href="mailto:chip@chipbennett.net">Chip
Bennett</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A
title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
</DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Friday, September 24, 2010 12:40
PM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [theme-reviewers] Theme
Uploader and CSS Classes</DIV>
<DIV><BR></DIV>Also, I really think the uploader should output ALL failing
criteria, rather than stopping at the first one.
<DIV><BR></DIV>
<DIV>How frustrating it must be, to have to fix a Theme five or six times,
re-package it, and re-attempt to upload it. No wonder the Theme developers get
to us already frustrated!</DIV>
<DIV><BR></DIV>
<DIV>Otto, can this be fixed? Can you set the upload script to complete ALL of
its checks, and then output the results, rather than stopping at the first
failed criterion?</DIV>
<DIV><BR></DIV>
<DIV>Chip</DIV>
<DIV><BR>
<DIV class=gmail_quote>On Fri, Sep 24, 2010 at 2:37 PM, Chip Bennett <SPAN
dir=ltr><<A
href="mailto:chip@chipbennett.net">chip@chipbennett.net</A>></SPAN>
wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>I think this is a bit of a fail: the uploader fails if it
does not find the alignment classes in style.css.
<DIV><BR></DIV>
<DIV>I understand the need to ensure that Themes include alignment classes,
but this is part of the Review Guidelines. The uploader fails if it does not
find these classes in style.css - but fails to check any other CSS file
(that might, e.g. be @import included) to see if one of them includes the
alignment classes.</DIV>
<DIV><BR></DIV>
<DIV>The easy fix, of course, is to add the required classes to style.css,
and then override them later. But I think this is perhaps something that
shouldn't fail the upload process.</DIV>
<DIV><BR></DIV>
<DIV>Thoughts?</DIV>
<DIV><BR></DIV><FONT color=#888888>
<DIV>Chip</DIV></FONT></BLOCKQUOTE></DIV><BR></DIV>
<P>
<HR>
<P></P>_______________________________________________<BR>theme-reviewers
mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></BLOCKQUOTE></BODY></HTML>