<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.apple-style-span
{mso-style-name:apple-style-span;}
span.E-MailFormatvorlage18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=DE link=blue vlink=purple>
<div class=WordSection1>
<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Now I got it. Thanks for your explanation!<o:p></o:p></span></p>
<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p> </o:p></span></p>
<div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'>
<div>
<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'>
<p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>Von:</span></b><span
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>
theme-reviewers-bounces@lists.wordpress.org
[mailto:theme-reviewers-bounces@lists.wordpress.org] <b>Im Auftrag von </b>Andrew
Nacin<br>
<b>Gesendet:</b> Montag, 13. September 2010 00:16<br>
<b>An:</b> theme-reviewers@lists.wordpress.org<br>
<b>Betreff:</b> Re: [theme-reviewers] My First Suggest-Approval *sniff*<o:p></o:p></span></p>
</div>
</div>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal>On Sun, Sep 12, 2010 at 5:53 PM, Chris <<a
href="mailto:chris@thematic4you.com">chris@thematic4you.com</a>> wrote:<br>
> The Carrington Core uses a user level in its add_submenu_page() call. The
user levels<o:p></o:p></p>
<div>
<p class=MsoNormal>> were replaced in WP 2.0 and deprecated with WP 3.0
(checked this against WP 2.9.2),<o:p></o:p></p>
</div>
<div>
<p class=MsoNormal>> but debug tells me deprecated since 2.0.<br>
<br>
They were deprecated in 2.0. We just didn't report it until 3.0 because that's
when we introduced deprecated argument reporting. There's also some older
widget functions for example that were replaced in 2.8, but we didn't actually
add them to deprecated.php until 3.0. Those functions will report 2.8.<o:p></o:p></p>
<div>
<p class=MsoNormal><br>
> In this case I would recommend to replace the user level with a role /
capability. At this<o:p></o:p></p>
</div>
<div>
<p class=MsoNormal>> time I don’t see this as an requirement.<o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><o:p> </o:p></p>
</div>
<div>
<p class=MsoNormal>Yes, it is a requirement currently, as the theme cannot have
any deprecated calls.<o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><o:p> </o:p></p>
</div>
<div>
<p class=MsoNormal>I said that deprecated calls should be<span
class=apple-style-span><span style='font-size:10.0pt;font-family:"Arial","sans-serif"'> properly
evaluated for severity specifically with user levels in mind (among other
things). Using user levels is an egregious error and I would want a theme that
uses them rejected every time.</span></span><o:p></o:p></p>
</div>
<div>
<p class=MsoNormal><o:p> </o:p></p>
</div>
<div>
<p class=MsoNormal><span class=apple-style-span><span style='font-size:10.0pt;
font-family:"Arial","sans-serif"'>On the other hand, if the theme uses
clean_url() instead of esc_url() (as but one example), please don't reject that
theme. I'm just glad they're sanitizing their outputs.</span></span><o:p></o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>