But why *shouldn't* it be a requirement?<div><br></div><div>(Seriously: I'm open to valid arguments here. None of us know all use cases and potential issues.)</div><div><br></div><div>Here's my thinking: unless the Theme is doing something super-complicated with user levels that can't be one-to-one replicated with user roles, they should be using the latter. Especially if the issue is doing a search/replace for a text string containing a number with a text string containing a role. Also, user roles have been around for almost five years, which should be plenty of time to replace user levels.</div>
<div><br></div><div>Sure, there is some concern with newly deprecated functions. But even then, we've stated up front that we're giving at least a month grace-period from release of the WP version in which the deprecation takes place - and functions to be deprecated are announced *far* in advance of version-release. Theme/Plugin devs bear the responsibility to follow WP development, and to keep their code current with core changes.</div>
<div><br></div><div>I guess, what I'm saying is that I don't think "it's inconvenient" or "it's more work than I'm used to" is an inherently valid argument against a Theme Review guideline. (Not directed at you, but to others who have implied as much in other arguments.)</div>
<div><br></div><div>Chip<br><br><div class="gmail_quote">On Sun, Sep 12, 2010 at 4:53 PM, Chris <span dir="ltr"><<a href="mailto:chris@thematic4you.com">chris@thematic4you.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div lang="DE" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;color:#1F497D">Let me pick up this part “.. it all depends on the
deprecated call”. </span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;color:#1F497D"> </span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;color:#1F497D">The Carrington Core uses a user level in its add_submenu_page()
call. The user levels were replaced in WP 2.0 and deprecated with WP 3.0
(checked this against WP 2.9.2), but debug tells me deprecated since 2.0.</span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;color:#1F497D"> </span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;color:#1F497D"> In this case I would recommend to replace the user level
with a role / capability. At this time I don’t see this as an
requirement.</span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;color:#1F497D"> </span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;color:#1F497D">Chris</span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;color:#1F497D"> </span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;color:#1F497D"> </span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-size:10.0pt">Von:</span></b><span style="font-size:10.0pt"> <a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>
[mailto:<a href="mailto:theme-reviewers-bounces@lists.wordpress.org" target="_blank">theme-reviewers-bounces@lists.wordpress.org</a>] <b>Im Auftrag von </b>Andrew
Nacin<br>
<b>Gesendet:</b> Sonntag, 12. September 2010 20:09<br>
<b>An:</b> <a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<b>Betreff:</b> Re: [theme-reviewers] My First Suggest-Approval *sniff*</span></p>
</div>
</div><div class="im">
<p class="MsoNormal"> </p>
<div>
<div>
<p class="MsoNormal"><span style="color:#1F497D">…</span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">That's not to say that theme authors
shouldn't be encouraged to rectify notices on future theme submissions, or that
the tolerance level shouldn't go down on successive submissions by that author.
</span>But it all depends on the notice, and it all depends on the deprecated
call. If notices and deprecated calls cannot be properly evaluated for
severity, then they should not be evaluated at all.</p>
</div>
</div>
</div></div>
</div>
</div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>