<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">

<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
 /* Font Definitions */
 @font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
        {font-family:Tahoma;
        panose-1:2 11 6 4 3 5 4 4 2 4;}
 /* Style Definitions */
 p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0cm;
        margin-bottom:.0001pt;
        font-size:12.0pt;
        font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:blue;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:purple;
        text-decoration:underline;}
span.E-MailFormatvorlage17
        {mso-style-type:personal-reply;
        font-family:"Calibri","sans-serif";
        color:#1F497D;}
.MsoChpDefault
        {mso-style-type:export-only;}
@page WordSection1
        {size:612.0pt 792.0pt;
        margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
        {page:WordSection1;}
-->
</style>
<!--[if gte mso 9]><xml>
 <o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
 <o:shapelayout v:ext="edit">
  <o:idmap v:ext="edit" data="1" />
 </o:shapelayout></xml><![endif]-->
</head>

<body lang=DE link=blue vlink=purple>

<div class=WordSection1>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>It&#8217;s not that easy to create a lesson from this one. <o:p></o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>This is the second time that I ran into this worm. The original
infection source is a BuddyPress theme. I had two cases where WPMU
installations were infected. Both owners were testing themes. Unfortunately
both cleaned the systems too fast, so I couldn&#8217;t get a list of installed
themes.<o:p></o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>There is no real signature for this worm. You could search for _check_isactive_widget
or $_GET[&quot;cperpage&quot;] but everything could be changed without any
problem. Everything else could come directly from a PHP tutorial. <o:p></o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Maybe the upload script could create a fopen() flag. In this
case, we could check the code for a potential risk. <o:p></o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Chris<o:p></o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>&nbsp;&nbsp;<o:p></o:p></span></p>

<p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'>

<div>

<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'>

<p class=MsoNormal><b><span lang=EN-US style='font-size:10.0pt;font-family:
"Tahoma","sans-serif"'>Von:</span></b><span lang=EN-US style='font-size:10.0pt;
font-family:"Tahoma","sans-serif"'> theme-reviewers-bounces@lists.wordpress.org
[mailto:theme-reviewers-bounces@lists.wordpress.org] <b>Im Auftrag von </b>Chip
Benne</span><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>tt<br>
<b>Gesendet:</b> Freitag, 3. September 2010 15:59<br>
<b>An:</b> theme-reviewers@lists.wordpress.org<br>
<b>Betreff:</b> Re: [theme-reviewers] Emergency Call<o:p></o:p></span></p>

</div>

</div>

<p class=MsoNormal><o:p>&nbsp;</o:p></p>

<p class=MsoNormal>Can you and Chris put together some kind of lesson for the
rest of us? Sort of a &quot;watch out for this kind of thing&quot; that we can
learn from?<o:p></o:p></p>

<div>

<p class=MsoNormal><o:p>&nbsp;</o:p></p>

</div>

<div>

<p class=MsoNormal>(I found the second one before you got it pulled from SVN;
so at least I can look at it in the meantime.)<o:p></o:p></p>

</div>

<div>

<p class=MsoNormal><o:p>&nbsp;</o:p></p>

</div>

<div>

<p class=MsoNormal style='margin-bottom:12.0pt'>Chip<o:p></o:p></p>

<div>

<p class=MsoNormal>On Fri, Sep 3, 2010 at 8:56 AM, Otto &lt;<a
href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>&gt; wrote:<o:p></o:p></p>

<p class=MsoNormal>Actually, I went ahead and removed them from SVN because we
don't need<br>
malware of that sort in there.<br>
<br>
But if you want a copy, I did save the bad functions.php file, just<br>
for examination later. We may be able to detect this sort of thing in<br>
the uploader and prevent it from uploading.<br>
<span style='color:#888888'><br>
-Otto</span><o:p></o:p></p>

<div>

<div>

<p class=MsoNormal><br>
<br>
<br>
On Fri, Sep 3, 2010 at 8:50 AM, Chip Bennett &lt;<a
href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>&gt; wrote:<br>
&gt; I'll have to take a look at those tickets.<br>
&gt; Good learning opportunity for the reviewers? (Or an example of why
security<br>
&gt; gurus are needed, for a security-review stage of the process?)<br>
&gt; Chip<br>
&gt;<br>
&gt; On Fri, Sep 3, 2010 at 8:45 AM, Otto &lt;<a
href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>&gt; wrote:<br>
&gt;&gt;<br>
&gt;&gt; Never mind. I see it. It's in the functions.php file, disguised.
Clever.<br>
&gt;&gt;<br>
&gt;&gt; -Otto<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; On Fri, Sep 3, 2010 at 8:42 AM, Otto &lt;<a
href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</a>&gt; wrote:<br>
&gt;&gt; &gt; I'm looking at it now.. Where's the worm? Not finding it.<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; -Otto<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; On Fri, Sep 3, 2010 at 8:07 AM, Chris &lt;<a
href="mailto:chris@thematic4you.com">chris@thematic4you.com</a>&gt; wrote:<br>
&gt;&gt; &gt;&gt; Tickets #870 and #873<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Von: <a
href="mailto:theme-reviewers-bounces@lists.wordpress.org">theme-reviewers-bounces@lists.wordpress.org</a><br>
&gt;&gt; &gt;&gt; [mailto:<a
href="mailto:theme-reviewers-bounces@lists.wordpress.org">theme-reviewers-bounces@lists.wordpress.org</a>]
Im Auftrag von<br>
&gt;&gt; &gt;&gt; Edward<br>
&gt;&gt; &gt;&gt; Caissie<br>
&gt;&gt; &gt;&gt; Gesendet: Freitag, 3. September 2010 14:47<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; An: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
&gt;&gt; &gt;&gt; Betreff: Re: [theme-reviewers] Emergency Call<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; SVN is a forever land ... without intervention by a
&quot;System Admin&quot; as<br>
&gt;&gt; &gt;&gt; far as<br>
&gt;&gt; &gt;&gt; I know.<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; We can keep it out of Extend/Themes easy enough but beyond
that we do<br>
&gt;&gt; &gt;&gt; not<br>
&gt;&gt; &gt;&gt; have much control.<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; What tickets/themes are you refering to?<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Cais.<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; On Fri, Sep 3, 2010 at 7:08 AM, Chris &lt;<a
href="mailto:chris@thematic4you.com">chris@thematic4you.com</a>&gt; wrote:<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Indeed .. infecting all installed themes of a blog.<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Von: <a
href="mailto:theme-reviewers-bounces@lists.wordpress.org">theme-reviewers-bounces@lists.wordpress.org</a><br>
&gt;&gt; &gt;&gt; [mailto:<a
href="mailto:theme-reviewers-bounces@lists.wordpress.org">theme-reviewers-bounces@lists.wordpress.org</a>]
Im Auftrag von<br>
&gt;&gt; &gt;&gt; Philip<br>
&gt;&gt; &gt;&gt; M. Hofer (Frumph)<br>
&gt;&gt; &gt;&gt; Gesendet: Freitag, 3. September 2010 13:00<br>
&gt;&gt; &gt;&gt; An: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
&gt;&gt; &gt;&gt; Betreff: Re: [theme-reviewers] Emergency Call<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Oh fricken lovely.<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; ----- Original Message -----<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; From: Chris<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; To: <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Sent: Friday, September 03, 2010 3:55 AM<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Subject: [theme-reviewers] Emergency Call<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Hi,<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; who
is able to remove / delete / nuke two themes from the<br>
&gt;&gt; &gt;&gt; SVN??<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Who
is in charge of the the scripts running right after<br>
&gt;&gt; &gt;&gt; theme<br>
&gt;&gt; &gt;&gt; upload??<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Had an encounter with not so clean themes .. the themes are
rejected,<br>
&gt;&gt; &gt;&gt; but<br>
&gt;&gt; &gt;&gt; need to be removed from the SVN as soon as possible.<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; In addition I would like to see the upload script filtering
for a not<br>
&gt;&gt; &gt;&gt; so<br>
&gt;&gt; &gt;&gt; nice wormy gift.<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Thanks,<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; Chris<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; ________________________________<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; _______________________________________________<br>
&gt;&gt; &gt;&gt; theme-reviewers mailing list<br>
&gt;&gt; &gt;&gt; <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
&gt;&gt; &gt;&gt; <a
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; _______________________________________________<br>
&gt;&gt; &gt;&gt; theme-reviewers mailing list<br>
&gt;&gt; &gt;&gt; <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
&gt;&gt; &gt;&gt; <a
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt; _______________________________________________<br>
&gt;&gt; &gt;&gt; theme-reviewers mailing list<br>
&gt;&gt; &gt;&gt; <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
&gt;&gt; &gt;&gt; <a
href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;&gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; _______________________________________________<br>
&gt;&gt; theme-reviewers mailing list<br>
&gt;&gt; <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
&gt;&gt; <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
&gt;<br>
&gt;<br>
&gt; _______________________________________________<br>
&gt; theme-reviewers mailing list<br>
&gt; <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
&gt; <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
&gt;<br>
&gt;<br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers"
target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><o:p></o:p></p>

</div>

</div>

</div>

<p class=MsoNormal><o:p>&nbsp;</o:p></p>

</div>

</div>

</div>

</body>

</html>