The idea looks feasible for using Post-Thumbnail but I can also see it as having the potential to have two different images representative of the post whereas the custom fields would support the second image. The author is suggesting the theme is testing for the custom field <featuredimage - image_URL> key-pair ... which may conflict with testing for an existing Featured Image provided via post_thumbnail.<br>
<br>Technically speaking both could be used on a post and both images could be different ... or the same. That would be at the end-user's discretion.<br><br><br>Cais.<br><br>PS: I did not look at the code to see if post_thumbnial is being implemented already. EAC<br>
<br><br><div class="gmail_quote">On Thu, Sep 2, 2010 at 12:21 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
The Theme developer is also using custom fields for "Featured Images", rather than supporting Post Thumbnails.<div><br></div><div>Here are the instructions:</div><blockquote style="margin: 0pt 0pt 0pt 40px; border: medium none; padding: 0px;">
<div><span style="font-family: Verdana,Arial,Helvetica,sans-serif; font-size: 12px; color: rgb(85, 85, 85); line-height: 21px;"><p style="margin: 1.8em 0px 5px;">
<b>How do I add the featured thumbnails to the sidebar gallery?</b><br>You can select 8 posts to be featured. For each post,</p><ol><li>Add the “Featured” category.</li><li>Add a custom field with<br>Name = featuredimage<br>
Value = image url e.g <a href="http://yourdomain.com/image.jpg" target="_blank">http://yourdomain.com/image.jpg</a> (recommended: 75px by 75px)</li></ol></span></div></blockquote><div><br></div><div>Any reason this shouldn't be done using core Post Thumbnails feature?</div>
<div><br></div><div>Chip<br><br><div class="gmail_quote">On Thu, Sep 2, 2010 at 11:07 AM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com" target="_blank">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Making it a strongly recommended suggestion and providing the code is about all you can do ... but as its not a "specific" requirement, but one inferred from other criteria it is still at the authors discretion to use.<br>
<br>I would also suggest including your points in this thread with the comments to explain why what you are suggesting would be much better for the author and the theme end-users.<br><br><br>Cais.<br><br><div class="gmail_quote">
<div><div></div><div>
On Thu, Sep 2, 2010 at 12:02 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div></div><div>
<div class="gmail_quote"><div>On Thu, Sep 2, 2010 at 10:52 AM, Ryan Hellyer <span dir="ltr"><<a href="mailto:ryan@pixopoint.com" target="_blank">ryan@pixopoint.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>>> In this particular Theme, the documentation basically says, "A logo.psd<br>
>> and independence.ttf is included in the psd folder. Edit the psd file, save<br>
>> as logo.gif and upload to the images folder".<br>
<br>
>> At a minimum, it's a recommend with respect to Custom Image Header<br>
>> functionality. I'm leaning toward require.<br>
<br>
</div>Using a custom header like that then adds a "custom header" option in<br>
the admin panel, which the theme developer likely did not intend. So<br>
it should not be a requirement IMO.<br>
<font color="#888888"><br>
Ryan,</font></blockquote><div><br></div></div><div>It's a case-by-case consideration.</div><div><br></div><div>Take a look at the Theme in question: <a href="http://themereview.chipbennett.net" target="_blank">http://themereview.chipbennett.net</a></div>
<div><br></div><div>That "Food Recipe" is the header logo. The Theme gives instructions for how to change it. Thus, it would seem that the developer intends for it to be customizable.</div><div><br></div><div>So, I'm not so much concerned about whether or not the Theme developer "intended" for a "Custom Header" menu item to display in the users' back end, as I am concerned with whether or not the Theme developer intended for the header logo to be customizable.</div>
<div><br></div><div>Again, these are the instructions he gives:</div><div><br></div></div><div><blockquote style="margin: 0pt 0pt 0pt 40px; border: medium none; padding: 0px;"><div class="gmail_quote"><div>
<span style="font-family: Verdana,Arial,Helvetica,sans-serif; font-size: 12px; color: rgb(85, 85, 85); line-height: 21px;">A logo.psd and independence.ttf is included in the psd folder. Edit the psd file, save as logo.gif and upload to the images folder.</span></div>
</div></blockquote></div><div class="gmail_quote"><div><br></div><div>That implies to me that the logo is intended to be customizable. The core functionality vastly improves the user experience with respect to uploading customized logos.</div>
<div><br></div><div>All that it would take to implement the core feature would be:</div><div><br></div><div>1) include add_custom_image_header()</div><div>2) define the custom header image dimensions</div><div>3) define the default image</div>
<div><br></div><div>Easy peasy. In fact, I'm going to put the code into a comment on the ticket, to show how easy it would be to implement. </div><div><br></div><div>In the end, I don't see how this is all that much different from requiring wp_nav_menu() when a Theme is using wp_list_pages() as a navigation menu.</div>
<div><br></div><font color="#888888"><div>Chip</div></font></div>
<br></div></div><div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></div></blockquote></div><br>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>