Making it a strongly recommended suggestion and providing the code is about all you can do ... but as its not a "specific" requirement, but one inferred from other criteria it is still at the authors discretion to use.<br>
<br>I would also suggest including your points in this thread with the comments to explain why what you are suggesting would be much better for the author and the theme end-users.<br><br><br>Cais.<br><br><div class="gmail_quote">
On Thu, Sep 2, 2010 at 12:02 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="gmail_quote"><div class="im">On Thu, Sep 2, 2010 at 10:52 AM, Ryan Hellyer <span dir="ltr"><<a href="mailto:ryan@pixopoint.com" target="_blank">ryan@pixopoint.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>>> In this particular Theme, the documentation basically says, "A logo.psd<br>
>> and independence.ttf is included in the psd folder. Edit the psd file, save<br>
>> as logo.gif and upload to the images folder".<br>
<br>
>> At a minimum, it's a recommend with respect to Custom Image Header<br>
>> functionality. I'm leaning toward require.<br>
<br>
</div>Using a custom header like that then adds a "custom header" option in<br>
the admin panel, which the theme developer likely did not intend. So<br>
it should not be a requirement IMO.<br>
<font color="#888888"><br>
Ryan,</font></blockquote><div><br></div></div><div>It's a case-by-case consideration.</div><div><br></div><div>Take a look at the Theme in question: <a href="http://themereview.chipbennett.net" target="_blank">http://themereview.chipbennett.net</a></div>
<div><br></div><div>That "Food Recipe" is the header logo. The Theme gives instructions for how to change it. Thus, it would seem that the developer intends for it to be customizable.</div><div><br></div><div>So, I'm not so much concerned about whether or not the Theme developer "intended" for a "Custom Header" menu item to display in the users' back end, as I am concerned with whether or not the Theme developer intended for the header logo to be customizable.</div>
<div><br></div><div>Again, these are the instructions he gives:</div><div><br></div></div><div class="im"><blockquote style="margin: 0pt 0pt 0pt 40px; border: medium none; padding: 0px;"><div class="gmail_quote"><div>
<span style="font-family: Verdana,Arial,Helvetica,sans-serif; font-size: 12px; color: rgb(85, 85, 85); line-height: 21px;">A logo.psd and independence.ttf is included in the psd folder. Edit the psd file, save as logo.gif and upload to the images folder.</span></div>
</div></blockquote></div><div class="gmail_quote"><div><br></div><div>That implies to me that the logo is intended to be customizable. The core functionality vastly improves the user experience with respect to uploading customized logos.</div>
<div><br></div><div>All that it would take to implement the core feature would be:</div><div><br></div><div>1) include add_custom_image_header()</div><div>2) define the custom header image dimensions</div><div>3) define the default image</div>
<div><br></div><div>Easy peasy. In fact, I'm going to put the code into a comment on the ticket, to show how easy it would be to implement. </div><div><br></div><div>In the end, I don't see how this is all that much different from requiring wp_nav_menu() when a Theme is using wp_list_pages() as a navigation menu.</div>
<div><br></div><font color="#888888"><div>Chip</div></font></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>