I agree with Phil on this given the example below ... and with never supporting the Customer Header Image function as required, too.<br><br>My concern (without looking at the theme), does the logo act as an advertisement for the theme author? It starts to get really grey if it does ...<br>
<br><br>Cais.<br><br>PS: As one of my themes has three major CSS based image areas in the header, until Custom Header Image (or whatever its called) supports multiple instances in the header via core it will remain as recommended IMO. EAC.<br>
<br><div class="gmail_quote">On Thu, Sep 2, 2010 at 11:31 AM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net">philip@frumph.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div bgcolor="#ffffff">
<div><pre> <div class="logo">
<a href="<?php bloginfo('url') ?>"><img src="<?php bloginfo('template_url') ?>/images/logo.gif" alt="logo" /></a>
<div class="description"><?php bloginfo('description'); ?></div>
</pre><pre>Yeah he hardcodes it, this is one that is 'strongly' recommended to switch to either CSS or custom-header</pre><pre>- Phil</pre></div>
<blockquote style="border-left: 2px solid rgb(0, 0, 0); padding-left: 5px; padding-right: 0px; margin-left: 5px; margin-right: 0px;"><div class="im">
<div style="font: 10pt arial;">----- Original Message ----- </div>
<div style="font: 10pt arial; background: none repeat scroll 0% 0% rgb(228, 228, 228);"><b>From:</b>
<a title="chip@chipbennett.net" href="mailto:chip@chipbennett.net" target="_blank">Chip
Bennett</a> </div>
<div style="font: 10pt arial;"><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
</div>
</div><div><div></div><div class="h5"><div style="font: 10pt arial;"><b>Sent:</b> Thursday, September 02, 2010 8:27
AM</div>
<div style="font: 10pt arial;"><b>Subject:</b> Re: [theme-reviewers] Themes
With Customizable Logos</div>
<div><br></div>Still working on the review. Ticket is <a href="https://themes.trac.wordpress.org/ticket/915" target="_blank">#915</a>.
<div><br></div>
<div>I actually use the core functionality to update the header image, that is
applied via CSS.
<div><br></div>
<div>Basically, I use the core functionality as a nice UX
upload-preview-change tool. The image itself gets applied as a CSS background.
:)</div>
<div><br></div>
<div>Chip</div>
<div><br>
<div class="gmail_quote">On Thu, Sep 2, 2010 at 10:22 AM, Philip M. Hofer
(Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>></span> wrote:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left: 1ex;" class="gmail_quote">
<div bgcolor="#ffffff">
<div><font size="2" face="Arial">Yes, that can be done definately in a better
way and the custom-header would be a good route, got a ticket # ? anyways,
look at the header.php if its a hardcoded image that absofricken
lutely</font></div>
<div><font size="2" face="Arial"></font> </div>
<div><font size="2" face="Arial">Personally I *hate* the custom-header code.,
Literally. Easier and more control with your own CSS.</font></div>
<div><font size="2" face="Arial"></font> </div>
<div><font size="2" face="Arial">- Phil</font></div>
<div><font size="2" face="Arial"></font> </div>
<div><font size="2" face="Arial">heh, i'm *never* going to support
custom-header, so guess i'm out of the repository; as I said CSS of your own
is a much more controlled route, what I did with CP is I made it an option
to use it or not in the addons - theme options to use or not ;/</font></div>
<div><font size="2" face="Arial"></font> </div>
<blockquote style="border-left: 2px solid rgb(0, 0, 0); padding-left: 5px; padding-right: 0px; margin-left: 5px; margin-right: 0px;">
<div>
<div style="font: 10pt arial;">----- Original Message ----- </div>
<div style="font: 10pt arial; background: none repeat scroll 0% 0% rgb(228, 228, 228);"><b>From:</b> <a title="chip@chipbennett.net" href="mailto:chip@chipbennett.net" target="_blank">Chip Bennett</a> </div>
<div style="font: 10pt arial;"><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a> </div></div>
<div>
<div></div>
<div>
<div style="font: 10pt arial;"><b>Sent:</b> Thursday, September 02, 2010
8:12 AM</div>
<div style="font: 10pt arial;"><b>Subject:</b> Re: [theme-reviewers] Themes
With Customizable Logos</div>
<div><br></div>In this particular Theme, the documentation basically says,
"<span style="line-height: 21px; font-family: Verdana,Arial,Helvetica,sans-serif; color: rgb(85, 85, 85); font-size: 12px;">A
logo.psd and independence.ttf is included in the psd folder. Edit the psd
file, save as logo.gif and upload to the images folder</span>".
<div><br></div>
<div>At a minimum, it's a <b>recommend </b>with respect to Custom Image
Header functionality. I'm leaning toward <b>require</b>.</div>
<div><br></div>
<div>Chip<br><br>
<div class="gmail_quote">On Thu, Sep 2, 2010 at 10:09 AM, Philip M. Hofer
(Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net" target="_blank">philip@frumph.net</a>></span> wrote:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0px 0px 0px 0.8ex; padding-left: 1ex;" class="gmail_quote">
<div bgcolor="#ffffff">
<div><font size="2" face="Arial">If it's based in CSS I would think not, if
its an <img then I would say absolutely. CSS is very easy to
manipulate, while editing core files should make it so that it would be
the responsible thing a theme developer should provide the custom-header
instead of hardcoding.</font></div>
<div><font size="2" face="Arial"></font> </div>
<div><font size="2" face="Arial">- Phil</font></div>
<blockquote style="border-left: 2px solid rgb(0, 0, 0); padding-left: 5px; padding-right: 0px; margin-left: 5px; margin-right: 0px;">
<div>
<div></div>
<div>
<div style="font: 10pt arial;">----- Original Message ----- </div>
<div style="font: 10pt arial; background: none repeat scroll 0% 0% rgb(228, 228, 228);"><b>From:</b> <a title="chip@chipbennett.net" href="mailto:chip@chipbennett.net" target="_blank">Chip Bennett</a> </div>
<div style="font: 10pt arial;"><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a> </div>
<div style="font: 10pt arial;"><b>Sent:</b> Thursday, September 02,
2010 8:06 AM</div>
<div style="font: 10pt arial;"><b>Subject:</b> [theme-reviewers] Themes
With Customizable Logos</div>
<div><br></div>For Themes that have header logos that are
customizable, should we be requiring that implementation to support
the core Custom Header Image functionality?
<div><br></div>
<div>Reference this wording from the Guidelines:</div>
<div><br></div>
<blockquote style="border: medium none; padding: 0px; margin: 0px 0px 0px 40px;">
<div><span style="line-height: 22px; font-family: 'Lucida Grande',Verdana,'Bitstream Vera Sans',Arial,sans-serif; font-size: 12px;">Theme
is <b style="text-align: left ! important; font-variant: normal ! important;">recommended</b> to
incorporate the following WordPress core functionality, but
is <i style="text-align: left ! important; font-variant: normal ! important;">not
required</i> to do so. However, if incorporated, functionality
must support the core WordPress
implementation:</span></div></blockquote>
<blockquote style="border: medium none; padding: 0px; margin: 0px 0px 0px 40px;">
<blockquote style="border: medium none; padding: 0px; margin: 0px 0px 0px 40px;">
<div><span style="line-height: 22px; font-family: 'Lucida Grande',Verdana,'Bitstream Vera Sans',Arial,sans-serif; font-size: 12px;">...</span></div></blockquote></blockquote>
<blockquote style="border: medium none; padding: 0px; margin: 0px 0px 0px 40px;">
<blockquote style="border: medium none; padding: 0px; margin: 0px 0px 0px 40px;">
<div><font size="3" face="'Lucida Grande', Verdana, 'Bitstream Vera Sans', Arial, sans-serif"><span style="line-height: 22px; font-size: 12px;">Custom
Header:</span></font></div>
<div><font size="3" face="'Lucida Grande', Verdana, 'Bitstream Vera Sans', Arial, sans-serif"><span style="line-height: 22px; font-size: 12px;">...</span></font></div></blockquote></blockquote>
<div><br></div>
<div>Thoughts?</div>
<div><br></div>
<div>Chip</div></div></div>
<p></p>
<hr>
<p></p>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<p></p></blockquote></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>
<p></p>
<hr>
<p></p>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<p></p></div></div></blockquote></div><br>_______________________________________________<br>theme-reviewers
mailing list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div></div>
<p>
</p><hr>
<p></p>_______________________________________________<br>theme-reviewers
mailing
list<br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div>
<br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>