<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=iso-8859-1" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18928">
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT size=2 face=Arial>While I agree that it should be a suggestion for
the notices/warnings/deprecated, I also come back to the conclusion that it's
not helping the developers either. On an occasion with my own
code I had a notice that made I should have assigned a particular variable an
arra array(), it turned more a string instead and when the posts started adding
up and user used that particular feature errors were abundant, which would have
been caught if I delt with the notice.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>Not only as Otto suggested should we help and
increase awareness we should also be informing of these situations and guide the
developer to using better practices in code developement, those better practices
will lead to better projects being made and fork into other areas like the
plugins they make and more.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>We're making progress of course with the review
system and i'm just throwing in my 2 cents here but it will do noone any good to
let too many things slide from the reviews.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>I would like to point all of you to: <A
href="http://themes.trac.wordpress.org/ticket/841">http://themes.trac.wordpress.org/ticket/841</A></FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>If Otto has his way and just lets 'everything'
slide, that theme would be on the repository right now.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>I am completely against the idea.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>This crusade he is on makes me believe if someone
puts up enough grief people will shove away good things to qualm them.
</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>Instead of focusing on the requirements we should
be focusing on how to educate in the theme review process as well. I
have brought several idea's to the table that need to be discussed which would
be more beneficial to everyone that also keeps the review system
intact.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>Furthermore, Otto needs to review themes with the
current theme process, new themes to the repository. His stance on
the subject states that if it can't be done his way then it shouldn't be
done at all. </FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>@Otto Noone likes change champ and I will not sit
idly by while your judicially make a good thing corrupted to your point of
view. You do have some valid points with education to the developers and
we are discussing things but requiring the theme review team do increase its
work flow on an already slow system is asking too much and focusing on the wrong
area to educate. Use the codex, provide documentation to educate;
that's what it's there for.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="FONT: 10pt arial; BACKGROUND: #e4e4e4; font-color: black"><B>From:</B>
<A title=wp@andrewnacin.com href="mailto:wp@andrewnacin.com">Andrew Nacin</A>
</DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A
title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
</DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Thursday, August 26, 2010 3:37
AM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [theme-reviewers] Theme
Review Feedback at WPTavern Forum</DIV>
<DIV><BR></DIV><SPAN
style="BORDER-COLLAPSE: collapse; FONT-FAMILY: arial, sans-serif; FONT-SIZE: 13px"
class=Apple-style-span><SPAN
style="BORDER-COLLAPSE: separate; FONT-FAMILY: arial; FONT-SIZE: small"
class=Apple-style-span><SPAN style="FONT-FAMILY: arial"
class=Apple-style-span>On Wed, Aug 25, 2010 at 5:21 AM, Otto <SPAN
dir=ltr><<A
href="mailto:otto@ottodestruct.com">otto@ottodestruct.com</A>></SPAN> wrote:<BR></SPAN>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>We don't need high quality code or high quality
themes.</BLOCKQUOTE>
<DIV> </DIV>On Wed, Aug 25, 2010 at 8:27 AM, Chip Bennett <SPAN
dir=ltr><<A
href="mailto:chip@chipbennett.net">chip@chipbennett.net</A>></SPAN> wrote:</SPAN></SPAN>
<DIV>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>Most are failing for the basics: errors output by
WP_DEBUG, invalid HTML/CSS, no wp_head() or wp_footer(), etc.</BLOCKQUOTE>
<DIV><SPAN style="FONT-SIZE: 13px" class=Apple-style-span></SPAN><FONT
class=Apple-style-span face="arial, sans-serif"><SPAN
style="BORDER-COLLAPSE: collapse" class=Apple-style-span><SPAN
style="BORDER-COLLAPSE: separate"
class=Apple-style-span><BR></SPAN></SPAN></FONT></DIV>
<DIV><FONT class=Apple-style-span face="arial, sans-serif">Most plugins and
themes output errors on WP_DEBUG. Including/especially commercial themes and
the top plugins. Even though the use of notices or deprecated functions is NOT
indicative of poor quality code, the simple fact is that very few of them do
have quality code. A sad few.</FONT></DIV>
<DIV><FONT class=Apple-style-span face="arial, sans-serif"><BR></FONT></DIV>
<DIV><FONT class=Apple-style-span face="arial, sans-serif">Akismet is quality
code, yet it triggers them. So does core, on occasion. (Just visit plugins.php
when running multisite, for example. And before 3.0, try using the QuickPress
module -- yuck.)</FONT></DIV>
<DIV><FONT class=Apple-style-span face="arial, sans-serif"><BR></FONT></DIV>
<DIV><FONT class=Apple-style-span face="arial, sans-serif">I love WP_DEBUG. I
wrote an entire plugin (that most of you use) to record deprecated calls, I've
written blog posts on debugging WordPress, and I cringe like the rest of you
when a theme or plugin spits out errors. I've briefly looked through the theme
review process. At first I loved that themes were getting a review all the way
down to the notices, but I've since had some second thoughts. Rejecting a
theme purely for notices or deprecated functions is a bad, bad idea, and is
not the intent I had when I wrote a plugin devoted to catching
them.</FONT></DIV>
<DIV><FONT class=Apple-style-span face="arial, sans-serif"><BR></FONT></DIV>
<DIV><FONT class=Apple-style-span face="arial, sans-serif">Realistically,
quality and education are our priorities. We cannot fail at education, or
quality will suffer if only because quantity will as well. I see no problem
with a theme being approved with notices/deprecated calls, if that's the only
thing wrong with it.</FONT></DIV></DIV>
<DIV><FONT class=Apple-style-span face="arial, sans-serif"><BR></FONT>
<DIV><FONT class=Apple-style-span face="arial, sans-serif">I believe Otto is
spot on when it comes to the current deficiencies, and I do hope they are
addressed.</FONT></DIV></DIV>
<P>
<HR>
<P></P>_______________________________________________<BR>theme-reviewers
mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></BLOCKQUOTE></BODY></HTML>