The new resolution "needs additional review" has been added.<br><br><br>Cais.<br><br><div class="gmail_quote">On Tue, Aug 24, 2010 at 4:01 PM, Edward Caissie <span dir="ltr"><<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">We seem to be coming across more "additional review required" themes lately; it can be scripting issues, security issues, or spaghetti ... all should be addressed appropriately.<br>
<br>Let's continue with if a theme has an issue the reviewer is not willing to accept, but does not feel comfortable denying then a (sepearate) comment to that effect should be added to the end of the regular review comment(s). The theme can be resolved "not-accepted". I read through the comments of the ticket before I address the theme in Extend.<br>
<br>I will also put forward a request for a new resolution option of "needs additional review" to help identify these themes.<br><br><br>Cais.<br><br><div class="gmail_quote"><div><div></div><div class="h5">On Tue, Aug 24, 2010 at 3:26 PM, Chip Bennett <span dir="ltr"><<a href="mailto:chip@chipbennett.net" target="_blank">chip@chipbennett.net</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div></div><div class="h5">Another Theme downloaded, only to fail one of the first things I checked...<div>
<br></div><div>
Anyway, while I move on to the next Theme, another couple questions for the group:</div><div><br></div><div>1) JavaScript/jQuery</div>
<div><br></div><div>How does everyone evaluate JS (and, I suppose, jQuery) code in Themes? What tools do you use to find errors, and what criteria do you use?</div><div><br></div><div>I used to write quite a bit in JS many, many years ago - though I would never say that I was good (or even proficient) at it. My knowledge of jQuery is non-existent. So, are there tools you can recommend to use, or good, WordPress-specific resources to study? Or, are there any reviewers who might want to take on a JS/jQuery guru role, to review Themes with complex use of such scripts?</div>
<div><br></div><div>2) Security Reviews</div><div><br></div><div>Whatever happened to our idea of having Security gurus, who would perform security reviews after Themes passed the Theme Review Checklist? Is that still something we want to pursue? Are we to the point where Themes are getting turned around fast enough to justify adding an additional step in the workflow?</div>
<div><br></div><div>(If so, Cais: can we get a "needs security review" or similar option in Trac to which to resolve a Theme that otherwise conforms to the Theme Review guidelines?)</div><div><br></div><div>Back to the grind...</div>
<div><br></div><font color="#888888"><div>Chip</div>
</font><br></div></div>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br>
</blockquote></div><br>