This is all true ... perhaps some wording to effect that translation text-domain should be obviously theme related.<br><br><br>Cais.<br><br><div class="gmail_quote">On Thu, Aug 12, 2010 at 9:11 PM, Safirul Alredha <span dir="ltr"><zeo@zeo.my></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">I would failed this because:<br>
<br>
1) The theme author probably copy paste or based on i18n kubrick /<br>
default with style change or with some additional template. When this<br>
happen if there's any additional string, the new string obviously not<br>
included in POT file.<br>
2) text domain should be unique (I know there's somewhere in codex<br>
that stated this).<br>
3) There are some cases where the theme had 2 text domain as a result<br>
from copy paste or based from 2 - 3 different theme.<br>
<br>
So if the theme author is serious about making the theme<br>
translation-ready, this is "important".<br>
<br>
On Thu, Aug 12, 2010 at 7:30 PM, Edward Caissie<br>
<div class="im"><<a href="mailto:edward.caissie@gmail.com">edward.caissie@gmail.com</a>> wrote:<br>
</div><div><div></div><div class="h5">> Changing the text domain is simply find and replace ... it should be<br>
> addressed if there are any other issues that cause the theme to be<br>
> "not-accepted", otherwise if all else is good then a notation to fix by the<br>
> next release would be fine.<br>
><br>
> Just my opinion on something easy to fix like that.<br>
><br>
><br>
> Cais<br>
><br>
> On Thu, Aug 12, 2010 at 3:02 AM, Philip M. Hofer (Frumph)<br>
> <<a href="mailto:philip@frumph.net">philip@frumph.net</a>> wrote:<br>
>><br>
>> heh it's all good, basically when i'm typing things into the box and you<br>
>> post something, it then fails letting me post the review ;/ havent had that<br>
>> happen before so it messed with me, oh yeah I know about the text-domain but<br>
>> it's not a must-change since the main core theme doesnt use kubrik anywhere<br>
>> (anymore) so that wouldn't fail the theme's review, just notation for<br>
>> suggestion of replacing imo.<br>
>><br>
>> - Phil<br>
>><br>
>> ----- Original Message ----- From: "Safirul Alredha" <zeo@zeo.my><br>
>> To: <<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a>><br>
>> Sent: Wednesday, August 11, 2010 11:48 PM<br>
>> Subject: [theme-reviewers] Nevermind<br>
>><br>
>><br>
>> :-P<br>
>><br>
>> My bad. Sorry about that. I was picking the simplest theme in queue to<br>
>> review (now that there's less BP theme on top). Forgot to assign to<br>
>> myself.<br>
>><br>
>> On Thu, Aug 12, 2010 at 2:39 PM, Philip M. Hofer (Frumph)<br>
>> <<a href="mailto:philip@frumph.net">philip@frumph.net</a>> wrote:<br>
>>><br>
>>> It appears Zeo jumped on my assigned ticket, it's all good. They just<br>
>>> need<br>
>>> to make sure not to snag an assigned ticket.<br>
>>><br>
>>> - Phil<br>
>>> _______________________________________________<br>
>>> theme-reviewers mailing list<br>
>>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>>><br>
>>><br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
><br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br>