Phil,<br><ol><li>I did check the last theme that was approved - ComicPress. When activated the screenshot is very different from what you see in screenshot.png. Obviously different standards are being applied to different themes.<br>
</li><li>If you search through the code, you will NOT see wp_nav_menu() being used anywhere. Only the existence of the function is being checked - the function itself is not being used. What do you want me to register?</li>
<li>Read my email carefully. I said the review is not thorough and I didn't suggest you are testers. I understand you are in testing overdrive, but your comments come off sounding pedantic at the least.<br></li></ol>Sayontan.<br>
<br><div class="gmail_quote">On Mon, Aug 9, 2010 at 10:10 AM, Philip M. Hofer (Frumph) <span dir="ltr"><<a href="mailto:philip@frumph.net">philip@frumph.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div bgcolor="#ffffff">
<div><font face="Arial" size="2">1) If the screenshot.png does not look like what
the end user see's when activating the theme, the screenshot.png is
invalid.</font></div>
<div><font face="Arial" size="2"></font> </div>
<div><font face="Arial" size="2">2) However if you USE wp_nav_menu(); then you MUST
register it., you use it, register it.</font></div>
<div><font face="Arial" size="2"></font> </div>
<div><font face="Arial" size="2">3) Line 288 in actions.php is not wrapped around
conditional <!-- if statements which should be used as an
enqueue</font></div>
<div><font face="Arial" size="2"></font> </div>
<div><font face="Arial" size="2">4) We're not your theme testers, we're reviewers,
test your theme before submitting.</font></div>
<div><font face="Arial" size="2"></font> </div>
<div><font face="Arial" size="2">- Phil</font></div>
<blockquote style="border-left: 2px solid rgb(0, 0, 0); padding-left: 5px; padding-right: 0px; margin-left: 5px; margin-right: 0px;"><div><div></div><div class="h5">
<div style="font: 10pt arial;">----- Original Message ----- </div>
<div style="font: 10pt arial; background: none repeat scroll 0% 0% rgb(228, 228, 228);"><b>From:</b>
<a title="sayontan@gmail.com" href="mailto:sayontan@gmail.com" target="_blank">Sayontan
Sinha</a> </div>
<div style="font: 10pt arial;"><b>To:</b> <a title="theme-reviewers@lists.wordpress.org" href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>
</div>
<div style="font: 10pt arial;"><b>Sent:</b> Monday, August 09, 2010 9:54
AM</div>
<div style="font: 10pt arial;"><b>Subject:</b> Re: [theme-reviewers] [WordPress
Themes] Suffusion,new version 3.6.2</div>
<div><br></div>Hello,<br>I have been following the feedback posted for this
version of the theme and I believe the review is inaccurate and not thorough.
Here is what was posted:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote">
<ol>
<li><span style="text-transform: none; text-indent: 0px; border-collapse: separate; font: medium 'Times New Roman'; white-space: normal; letter-spacing: normal; color: rgb(0, 0, 0); word-spacing: 0px;"><span style="font-family: Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif; font-size: 13px;">
<p>screenshot.png does not look like the theme's output.</p></span></span>
</li><li><span style="text-transform: none; text-indent: 0px; border-collapse: separate; font: medium 'Times New Roman'; white-space: normal; letter-spacing: normal; color: rgb(0, 0, 0); word-spacing: 0px;"><span style="font-family: Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif; font-size: 13px;">
<p>wp_nav_menu(); being used but registration of available locations not
being set</p></span></span>
</li><li><span style="text-transform: none; text-indent: 0px; border-collapse: separate; font: medium 'Times New Roman'; white-space: normal; letter-spacing: normal; color: rgb(0, 0, 0); word-spacing: 0px;"><span style="font-family: Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif; font-size: 13px;">
<p>all scripts and styles should be enqueued ref: actions.php line 288,
line 427-429 suffusion-options-page.php and various other locations,
unless otherwise inapplicable to make the code work properly, i.e. <!--
IF statements</p></span></span></li></ol></blockquote>Point #1 is incorrect.
You get that with the Magazine template (bundled with the theme, Templates
-> Magazine in the options page) and the Minima skin (Visual Effects ->
Theme Selection, WITHOUT changing any code.<br><br>Point #2: The use of
wp_nav_menu() is recommended, not mandatory, as per the Theme Review
checklist:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote">
<p>Themes are strongly suggested to support the following customization
features: </p>
<ul>
<li>Custom Menu - <tt><a title="Function Reference/wp nav menu" href="http://codex.wordpress.org/Function_Reference/wp_nav_menu" target="_blank">wp_nav_menu()</a></tt>
<ul>
<li>If a navigation menu is part of the Theme's design, it should be a
customizable menu. For Themes that do not have a navigation menu, users
should be able to add a Custom Menu widget.
</li></ul></li></ul></blockquote>If you define a custom WP 3.0 menu you can
include it in the navigation bars from the settings in Blog Features ->
Main Navigation Bar Setup or Blog Features -> Top Navigation Bar Setup. If
you do not define a native WP menu you can still build your menus from the
Navigation bar Setup pages in the options. I don't see how this is grounds for
rejection.<br><br>Point #3: The scripts and styles are enqueued where
applicable. The line #288 in actions.php that has been listed is a conditional
include, and the lines 427-429 in suffusion-options-page.php are for scripts
in the admin page, not in the theme itself. The stylesheets cannot be enqueued
because there is a custom-styles.php file that is printed out, and enqueuing
destroys the sequence for that.<br><br>IMHO, the review is not thorough
enough.<br><br>Sayontan.<br><br>
<div class="gmail_quote">On Sat, Aug 7, 2010 at 10:26 AM, <span dir="ltr"><<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a>></span>
wrote:<br>
<blockquote style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;" class="gmail_quote">Thank you for uploading version 3.6.2 of
Suffusion.<br><br>Feedback will be provided at <a href="http://themes.trac.wordpress.org/ticket/604" target="_blank">http://themes.trac.wordpress.org/ticket/604</a><br><font color="#888888"><br>--<br>The WordPress.org Themes Team<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br></font></blockquote></div><br><br clear="all"><br>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br>Lake
Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name
for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I
fish on my side; nobody fish in the middle."<br>
</div></div><p>
</p><hr>
<p></p>_______________________________________________<br>theme-reviewers
mailing
list<div class="im"><br><a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br></div><a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</blockquote></div>
</blockquote></div><br><br clear="all"><br>-- <br>Sayontan Sinha<br><a href="http://mynethome.net">http://mynethome.net</a> | <a href="http://mynethome.net/blog">http://mynethome.net/blog</a><br>--<br>Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I fish on my side; nobody fish in the middle."<br>