Simon,<div>I have no idea what your comments mean. They give me no indication of what you are asking me to fix.<br><ol><li>Your comment states <br>"Please review the theme with the test data found in the Theme
Development Checklist (TDC); and with <strong>define('WP_DEBUG', true);</strong>
included in wp-config.php<br>
(NB: functions deprecated in 3.0 should be addressed but are not
show-stoppers at this time.)" <br>When I actually look at the log, ALL the points you have listed are debug "<u><b>notices</b></u>", not "<u><b>errors</b></u>" as you state, and they have no bearing on what shows up on a user's screen. Also, I hope you understand that running something with debug turned on will only present debug information at the best - not bonafide error information.<br>
</li><li>Also, the theme has been checked against the TDC multiple times and there is nothing on that list which the theme fails.</li><li>Coming to the individual "errors" you listed, I don't think you did a diff with the previous version. Of all the files you listed, I haven't touched most of them since the past 5-10 releases, if not more (e.g. theme-definitions.php, most of the files in the widgets folder etc). Hence if they are truly errors, none of the last several versions should have been approved.<br>
</li><li>Also, can you please do a proper review? Your comments seem to apply to version 3.5.3, while the version I submitted is version 3.5.4. A simple check. I am being showed a line in actions.php, line 1414 which apparently has an undefined variable called "ret". <br>
</li></ol>This theme review process is getting quite absurd. I am being provided comments for a version that is <b>already live (3.5.3) </b>and being told that it has innumerable errors (which are really debug notices that don't impact the theme), all while version 3.5.3 has had 15,000+ downloads so far that seem to be going fine for the users. Wonder how it got approved, then, in the first place?<br>
<br>Can someone please do a proper review and not just provide me with a list of debug notices? I understand that you guys have a backlog of reviews, but frankly, before the theme review experiment started (<a href="http://wordpress.org/development/2010/06/expanding-the-theme-review-experiment/">http://wordpress.org/development/2010/06/expanding-the-theme-review-experiment/</a>) reviews always seemed a much more streamlined and enjoyable process. The feedback I received from Joseph was timely, more precise and to the point, and always helped improve the theme, quite unlike the interminable delays and incomplete feedback that I am seeing now.<br>
<br>Sayontan.<br><br><div class="gmail_quote">On Fri, Jul 2, 2010 at 9:06 PM, Simon Prosser <span dir="ltr"><<a href="mailto:pross@pross.org.uk" target="_blank">pross@pross.org.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Feedback posted at <a href="http://themes.trac.wordpress.org/ticket/49" target="_blank">http://themes.trac.wordpress.org/ticket/49</a><br clear="all">
<font color="#888888"><br>-- <br>My Blog: <a href="http://www.pross.org.uk/" target="_blank">http://www.pross.org.uk/</a><br>Plugins : <a href="http://www.pross.org.uk/plugins/" target="_blank">http://www.pross.org.uk/plugins/</a><br>
Themes: <a href="http://wordpress.org/extend/themes/profile/pross" target="_blank">http://wordpress.org/extend/themes/profile/pross</a><br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br>Lake Chargoggagoggmanchauggagoggchaubunagungamaugg - 45-letter Native American name for Lake Webster, Webster, Massachusetts, meaning "You fish on your side; I fish on my side; nobody fish in the middle."<br>
</div>