[theme-reviewers] [WordPress Themes] #21261: THEME: NewsFrame - 2.3

[Edward R. Jenkins]

Thanks for the comments. I'll get these corrected next week.
On Oct 18, 2014 7:38 PM, "WordPress Themes" <noreply at wordpress.org> wrote:

> #21261: THEME: NewsFrame - 2.3
> ----------------------------+---------------------
> Reporter:  cardiganmedia    |       Owner:  Milmor
>     Type:  theme            |      Status:  closed
> Priority:  theme update     |  Resolution:  live
> Keywords:  theme-newsframe  |
> ----------------------------+---------------------
> Changes (by emiluzelac):
>
>  * status:  approved => closed
>  * resolution:   => live
>
>
> Comment:
>
>  Please fix the following:
>
>  - {{{esc_url(home_url())}}} is missing {{{/}}}.
>  - Theme loads {{{load_theme_textdomain( 'newsframe',
>  get_template_directory() . '/languages' );}}} but there is nothing in that
>  folder.
>  - Latest version does not use textdomain like you did for the rest of the
>  files {{{<?php _e ('Whoops. The page you were looking for has gone
>  extinct. Maybe you can find what you were looking for below.'); ?>}}}.
>  When author decides to localize, all parts should be included.
>  - Also https://themes.svn.wordpress.org/newsframe/2.3/inc/index-nav.php
>  uses unrelated textdomain {{{bartleby}}}.
>  - Themes must properly use dates: {{{get_option( 'date_format' )}}} and
>  {{{get_option( 'time_format' )}}}, unless an explicit design decision
>  requires use of a custom output for {{{the_date()}}} or {{{the_time()}}}.
>  ----
>  I will mark your theme live with the hope that mentioned issues are
>  corrected and submitted at your convenience.
>
>  Thanks!
>
> --
> Ticket URL: <https://themes.trac.wordpress.org/ticket/21261#comment:3>
> WordPress Themes <https://themes.trac.wordpress.org/>
> WordPress.org Theme Directory Reviews
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20141018/e5d602f6/attachment.html>