[theme-reviewers] Upgrading Masonry In Core

[Josh Pollock]

Otto- I understand what you are describing theoretically speaking but I
know slightly more than nothing about javascript and wouldn't know how to
accomplish this.

Rohit- You know how to do this, right?:)


On Sat, Nov 23, 2013 at 4:31 PM, Otto <otto at ottodestruct.com> wrote:

> On Sat, Nov 23, 2013 at 3:23 PM, Josh Pollock <jpollock412 at gmail.com>wrote:
>
>> Thanks for the feedback Otto, very valuable advice.
>>
>> Do you or anyone else have an example of what a backwards compatibility
>> wrapper look like that I can reference? Never had to do this before, but it
>> is going to be needed since there are a lot of changes in Masonry
>> parameters.
>>
>
>
> Absolutely no idea. Again, not a Javascript guru. :)
>
> I can tell you what it should look like from the perspective of somebody
> who is trying to *use* that masonry code. From the perspective of the theme
> developer, I should be able to use either Masonry 2 style parameters or the
> Masonry 3 style parameters and have the code just work. I should not have
> to make any notice of what version of the code is actually running.
>
> The point of backwards compatibility is for old-code to continue to work,
> without modification. Obviously, you want people to write code using the
> new way, but the old calls should still work as intended.
>
> Don't know how possible this is for this specific case. I know that
> javascript libraries can be modified by other javascript libraries... and
> that's about all I know. Presumably, if you could load masonry.js and then
> load in something else which modifies it to make the old parameters work
> too, or maybe which translates calls with the old parameters to the new
> ones, or something like that, then that's probably the way to go.
>
> -Otto
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20131123/9b3698e4/attachment-0001.html>