[theme-reviewers] Upgrading Masonry In Core

Josh Pollock jpollock412 at gmail.com
Sat Nov 23 21:23:06 UTC 2013


Thanks for the feedback Otto, very valuable advice.

Do you or anyone else have an example of what a backwards compatibility
wrapper look like that I can reference? Never had to do this before, but it
is going to be needed since there are a lot of changes in Masonry
parameters.


On Sat, Nov 23, 2013 at 4:18 PM, Otto <otto at ottodestruct.com> wrote:

> On Sat, Nov 23, 2013 at 2:36 PM, Josh Pollock <jpollock412 at gmail.com>wrote:
>
>> Would anyone's theme experience a similar issue? Probably. Is that a
>> valid objection to upgrading in core?
>>
>
> Probably.
>
> Is what nacin suggested about writing a back-compat wrapper possible? I'm
> not a javascript guru and I have no idea what the changes in masonry are.
> But if an add-on of some type can be made to fix compatibility breaks, then
> it's more likely to get in.
>
> The short end of it is that if at all possible, core upgrades cannot break
> people's websites. If somebody is using Masonry 2 and upgrading core to
> Masonry 3 will break that site, then Masonry 3 just ain't gonna go in. But
> if a "masonry-fix" script can be added to prevent that breakage, well, that
> will go over much better.
>
> -Otto
>
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20131123/2096f279/attachment.html>


More information about the theme-reviewers mailing list