[theme-reviewers] Theme author is asking end user to install less php

Doug Stewart zamoose at gmail.com
Sun Jul 7 04:39:03 UTC 2013


I seem to recall that the phpless stuff uses open() or similar and thus
wouldn't pass TRT muster.


On Sat, Jul 6, 2013 at 6:36 PM, Edward Caissie <edward.caissie at gmail.com>wrote:

> I bundle the LESS scripts in Opus Primus and then enqueue them
> appropriately ... but I am also considering removing that code and library
> altogether and merging the compiled LESS style sheet into the main theme
> style sheet (it's actually rather small in my case).
>
> Edward Caissie
> aka Cais.
>
>
> On Sat, Jul 6, 2013 at 3:58 PM, Simon Prosser <pross at pross.org.uk> wrote:
>
>> Why not just bundle less.php in your theme files? You'd have to slightly
>> edit it as it uses file get/put contents.
>>
>>
>> On 4 July 2013 19:05, Josh Pollock <jpollock412 at gmail.com> wrote:
>>
>>> @emil-
>>>
>>> That's neat, I didn't know Jetpack does that. Just took a look at it
>>> real quick, at least in Slim Jetpack it seems like it is a pretty
>>> minimal implementation.
>>>
>>> Of course this is all kind of academic as I lack the PHP chops to write
>>> said patch(s). I'm more wondering if it is remotely possible that it could
>>> be accepted and therefore worth thinking about ways to get this done.
>>>
>>>
>>>
>>> On Thu, Jul 4, 2013 at 9:17 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>>
>>>> Both LESS and Sass are available in WPCOM CSS Editor
>>>> http://en.support.wordpress.com/custom-design/editing-css/
>>>>
>>>> However as of last year, both Less and Sass are available
>>>> via Jetpack http://jetpack.me/2012/12/14/jetpack-2-0-3/
>>>> with that said, the argument needs to be pretty good to
>>>> get preprocessors in the core itself :)
>>>>
>>>> In my opinion whatever is in the Jetpack, will less likely
>>>> be included in the core, but it does not hurt to try.
>>>>
>>>> Emil
>>>>
>>>>
>>>> On Thu, Jul 4, 2013 at 7:52 PM, Josh Pollock <jpollock412 at gmail.com>wrote:
>>>>
>>>>> I'd make the case that if it were included it could enable theme and
>>>>> plugin developers to return option and theme mod values to SASS or LESS
>>>>> stylesheets. Among other cool things, I'm imagining in the customizer,
>>>>> instead of having a ton of color options, just setting a few options like
>>>>> primary, secondary, accent, etc. and then in my SASS/LESS file doing
>>>>> something like this:
>>>>>
>>>>> $colors = get_theme_mod('theme_options');
>>>>> $primary = $colors['primary'];
>>>>> $secondary = $colors['secondary'];
>>>>> $accent = $colors['accent'];
>>>>>
>>>>> I actually could do something similar to this with wpless, but not
>>>>> integrated with the customizer. That said, I don't want to make my theme
>>>>> dependent on a plugin that I can't be sure of long-term development and
>>>>> support for. Also, I'd rather use SASS instead of LESS.
>>>>>
>>>>> How's that argument? Not that I can back it with here's my patch...
>>>>>
>>>>>
>>>>> On Thu, Jul 4, 2013 at 8:33 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>>>>
>>>>>> No clue.
>>>>>>
>>>>>> Is it important enough to warrant someone arguing the case for
>>>>>> inclusion?
>>>>>>
>>>>>>
>>>>>> On Thu, Jul 4, 2013 at 8:31 PM, Josh Pollock <jpollock412 at gmail.com>wrote:
>>>>>>
>>>>>>> @Chip
>>>>>>>
>>>>>>> Do you think there is any chance of a LESS or SASS preprocesser
>>>>>>> getting accepted into core if it was submitted?
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Jul 4, 2013 at 7:12 PM, Chip Bennett <chip at chipbennett.net>wrote:
>>>>>>>
>>>>>>>> Perhaps a more ideal solution would be to submit a core
>>>>>>>> ticket/patch to get a preprocessor in core? That way, core, Plugins, and
>>>>>>>> Themes can rely on the core-bundled preprocessor.
>>>>>>>>
>>>>>>>> Until then, as Emil said: as long as the Theme works properly out
>>>>>>>> of the box, it's fine for Themes to ship with options/integration to
>>>>>>>> support a Plugin that adds a preprocessor.
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Jul 4, 2013 at 5:21 PM, Emil Uzelac <emil at uzelac.me> wrote:
>>>>>>>>
>>>>>>>>> *I meant*
>>>>>>>>>
>>>>>>>>> No need to rely or require WP-LESS*
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Jul 4, 2013 at 4:17 PM, Emil Uzelac <emil at uzelac.me>wrote:
>>>>>>>>>
>>>>>>>>>> If he ships the Theme with LESS as an additional (optional)
>>>>>>>>>> feature and the Theme
>>>>>>>>>> works out of the box as you and Chip mentioned, it's still good
>>>>>>>>>> to go and acceptable :)
>>>>>>>>>>
>>>>>>>>>> No need to rely or require on WP-LESS.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Thu, Jul 4, 2013 at 4:01 PM, Josh Pollock <
>>>>>>>>>> jpollock412 at gmail.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> @Divesh-
>>>>>>>>>>>
>>>>>>>>>>> If you ship your theme with processed and unprocessed code, as
>>>>>>>>>>> well as directions in your readme for using wpless with your theme then all
>>>>>>>>>>> of the requirements (theme review guidelines and yours) will be met. That
>>>>>>>>>>> way it works out of the box, but the end user knows you used wpless and how
>>>>>>>>>>> to use it to modify your theme.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Jul 4, 2013 at 4:06 PM, Emil Uzelac <emil at uzelac.me>wrote:
>>>>>>>>>>>
>>>>>>>>>>>> even though if there's an option and the Theme works
>>>>>>>>>>>> right without the preprocessors is not the reason to fail
>>>>>>>>>>>> a Theme
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Jul 4, 2013 at 3:02 PM, Amy Hendrix <sabreuse at gmail.com
>>>>>>>>>>>> > wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> I'd say that both Sass and LESS files should be accepted
>>>>>>>>>>>>> (because if
>>>>>>>>>>>>> you're a Sass or LESS user, it's far preferable to make any
>>>>>>>>>>>>> downstream
>>>>>>>>>>>>> changes to the original files) -- but the theme should be
>>>>>>>>>>>>> packaged
>>>>>>>>>>>>> with compiled css, and not depend on running any preprocessing
>>>>>>>>>>>>> live,
>>>>>>>>>>>>> whether it's directly on the server or by way of a WP plugin.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Emil, the tutorial you point to is about using preprocessors
>>>>>>>>>>>>> in your
>>>>>>>>>>>>> development environment and compiling out the finished css. The
>>>>>>>>>>>>> original question was about requiring libraries to compile it
>>>>>>>>>>>>> live on
>>>>>>>>>>>>> the server, which should not be approved IMO (and which is a
>>>>>>>>>>>>> terrible
>>>>>>>>>>>>> idea for preprocessing performance, but that's a debate that's
>>>>>>>>>>>>> way out
>>>>>>>>>>>>> of scope for this list!)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Personally, I love preprocessors; I think it's the way of the
>>>>>>>>>>>>> future
>>>>>>>>>>>>> and I maintain a library for working with Sass and _s. But
>>>>>>>>>>>>> asking
>>>>>>>>>>>>> users to install extra libraries just to be able to use a
>>>>>>>>>>>>> theme at all
>>>>>>>>>>>>> is _doing_it_wrong().
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Thu, Jul 4, 2013 at 3:51 PM, Emil Uzelac <emil at uzelac.me>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>> > Both Sass and LESS preprocessor should be accepted.
>>>>>>>>>>>>> > Not really sure if you need any extra PHP's for this.
>>>>>>>>>>>>> > Take a look at this brief tut.
>>>>>>>>>>>>> >
>>>>>>>>>>>>> >
>>>>>>>>>>>>> > On Thu, Jul 4, 2013 at 1:30 PM, Jose Castaneda <
>>>>>>>>>>>>> jomcastaneda at gmail.com>
>>>>>>>>>>>>> > wrote:
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >> The thing to remember about the WordPress theme repo is
>>>>>>>>>>>>> that not everybody
>>>>>>>>>>>>> >> that will use your theme is a developer. More often than
>>>>>>>>>>>>> not it is a person
>>>>>>>>>>>>> >> with little to no knowledge of web development or
>>>>>>>>>>>>> programming prowess. What
>>>>>>>>>>>>> >> I would do is include both the LESS files and the compiled
>>>>>>>>>>>>> CSS and leave a
>>>>>>>>>>>>> >> note on the readme file or put up some sort of notice.
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >> On Thu, Jul 4, 2013 at 7:54 AM, divesh kumar <
>>>>>>>>>>>>> diveshkumar1983 at gmail.com>
>>>>>>>>>>>>> >> wrote:
>>>>>>>>>>>>> >>>
>>>>>>>>>>>>> >>> hi greg
>>>>>>>>>>>>> >>>
>>>>>>>>>>>>> >>> but if i use compiled css it will be just a plain css and
>>>>>>>>>>>>> nobody would
>>>>>>>>>>>>> >>> get to know that its using lessphp.
>>>>>>>>>>>>> >>>
>>>>>>>>>>>>> >>> On Jul 4, 2013 5:15 PM, "Srikanth Koneru" <
>>>>>>>>>>>>> tskk79 at gmail.com> wrote:
>>>>>>>>>>>>> >>>>
>>>>>>>>>>>>> >>>> The basic theme must function without depending on any
>>>>>>>>>>>>> plugin. You can
>>>>>>>>>>>>> >>>> have additional features which can come live if
>>>>>>>>>>>>> plugins(that are required
>>>>>>>>>>>>> >>>> for those features) are activated.
>>>>>>>>>>>>> >>>> If lessphp framework is allowed in themes, you can bundle
>>>>>>>>>>>>> it with your
>>>>>>>>>>>>> >>>> theme itself.
>>>>>>>>>>>>> >>>>
>>>>>>>>>>>>> >>>>
>>>>>>>>>>>>> >>>> On Thu, Jul 4, 2013 at 4:52 PM, divesh kumar <
>>>>>>>>>>>>> diveshkumar1983 at gmail.com>
>>>>>>>>>>>>> >>>> wrote:
>>>>>>>>>>>>> >>>>>
>>>>>>>>>>>>> >>>>> Hi Kavita,
>>>>>>>>>>>>> >>>>>
>>>>>>>>>>>>> >>>>> Thanks for the reference. so that means user must
>>>>>>>>>>>>> install that plugin
>>>>>>>>>>>>> >>>>> in order to use my theme. Can i create any kind of
>>>>>>>>>>>>> dependency of my theme to
>>>>>>>>>>>>> >>>>> use this?
>>>>>>>>>>>>> >>>>>
>>>>>>>>>>>>> >>>>>
>>>>>>>>>>>>> >>>>>
>>>>>>>>>>>>> >>>>>
>>>>>>>>>>>>> >>>>> On Thu, Jul 4, 2013 at 4:26 PM, Kavita Kumawat <
>>>>>>>>>>>>> erkavecb at gmail.com>
>>>>>>>>>>>>> >>>>> wrote:
>>>>>>>>>>>>> >>>>>>
>>>>>>>>>>>>> >>>>>> you may want to check this.
>>>>>>>>>>>>> >>>>>>
>>>>>>>>>>>>> >>>>>> http://wordpress.org/plugins/wp-less/
>>>>>>>>>>>>> >>>>>>
>>>>>>>>>>>>> >>>>>> -Kavita
>>>>>>>>>>>>> >>>>>>
>>>>>>>>>>>>> >>>>>>
>>>>>>>>>>>>> >>>>>> On Thu, Jul 4, 2013 at 3:34 PM, divesh kumar
>>>>>>>>>>>>> >>>>>> <diveshkumar1983 at gmail.com> wrote:
>>>>>>>>>>>>> >>>>>>>
>>>>>>>>>>>>> >>>>>>> Guys,
>>>>>>>>>>>>> >>>>>>>
>>>>>>>>>>>>> >>>>>>> Does that means I cannot use SASS or any other CSS
>>>>>>>>>>>>> framework with
>>>>>>>>>>>>> >>>>>>> wordpress theme. I don't think this make sense.
>>>>>>>>>>>>> >>>>>>>
>>>>>>>>>>>>> >>>>>>> Thanks
>>>>>>>>>>>>> >>>>>>>
>>>>>>>>>>>>> >>>>>>>
>>>>>>>>>>>>> >>>>>>> On Thu, Jul 4, 2013 at 2:22 PM, Srikanth Koneru <
>>>>>>>>>>>>> tskk79 at gmail.com>
>>>>>>>>>>>>> >>>>>>> wrote:
>>>>>>>>>>>>> >>>>>>>>
>>>>>>>>>>>>> >>>>>>>> Themes should work out of the box.
>>>>>>>>>>>>> >>>>>>>>
>>>>>>>>>>>>> >>>>>>>>
>>>>>>>>>>>>> >>>>>>>> On Thu, Jul 4, 2013 at 2:19 PM, carolina poena
>>>>>>>>>>>>> >>>>>>>> <myazalea at hotmail.com> wrote:
>>>>>>>>>>>>> >>>>>>>>>
>>>>>>>>>>>>> >>>>>>>>> ticket:
>>>>>>>>>>>>> http://themes.trac.wordpress.org/ticket/12893
>>>>>>>>>>>>> >>>>>>>>> In readme:
>>>>>>>>>>>>> >>>>>>>>>
>>>>>>>>>>>>> >>>>>>>>> 1. Upload the `snAdaptive` folder to the
>>>>>>>>>>>>> `/wp-content/themes/`
>>>>>>>>>>>>> >>>>>>>>> directory
>>>>>>>>>>>>> >>>>>>>>> 2. Download lessphp framework from
>>>>>>>>>>>>> >>>>>>>>> http://leafo.net/lessphp/src/lessphp-0.3.9.tar.gz.
>>>>>>>>>>>>> >>>>>>>>> 3. Extract it in the directory
>>>>>>>>>>>>> themes/snAdaptive/lessphp.
>>>>>>>>>>>>> >>>>>>>>> 4. Make sure there is a file less.inc.php in
>>>>>>>>>>>>> directory
>>>>>>>>>>>>> >>>>>>>>> /themes/snAdaptive/lessphp/.
>>>>>>>>>>>>> >>>>>>>>> 5. Now you are ready to use the theme.
>>>>>>>>>>>>> >>>>>>>>>
>>>>>>>>>>>>> >>>>>>>>> The theme will not be approved eitherway but this is
>>>>>>>>>>>>> not ok right?
>>>>>>>>>>>>> >>>>>>>>> ^^
>>>>>>>>>>>>> >>>>>>>>>
>>>>>>>>>>>>> >>>>>>>>> //Carolina
>>>>>>>>>>>>> >>>>>>>>>
>>>>>>>>>>>>> >>>>>>>>>
>>>>>>>>>>>>> >>>>>>>>> _______________________________________________
>>>>>>>>>>>>> >>>>>>>>> theme-reviewers mailing list
>>>>>>>>>>>>> >>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>>> >>>>>>>>>
>>>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>> >>>>>>>>>
>>>>>>>>>>>>> >>>>>>>>
>>>>>>>>>>>>> >>>>>>>>
>>>>>>>>>>>>> >>>>>>>> _______________________________________________
>>>>>>>>>>>>> >>>>>>>> theme-reviewers mailing list
>>>>>>>>>>>>> >>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>>> >>>>>>>>
>>>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>> >>>>>>>>
>>>>>>>>>>>>> >>>>>>>
>>>>>>>>>>>>> >>>>>>>
>>>>>>>>>>>>> >>>>>>> _______________________________________________
>>>>>>>>>>>>> >>>>>>> theme-reviewers mailing list
>>>>>>>>>>>>> >>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>>> >>>>>>>
>>>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>> >>>>>>>
>>>>>>>>>>>>> >>>>>>
>>>>>>>>>>>>> >>>>>>
>>>>>>>>>>>>> >>>>>> _______________________________________________
>>>>>>>>>>>>> >>>>>> theme-reviewers mailing list
>>>>>>>>>>>>> >>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>>> >>>>>>
>>>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>> >>>>>>
>>>>>>>>>>>>> >>>>>
>>>>>>>>>>>>> >>>>>
>>>>>>>>>>>>> >>>>> _______________________________________________
>>>>>>>>>>>>> >>>>> theme-reviewers mailing list
>>>>>>>>>>>>> >>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>>> >>>>>
>>>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>> >>>>>
>>>>>>>>>>>>> >>>>
>>>>>>>>>>>>> >>>>
>>>>>>>>>>>>> >>>> _______________________________________________
>>>>>>>>>>>>> >>>> theme-reviewers mailing list
>>>>>>>>>>>>> >>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>>> >>>>
>>>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>> >>>>
>>>>>>>>>>>>> >>>
>>>>>>>>>>>>> >>> _______________________________________________
>>>>>>>>>>>>> >>> theme-reviewers mailing list
>>>>>>>>>>>>> >>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>>> >>>
>>>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>> >>>
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >> _______________________________________________
>>>>>>>>>>>>> >> theme-reviewers mailing list
>>>>>>>>>>>>> >> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>>> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >
>>>>>>>>>>>>> >
>>>>>>>>>>>>> > _______________________________________________
>>>>>>>>>>>>> > theme-reviewers mailing list
>>>>>>>>>>>>> > theme-reviewers at lists.wordpress.org
>>>>>>>>>>>>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>> >
>>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> _______________________________________________
>>>>>>>>>>> theme-reviewers mailing list
>>>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> theme-reviewers mailing list
>>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> theme-reviewers mailing list
>>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> theme-reviewers mailing list
>>>>>>> theme-reviewers at lists.wordpress.org
>>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> theme-reviewers mailing list
>>>>>> theme-reviewers at lists.wordpress.org
>>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>>
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> theme-reviewers mailing list
>>>>> theme-reviewers at lists.wordpress.org
>>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> theme-reviewers mailing list
>>>> theme-reviewers at lists.wordpress.org
>>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>>
>>>>
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>>
>> --
>> My Blog: http://pross.org.uk/
>> Plugins : http://pross.org.uk/plugins/
>> Themes: http://wordpress.org/extend/themes/profile/pross
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>


-- 
-Doug
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130707/136b65b6/attachment-0001.html>


More information about the theme-reviewers mailing list