[theme-reviewers] Class names not in quotes, code indentation

Daniel Fenn danielx386 at gmail.com
Sun Feb 17 10:50:16 UTC 2013


Ah you got me, but that a better answer anyways.

On 2/17/13, Abhik Biswas <abhik at itsabhik.com> wrote:
> http://codex.wordpress.org/WordPress_Coding_Standards#Quotes
>
>
> On Sun, Feb 17, 2013 at 4:09 PM, Alex Watson <alex at alexwatson.co.uk> wrote:
>
>>  Hi all
>>
>> I'm reviewing a theme where on the whole they don't use quotes for
>> class/ID's - <div id=main> for example. This is fine, as far as I'm
>> aware,
>> but on some pages they have mixed this with class names that do use
>> quotes
>> <h3 class="green"> for example. Now I know none of this will stop their
>> theme passing the review, but should I recommend that they keep things
>> consistent and stick to one or the other?
>>
>> Secondly, their code indentation isn't great. In fact on some pages its
>> completely awful. Again this doesn't matter, but I'm a bit of a
>> perfectionist when it comes to writing code myself, and seeing badly
>> indented code really bugs me! It also makes it harder to read the code.
>>
>> What do the rest of you do when you encounter either of the above? Just
>> let it slide because it doesn't affect how the theme functions?
>>
>> Many thanks
>>
>> Alex
>>
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>


-- 
Regards,
Daniel Fenn


More information about the theme-reviewers mailing list