[theme-reviewers] Figerty Theme

Mon May 28 12:43:07 UTC 2012

For what it's worth, The latest version of TwentyTen doesn't use the
constants, that change was made before WordPress 3.3 was released:
http://core.trac.wordpress.org/ticket/18071

Theme review guidelines are always changing, they evolve as WordPress
expands, grows up, and fixes bugs, You can never simply take
guidelines at one point in time, and apply it retrospectively to all
previous themes, and apply it to all future themes, both will need
flex and constant maintenance.
Using the TEMPLATEPATH constants is one of those things that works
fine in 99% of cases, but causes headaches in others, there's a reason
that's under the Code Quality heading.
for some background on that, there's some info here:
http://core.trac.wordpress.org/ticket/18298

Please note, I'm not part of the theme reviewer team, I don't have the
time myself to donate to reviewing themes. Those that do do, do it
because they love Themes, and they want to see more high quality
themes that just work, Take theme reviewers _suggestions_ on hand, and
realise that the guidelines they're reviewing against have been
thought through to be the best for users, and to attempt to be
flexible to developers as much as possible as well.
In this case, on this specific part, replacing the constants with the
functions requires no significant work on your behalf, and it
significantly increases the ability for the theme to stand by itself
in the future, and that is why the reviews happen, to HELP you make  a
better theme, not to frustrate you.

Please don't hate reviewers, they love you more than you may realise,
by being negitive and rash you're only making people not want to deal
with you, stand back, take a breath, and sit down at the table and
work through each point raised, remember, the not-approved status is
simply due to failing to meet the published requirements, you don't
need to bend to a reviewers suggestions, but you do have to meet the
theme review requirements.
Sometimes there are valid reasons to not meet a requirement, and in
that case, stating your case without acting like a child can mean it's
accepted, but you need to say why you shouldn't have to follow the
requirement rather than calling BS.

On 28 May 2012 21:33, Central Victorian Irish Association
<info at cvia.com.au> wrote:
> Can someone please do another review on this?
> The reasons given by the reviewer are completely unjustified. He denied the
> theme based on the suggestions given when running the theme check plugin,
> such as THEMEPATH not being used.
> The theme is based on Twenty Ten which uses THEMEPATH. So, if this is not
> allowed, why is TwentyTen being used in Wordpress as a secondary default?
>
> http://themes.trac.wordpress.org/ticket/7947
>
> Someone please take a look into this.
>
> Thanks,
> Very Frustrated Dan.
>
> -----Original Message----- From: theme-reviewers-request at lists.wordpress.org
> Sent: Sunday, May 27, 2012 10:00 PM
> To: theme-reviewers at lists.wordpress.org
> Subject: theme-reviewers Digest, Vol 24, Issue 73
>
> Send theme-reviewers mailing list submissions to
> theme-reviewers at lists.wordpress.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> or, via email, send a message with subject or body 'help' to
> theme-reviewers-request at lists.wordpress.org
>
> You can reach the person managing the list at
> theme-reviewers-owner at lists.wordpress.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of theme-reviewers digest..."
>
>
> Today's Topics:
>
>  1. Re: Selling other content on Theme's web site (Bruce Wampler)
>  2. Re: Theme Review (Central Victorian Irish Association)
>  3. Re: Theme Review (Konstantin Obenland)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Sat, 26 May 2012 13:00:08 -0600
> From: Bruce Wampler <weavertheme at gmail.com>
> Subject: Re: [theme-reviewers] Selling other content on Theme's web
> site
> To: theme-reviewers at lists.wordpress.org
> Message-ID:
> <CAPQb4LPmpF_MosYvGvjmPwNOhxRJBLFtKsyTj27ZQvWCMNTm6g at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> I don't think this is the same issue. We are talking about selling non-GPL
> data (banner images, theme design data files). The theme itself remains
> GPL. We're talking about data to use with the theme/plugin.
>
> The question relates to the policy of WP of not providing non-GPL content
> on a site linked to directly from a theme/plugin in the repository.
>
>> From Chip's answer, and past discussions, I think it is okay for such a
>
> site to include third party advertisements and indirect links to other
> external commercial sites sites. But selling non-GPL content directly from
> such a site is not allowed.
>
> I'm sure that if ads and other external links were not allowed, there would
> a lot of plugin/theme support sites in violation of policy.
>
> Bruce
>
> On Sat, May 26, 2012 at 11:15 AM, Yulian Yordanov
> <yul.yordanov at gmail.com>wrote:
>
>>  *These people would probably prefer to not GPL their designs*.
>>
>> This is against GPL as it's written in their webpage
>> http://www.gnu.org/licenses/gpl.html
>>
>> The GNU General Public License does not permit incorporating your program
>> into proprietary programs. If your program is a subroutine library, you
>> may
>> consider it more useful to permit linking proprietary applications with
>> the
>> library. If this is what you want to do, use the GNU Lesser General Public
>> License instead of this License. But first, please read <
>> http://www.gnu.org/philosophy/why-not-lgpl.html>.
>>
>>
>> Yulian
>>
>>
>>
>> --
>> Yulian Yordanov
>>
>> yul.yordanov at gmail.com
>> post-scriptum.info
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120526/41b1e8a5/attachment.htm>
>
> ------------------------------
>
> Message: 2
> Date: Sun, 27 May 2012 21:28:59 +1000
> From: "Central Victorian Irish Association" <info at cvia.com.au>
> Subject: Re: [theme-reviewers] Theme Review
> To: <theme-reviewers at lists.wordpress.org>
> Message-ID: <9EDACD4D4254477190F94277C80FBF92 at DannoLapTop>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Hi folks,
> I have uploaded the newer version -
> http://themes.trac.wordpress.org/ticket/7947
> However, I would still like to see the theme reviewed. I know everyone is
> volunteer reviewers, which I am currently in the process of becoming myself.
> But seeing themes that were submitted after mine and reviewed/approved etc
> before mine is a little ridiculous. I am sure you will all agree.
> So, can someone please take it and give a yay or nay on it?
>
> Cheers,
> Dan
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120527/b48cc271/attachment-0001.htm>
>
> ------------------------------
>
> Message: 3
> Date: Sun, 27 May 2012 13:42:22 +0200
> From: Konstantin Obenland <konstantin at obenland.it>
> Subject: Re: [theme-reviewers] Theme Review
> To: theme-reviewers at lists.wordpress.org
> Message-ID: <6378A8C0-1296-46A8-A211-7C278CED96DB at obenland.it>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Hi Dan,
>
> So you want your ticket to be reviewed before other tickets, which were
> submitted before yours? :)
>
> Your first ticket will not lose its rank it the queue. When your first
> ticket gets picked up, the reviewer will review your second ticket
> automatically.
> Plus: Since your first ticket will soon become a Priority #2 ticket, you can
> expect it to be picked up shortly.
>
> Thanks,
> Konstantin
>
>
> On 27.05.2012, at 13:28, Central Victorian Irish Association wrote:
>
>> Hi folks,
>> I have uploaded the newer version -
>> http://themes.trac.wordpress.org/ticket/7947
>> However, I would still like to see the theme reviewed. I know everyone is
>> volunteer reviewers, which I am currently in the process of becoming myself.
>> But seeing themes that were submitted after mine and reviewed/approved etc
>> before mine is a little ridiculous. I am sure you will all agree.
>> So, can someone please take it and give a yay or nay on it?
>>
>> Cheers,
>> Dan
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120527/16f6badb/attachment-0001.htm>
>
> ------------------------------
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
> End of theme-reviewers Digest, Vol 24, Issue 73
> ***********************************************
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers