[theme-reviewers] Custom implementation of required hooks

Konstantin Obenland obenland at gmx.de
Sun Mar 11 18:41:06 UTC 2012


Hm, seems like the spam guard of my mail provider messed up the Subject and my last message got displaced:

> Konstantin Obenland obenland at gmx.de 
> Sat Mar 10 21:33:27 UTC 2012
>
> I found this ticket from almost 2 years ago:
> http://core.trac.wordpress.org/ticket/13578
> Do you see any chance to revive it?
>
> In the meantime: Would it help my case if you could the implementation?
> Because it's basically just wp_link_pages() with <li>s.
>
> Konstantin

I added a patch to the ticket yesterday - but the ticket is like 2 years old...
Would you mind having a look at it and let me know what you think?

Do you mean the 'wp_link_pages_args' filter?

Thanks,
Konstantin

-------- Original-Nachricht --------
> Datum: Sun, 11 Mar 2012 13:02:02 -0400
> Von: Edward Caissie <edward.caissie at gmail.com>
> An: theme-reviewers at lists.wordpress.org
> Betreff: Re: [theme-reviewers] Custom implementation of required hooks

> Actually, now that I have read the inline docs, the function is performing
> exactly as expected and described by Konstantin.
> Although there is a filter in there that may be able to be worked with ...
> 
> 
> Cais.
> 
> 
> On Sun, Mar 11, 2012 at 12:48 PM, Edward Caissie
> <edward.caissie at gmail.com>wrote:
> 
> > If the function does behave as Konstantin is stating (still untested) I
> > agree with Chip, a patch is definitely in order ... or the documentation
> > needs to be much more clear.
> >
> >
> > Cais.
> >
> >
> >
> > On Sat, Mar 10, 2012 at 3:12 PM, Chip Bennett
> <chip at chipbennett.net>wrote:
> >
> >> I understand your question now. :)
> >>
> >> I agree that the markup output by wp_link_pages() is... lacking.
> However,
> >> I would much rather see a core patch to improve the default markup than
> >> have Themes roll their own custom markup.
> >>
> >> Thanks,
> >>
> >> Chip
> >>
> >> On Sat, Mar 10, 2012 at 5:47 AM, Konstantin Obenland
> <obenland at gmx.de>wrote:
> >>
> >>> I have a question concerning wp_link_pages().
> >>> In the codex, the function is listed under "Required Hooks and
> >>> Navigation" (
> >>>
> http://codex.wordpress.org/Theme_Review#Required_Hooks_and_Navigation).
> >>> Would it be okay for a theme to provide the same functionality, but
> with
> >>> a custom implementation?
> >>> In this case it's echoing it as an unordered list, which can't be
> >>> achieved through passing arguments to wp_link_pages().
> >>>
> >>> Looking forward to your insights,
> >>> Konstantin
-- 
NEU: FreePhone 3-fach-Flat mit kostenlosem Smartphone!                                  
Jetzt informieren: http://mobile.1und1.de/?ac=OM.PW.PW003K20328T7073a


More information about the theme-reviewers mailing list