[theme-reviewers] Something we need to check for 3.4 appearance -> background

[Philip M. Hofer (Frumph)]

Then what is stopping you from creating your own callback to specify a 
background-image: none;  ?

Or even writing a patch that has a button to enable a none background image 
that keeps the custom-background class and style ?

Just clearing the background image, "remove image"  should coincide with its 
utilization and effect in the same manner that not assigning default 
$arguments presents.   Which it now currently does.

I would like to read more thoughts on how to make what you want happen with 
giving the ability to the end user to have no-image other then removing of 
all settings in the appearance -> background section of the wp-admin.

I am sure there could be other methods implemented including that of a 
button in the wp-admin -> appearance -> background.



-----Original Message----- 
From: Otto
Sent: Tuesday, June 12, 2012 1:16 PM
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] Something we need to check for 3.4 
appearance -> background

On Tue, Jun 12, 2012 at 2:58 PM, Philip M. Hofer (Frumph)
<philip at frumph.net> wrote:
> Correct, it’s now working as it should, minus the flaw of not having 
> enough
> $arguments to actually utilize the plethora of different abilities [
> background: ] has.   There is no comprehensive way to tell the background
> image to be fixed, centered or position-x/y.

Correct, however those are handled by the callback, which can be
redefined via the wp-head-callback argument, if you so choose.

> Requiring that the theme not implement any background to the body class is
> not necessary.

Yes, it is, because if a background is assigned to the body class,
then removal of that background is no longer possible. If you add a
background element to the body in the stylesheet, then you are not
implementing the custom-background functionality properly.


> I foresee in the future that those $arguments being passed to the 
> $defaults
> = array will include but not limited to such things as
> (bool)‘background-image-none’,  ‘background-position-x’,
> ‘background-position-y’, ‘background-attachment’, etc.

Probably. Until then, the theme can implement those by creating their
own callback, if desired.


-Otto
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers