[theme-reviewers] Something we need to check for 3.4 appearance -> background

[Philip M. Hofer (Frumph)]

Thought I did, but I'll do it again.

Parent theme is updated to have arguments specifying a background.
\/ ---- in order of execution
Parent Style.css:
body { background-image: none; }

Child Style.css:
body { background-image: url('specifictochildtheme.jpg'); }

Some Plugin (if even used to override)
body { background-image: url('somepluginoverride.jpg'); }

The above two/three are *never* be seen because of this:
body.custom-background exists and body.custom-background { background-image: 
none; }

Thousand and thousands of child themes that were developed would suddenly 
have "issues" because the custom-background background-image: none; will 
override all.

All to have an implementation in the backend to remove a background.




-----Original Message----- 
From: Otto
Sent: Monday, June 11, 2012 4:09 PM
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] Something we need to check for 3.4 
appearance -> background

On Mon, Jun 11, 2012 at 6:06 PM, Philip M. Hofer (Frumph)
<philip at frumph.net> wrote:
> 1) End user upgrades their theme (cause well hey it's a good idea)
> 2) End user promptly sends me an email saying his Child Theme no longer
> works.  Ya know, that one I wrote for him that cost him hundreds of 
> dollars
> of time involved.

... I fail to see how Step #1 leads to Step #2, unless you wrote the
child theme incorrectly. The custom background doesn't magically get
reset because you upgraded a theme.

Could you explain in a sensible way? Preferably using actual code so I
can understand what you're talking about?

-Otto
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers